From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7571A0561 for ; Thu, 27 Feb 2020 18:39:16 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C578937AF; Thu, 27 Feb 2020 18:39:16 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id A05072C02 for ; Thu, 27 Feb 2020 18:39:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582825155; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=krY/m46CdXiwzNtn9I21kqOqBlcbHBlIrwqmBg2STck=; b=C+QwiqsMsLgAyGmdfzNuEX08rPfamERUk4mwbidgX6Dg+x99AFV9CuOyoOl+5Qa3c9kg+M YqVlqjI/rUX8sJ0siOw3sBS+3w+7y24rZt7P/66uC6n+dpARqcicqsVDlp5Xxfcp6zLSRh x03gnZ4jao5zVjP/dh7eOAzRQIYANw8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-384-g5XeVVRuPA272VaUYAd8Yg-1; Thu, 27 Feb 2020 12:39:11 -0500 X-MC-Unique: g5XeVVRuPA272VaUYAd8Yg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A456618C35A2; Thu, 27 Feb 2020 17:39:10 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.123]) by smtp.corp.redhat.com (Postfix) with ESMTP id AED078C087; Thu, 27 Feb 2020 17:39:08 +0000 (UTC) From: Kevin Traynor To: Ferruh Yigit Cc: Andrew Rybchenko , dpdk stable Date: Thu, 27 Feb 2020 17:38:02 +0000 Message-Id: <20200227173807.28004-11-ktraynor@redhat.com> In-Reply-To: <20200227173807.28004-1-ktraynor@redhat.com> References: <20200227173807.28004-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'net/sfc: fix log format specifiers' has been queued to LTS release 18.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/02/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/c3355d30cafe3494b8= a3b437b4261572c041be7b Thanks. Kevin. --- >From c3355d30cafe3494b8a3b437b4261572c041be7b Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Wed, 19 Feb 2020 14:04:57 +0000 Subject: [PATCH] net/sfc: fix log format specifiers [ upstream commit 6b9a30d9e93da9f6c167249ba4d79fd5470b7e17 ] The format specifier for the 'size_t' format should be '%z'. Also this fix enables compiling PMD for 32bit architecture. Fixes: ba641f207642 ("net/sfc: add init on attach") Fixes: 82faef507608 ("net/sfc: set RSS key and hash types config") Fixes: 7803554a9e38 ("net/sfc: process RSS settings on Rx configure step") Signed-off-by: Ferruh Yigit Reviewed-by: Andrew Rybchenko --- drivers/net/sfc/sfc.c | 2 +- drivers/net/sfc/sfc_ethdev.c | 2 +- drivers/net/sfc/sfc_rx.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/sfc/sfc.c b/drivers/net/sfc/sfc.c index 0d7311d687..d056d12164 100644 --- a/drivers/net/sfc/sfc.c +++ b/drivers/net/sfc/sfc.c @@ -31,5 +31,5 @@ sfc_dma_alloc(const struct sfc_adapter *sa, const char *n= ame, uint16_t id, =09const struct rte_memzone *mz; =20 -=09sfc_log_init(sa, "name=3D%s id=3D%u len=3D%lu socket_id=3D%d", +=09sfc_log_init(sa, "name=3D%s id=3D%u len=3D%zu socket_id=3D%d", =09=09 name, id, len, socket_id); =20 diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index 8c7d224300..fa38417b7c 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c @@ -1461,5 +1461,5 @@ sfc_dev_rss_hash_update(struct rte_eth_dev *dev, =09if ((rss_conf->rss_key !=3D NULL) && =09 (rss_conf->rss_key_len !=3D sizeof(rss->key))) { -=09=09sfc_err(sa, "RSS key size is wrong (should be %lu)", +=09=09sfc_err(sa, "RSS key size is wrong (should be %zu)", =09=09=09sizeof(rss->key)); =09=09return -EINVAL; diff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c index 630f6b455a..960ab62c19 100644 --- a/drivers/net/sfc/sfc_rx.c +++ b/drivers/net/sfc/sfc_rx.c @@ -1323,5 +1323,5 @@ sfc_rx_process_adv_conf_rss(struct sfc_adapter *sa, =09if (conf->rss_key !=3D NULL) { =09=09if (conf->rss_key_len !=3D sizeof(rss->key)) { -=09=09=09sfc_err(sa, "RSS key size is wrong (should be %lu)", +=09=09=09sfc_err(sa, "RSS key size is wrong (should be %zu)", =09=09=09=09sizeof(rss->key)); =09=09=09return EINVAL; --=20 2.21.1 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092020-02-27 17:26:24.325565665 +0000 +++ 0011-net-sfc-fix-log-format-specifiers.patch=092020-02-27 17:26:23.6588= 30932 +0000 @@ -1 +1 @@ -From 6b9a30d9e93da9f6c167249ba4d79fd5470b7e17 Mon Sep 17 00:00:00 2001 +From c3355d30cafe3494b8a3b437b4261572c041be7b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 6b9a30d9e93da9f6c167249ba4d79fd5470b7e17 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index 141c767f09..c6b514ac2f 100644 +index 0d7311d687..d056d12164 100644 @@ -35 +36 @@ -index 454b8956a2..098038fbc0 100644 +index 8c7d224300..fa38417b7c 100644 @@ -38 +39 @@ -@@ -1521,5 +1521,5 @@ sfc_dev_rss_hash_update(struct rte_eth_dev *dev, +@@ -1461,5 +1461,5 @@ sfc_dev_rss_hash_update(struct rte_eth_dev *dev, @@ -46 +47 @@ -index 74218296cd..7afd2c8b33 100644 +index 630f6b455a..960ab62c19 100644 @@ -49 +50 @@ -@@ -1404,5 +1404,5 @@ sfc_rx_process_adv_conf_rss(struct sfc_adapter *sa, +@@ -1323,5 +1323,5 @@ sfc_rx_process_adv_conf_rss(struct sfc_adapter *sa,