From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 991F5A0561 for ; Thu, 27 Feb 2020 18:39:33 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8F9A62C02; Thu, 27 Feb 2020 18:39:33 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id EF4191BFC7 for ; Thu, 27 Feb 2020 18:39:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582825172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TQHeVy0YwxOt72DmgrE0d8aTVaZSsROQEIr1ZMkBAhM=; b=DJ62OUETT1GMH7zDroCuxsKI79cR1PRggRklfxISQURyZV7zovjIqlgJgpHkPefcrwiwBB IOGOX0gPnfYYSWCYoCa/HKRM4EA4KRe5pRRtM2x02eLbJYpmdKcEgHvNF46c+wHCm6xCfM emh+TWKl5TptWml0720wPfSC6NqF6gg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-300-K3Dzpzb-PPuyKZHwRGDkRw-1; Thu, 27 Feb 2020 12:39:28 -0500 X-MC-Unique: K3Dzpzb-PPuyKZHwRGDkRw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 68D69107B270; Thu, 27 Feb 2020 17:39:27 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.123]) by smtp.corp.redhat.com (Postfix) with ESMTP id 065CB8D540; Thu, 27 Feb 2020 17:39:21 +0000 (UTC) From: Kevin Traynor To: Wisam Jaddo Cc: Bernard Iremonger , dpdk stable Date: Thu, 27 Feb 2020 17:38:05 +0000 Message-Id: <20200227173807.28004-14-ktraynor@redhat.com> In-Reply-To: <20200227173807.28004-1-ktraynor@redhat.com> References: <20200227173807.28004-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'app/testpmd: fix identifier size for port attach' has been queued to LTS release 18.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/02/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/7c18f03d0856719b3d= 80cc81812b7af28b5f6b66 Thanks. Kevin. --- >From 7c18f03d0856719b3d80cc81812b7af28b5f6b66 Mon Sep 17 00:00:00 2001 From: Wisam Jaddo Date: Wed, 19 Feb 2020 18:47:30 +0200 Subject: [PATCH] app/testpmd: fix identifier size for port attach [ upstream commit f1cfa5687f2c7641e89cba60d1c2fb774e591cc7 ] Identifier for new port may contain white list options, and white list options will not fit into 128 from STR_TOKEN_SIZE, instead having 4096 char from STR_MULTI_TOKEN_SIZE will provide better and more options Fixes: edab33b1c01d ("app/testpmd: support port hotplug") Signed-off-by: Wisam Jaddo Acked-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 27ce5d1880..26295130c5 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -1411,5 +1411,5 @@ struct cmd_operate_attach_port_result { =09cmdline_fixed_string_t port; =09cmdline_fixed_string_t keyword; -=09cmdline_fixed_string_t identifier; +=09cmdline_multi_string_t identifier; }; =20 @@ -1434,5 +1434,5 @@ cmdline_parse_token_string_t cmd_operate_attach_port_= keyword =3D cmdline_parse_token_string_t cmd_operate_attach_port_identifier =3D =09TOKEN_STRING_INITIALIZER(struct cmd_operate_attach_port_result, -=09=09=09identifier, NULL); +=09=09=09identifier, TOKEN_STRING_MULTI); =20 cmdline_parse_inst_t cmd_operate_attach_port =3D { --=20 2.21.1 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092020-02-27 17:26:24.532231997 +0000 +++ 0014-app-testpmd-fix-identifier-size-for-port-attach.patch=092020-02-27= 17:26:23.685830371 +0000 @@ -1 +1 @@ -From f1cfa5687f2c7641e89cba60d1c2fb774e591cc7 Mon Sep 17 00:00:00 2001 +From 7c18f03d0856719b3d80cc81812b7af28b5f6b66 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit f1cfa5687f2c7641e89cba60d1c2fb774e591cc7 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 38b6d804c6..a037a55c6a 100644 +index 27ce5d1880..26295130c5 100644 @@ -24 +25 @@ -@@ -1447,5 +1447,5 @@ struct cmd_operate_attach_port_result { +@@ -1411,5 +1411,5 @@ struct cmd_operate_attach_port_result { @@ -31 +32 @@ -@@ -1470,5 +1470,5 @@ cmdline_parse_token_string_t cmd_operate_attach_port= _keyword =3D +@@ -1434,5 +1434,5 @@ cmdline_parse_token_string_t cmd_operate_attach_port= _keyword =3D