From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 32C2FA0561 for ; Thu, 27 Feb 2020 18:38:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2BE8537AF; Thu, 27 Feb 2020 18:38:46 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 0A6AE1BF76 for ; Thu, 27 Feb 2020 18:38:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582825124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5szDszPlqjbBcz4taGL9MyBwIl/9JMO9mmGWuqsVcxo=; b=FA4Z9UPOcGp7xvtWnUkFHDV6n9J74s/MlBtx+fRLgMrZDJxbab0vKzYc01MmJaPFhks0DO PTAxaD4J3n10ShMQX+yHWAkvai5YmdtbBWAdwyxIZZBI501mAUVkpSnbBfARF8r/8rKQr+ CHh74p+Kn0GO93pY4cDcFo8TnjQbtGY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-321-u55y-8c2M6KIhx90rgcdsw-1; Thu, 27 Feb 2020 12:38:40 -0500 X-MC-Unique: u55y-8c2M6KIhx90rgcdsw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 83347107ACC4; Thu, 27 Feb 2020 17:38:39 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.123]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6596A8C087; Thu, 27 Feb 2020 17:38:38 +0000 (UTC) From: Kevin Traynor To: Manish Chopra Cc: Rasesh Mody , dpdk stable Date: Thu, 27 Feb 2020 17:37:55 +0000 Message-Id: <20200227173807.28004-4-ktraynor@redhat.com> In-Reply-To: <20200227173807.28004-1-ktraynor@redhat.com> References: <20200227173807.28004-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'net/qede: do not stop vport if not started' has been queued to LTS release 18.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/02/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/d94e39f6f4635ddd71= 57afb0651310a2f0810ddd Thanks. Kevin. --- >From d94e39f6f4635ddd7157afb0651310a2f0810ddd Mon Sep 17 00:00:00 2001 From: Manish Chopra Date: Thu, 6 Feb 2020 12:01:46 -0800 Subject: [PATCH] net/qede: do not stop vport if not started [ upstream commit bf44e27af5a4840b2965c71a89eccfc01b5c58bf ] Stopping an already disabled vport leads to firmware assert. Stop the vport only if it was started. Fixes: 2ea6f76aff40 ("qede: add core driver") Signed-off-by: Manish Chopra Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.= c index c8291839c5..49f7b32056 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -1443,5 +1443,6 @@ static void qede_dev_close(struct rte_eth_dev *eth_de= v) =09=09qede_dev_stop(eth_dev); =20 -=09qede_stop_vport(edev); +=09if (qdev->vport_started) +=09=09qede_stop_vport(edev); =09qdev->vport_started =3D false; =09qede_fdir_dealloc_resc(eth_dev); --=20 2.21.1 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092020-02-27 17:26:23.908283210 +0000 +++ 0004-net-qede-do-not-stop-vport-if-not-started.patch=092020-02-27 17:26= :23.615831825 +0000 @@ -1 +1 @@ -From bf44e27af5a4840b2965c71a89eccfc01b5c58bf Mon Sep 17 00:00:00 2001 +From d94e39f6f4635ddd7157afb0651310a2f0810ddd Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit bf44e27af5a4840b2965c71a89eccfc01b5c58bf ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 500440c2ca..74dfe895ad 100644 +index c8291839c5..49f7b32056 100644 @@ -22 +23 @@ -@@ -1510,5 +1510,6 @@ static void qede_dev_close(struct rte_eth_dev *eth_d= ev) +@@ -1443,5 +1443,6 @@ static void qede_dev_close(struct rte_eth_dev *eth_d= ev)