[dpdk-stable] [PATCH v1 1/2] net/virtio: fix for out of date comment

[dpdk-stable] [PATCH v1 1/2] net/virtio: fix for out of date comment

[Xiaolong Ye]

Fix the comment that's incorrect as the code evolves.

Fixes: 9470427c88e1 ("net/virtio: do not store PCI device pointer at shared memory")
Cc: stable@dpdk.org

Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
---
 drivers/net/virtio/virtio_ethdev.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index f9d0ea70d..35203940a 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -466,7 +466,7 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx)
 	}
 
 	if (!vtpci_packed_queue(hw) && !rte_is_power_of_2(vq_size)) {
-		PMD_INIT_LOG(ERR, "split virtqueue size is not powerof 2");
+		PMD_INIT_LOG(ERR, "split virtqueue size is not power of 2");
 		return -EINVAL;
 	}
 
@@ -588,8 +588,8 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx)
 		hw->cvq = cvq;
 	}
 
-	/* For virtio_user case (that is when hw->dev is NULL), we use
-	 * virtual address. And we need properly set _offset_, please see
+	/* For virtio_user case (that is when hw->virtio_user_dev is not NULL),
+	 * we use virtual address. And we need properly set _offset_, please see
 	 * VIRTIO_MBUF_DATA_DMA_ADDR in virtqueue.h for more information.
 	 */
 	if (!hw->virtio_user_dev)
-- 
2.17.1

Re: [dpdk-stable] [PATCH v1 1/2] net/virtio: fix for out of date comment

[Maxime Coquelin]

On 3/7/20 2:22 PM, Xiaolong Ye wrote:
> Fix the comment that's incorrect as the code evolves.
> 
> Fixes: 9470427c88e1 ("net/virtio: do not store PCI device pointer at shared memory")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> ---
>  drivers/net/virtio/virtio_ethdev.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> index f9d0ea70d..35203940a 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -466,7 +466,7 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx)
>  	}
>  
>  	if (!vtpci_packed_queue(hw) && !rte_is_power_of_2(vq_size)) {
> -		PMD_INIT_LOG(ERR, "split virtqueue size is not powerof 2");
> +		PMD_INIT_LOG(ERR, "split virtqueue size is not power of 2");
>  		return -EINVAL;
>  	}
>  
> @@ -588,8 +588,8 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx)
>  		hw->cvq = cvq;
>  	}
>  
> -	/* For virtio_user case (that is when hw->dev is NULL), we use
> -	 * virtual address. And we need properly set _offset_, please see
> +	/* For virtio_user case (that is when hw->virtio_user_dev is not NULL),
> +	 * we use virtual address. And we need properly set _offset_, please see
>  	 * VIRTIO_MBUF_DATA_DMA_ADDR in virtqueue.h for more information.
>  	 */
>  	if (!hw->virtio_user_dev)
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime

[dpdk-stable] [PATCH v1 2/2] vhost: remove unused variable

[Xiaolong Ye]

VHOST_FEATURES has been removed in previous refactor.

Fixes: 0917f9d1f059 ("vhost: use new APIs to handle features")
Cc: stable@dpdk.org

Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
---
 lib/librte_vhost/vhost.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
index 2087d1400..507dbf214 100644
--- a/lib/librte_vhost/vhost.h
+++ b/lib/librte_vhost/vhost.h
@@ -543,7 +543,6 @@ extern int vhost_data_log_level;
 #define PRINT_PACKET(device, addr, size, header) do {} while (0)
 #endif
 
-extern uint64_t VHOST_FEATURES;
 #define MAX_VHOST_DEVICE	1024
 extern struct virtio_net *vhost_devices[MAX_VHOST_DEVICE];
 
-- 
2.17.1

Re: [dpdk-stable] [PATCH v1 2/2] vhost: remove unused variable

[Maxime Coquelin]

On 3/7/20 2:22 PM, Xiaolong Ye wrote:
> VHOST_FEATURES has been removed in previous refactor.
> 
> Fixes: 0917f9d1f059 ("vhost: use new APIs to handle features")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> ---
>  lib/librte_vhost/vhost.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
> index 2087d1400..507dbf214 100644
> --- a/lib/librte_vhost/vhost.h
> +++ b/lib/librte_vhost/vhost.h
> @@ -543,7 +543,6 @@ extern int vhost_data_log_level;
>  #define PRINT_PACKET(device, addr, size, header) do {} while (0)
>  #endif
>  
> -extern uint64_t VHOST_FEATURES;
>  #define MAX_VHOST_DEVICE	1024
>  extern struct virtio_net *vhost_devices[MAX_VHOST_DEVICE];
>  
> 


Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime