From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63292A0566 for ; Wed, 11 Mar 2020 04:40:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 23C113B5; Wed, 11 Mar 2020 04:40:25 +0100 (CET) Received: from relay.smtp.broadcom.com (unknown [192.19.211.62]) by dpdk.org (Postfix) with ESMTP id 79DF01BF7F for ; Wed, 11 Mar 2020 04:40:23 +0100 (CET) Received: from dhcp-10-123-153-22.dhcp.broadcom.net (bgccx-dev-host-lnx2.bec.broadcom.net [10.123.153.22]) by relay.smtp.broadcom.com (Postfix) with ESMTP id 96CC02907D7; Tue, 10 Mar 2020 20:40:22 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 96CC02907D7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1583898022; bh=0RUGkqRjtKEZQaATxzXgotuwLEmTc8JiACbt954KHvE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ARNu8VPeHrMwd7wDpHfLEOKVEl1mVfjXjsSRO/zTaxeIwsbZazSKSjAZWuVKoxKBh vZ8xrW50zO9hQYb6NpI5HtvCLh3mResQHRbbVKAPKEZUZu4otKKAPLotsjMBAOtEOz JEFKy6WMAbJpFVeDDUM58sms72bTv2spa6D7Fkpw= From: Kalesh A P To: stable@dpdk.org Cc: luca.boccassi@gmail.com, ajit.khaparde@broadcom.com Date: Wed, 11 Mar 2020 09:26:58 +0530 Message-Id: <20200311035659.24583-2-kalesh-anakkur.purayil@broadcom.com> X-Mailer: git-send-email 2.10.1 In-Reply-To: <20200311035659.24583-1-kalesh-anakkur.purayil@broadcom.com> References: <20200311035659.24583-1-kalesh-anakkur.purayil@broadcom.com> Subject: [dpdk-stable] [PATCH 19.11 1/2] net/bnxt: fix MAC address setting when port is stopped X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" From: Kalesh AP [upstream commit 1009a632c851f687b7f6ccf64875552afbac5c46 ] Driver destroys the VNIC when the port is brought down. Port HW filter setting such as default MAC address and unicast MAC filters will be applied when port is started. Fixed to return success silently for these callbacks when port is stopped. Fixes: 39b88344e364 ("net/bnxt: fix enable/disable VLAN filtering") Reported-by: Stephen Hemminger Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_ethdev.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 802045d..c0b965b 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -1083,6 +1083,10 @@ static int bnxt_mac_addr_add_op(struct rte_eth_dev *eth_dev, return -EINVAL; } + /* Filter settings will get applied when port is started */ + if (!eth_dev->data->dev_started) + return 0; + rc = bnxt_add_mac_filter(bp, vnic, mac_addr, index, pool); return rc; @@ -2076,6 +2080,10 @@ bnxt_set_default_mac_addr_op(struct rte_eth_dev *dev, if (rte_is_zero_ether_addr(addr)) return -EINVAL; + /* Filter settings will get applied when port is started */ + if (!dev->data->dev_started) + return 0; + /* Check if the requested MAC is already added */ if (memcmp(addr, bp->mac_addr, RTE_ETHER_ADDR_LEN) == 0) return 0; -- 2.10.1