From: Didier Pallard <didier.pallard@6wind.com>
To: dev@dpdk.org
Cc: stable@dpdk.org
Subject: [dpdk-stable] [PATCH] net/mlx5: fix Rx descriptor status returned value
Date: Fri, 13 Mar 2020 10:56:59 +0100 [thread overview]
Message-ID: <20200313095659.19000-1-didier.pallard@6wind.com> (raw)
Two bugs in rx_queue_count function:
- One entry may contain several segments, so 'used' must be multiplied
by number of segments per entry to properly reflect the queue usage.
- rx_queue_count returns the number of entries used in queue, so it ranges
from 0 to max number of entries in queue, not this number minus
one.
Fixes: 8788fec1f269 ("net/mlx5: implement descriptor status API")
Cc: stable@dpdk.org
Signed-off-by: Didier Pallard <didier.pallard@6wind.com>
---
drivers/net/mlx5/mlx5_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
index 5ac63da8039d..17f80c25443e 100644
--- a/drivers/net/mlx5/mlx5_rxtx.c
+++ b/drivers/net/mlx5/mlx5_rxtx.c
@@ -500,7 +500,7 @@ rx_queue_count(struct mlx5_rxq_data *rxq)
used += n;
cqe = &(*rxq->cqes)[cq_ci & cqe_cnt];
}
- used = RTE_MIN(used, (1U << rxq->elts_n) - 1);
+ used = RTE_MIN(used * (1 << rxq->sges_n), 1U << rxq->elts_n);
return used;
}
--
2.24.1
next reply other threads:[~2020-03-13 9:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 9:56 Didier Pallard [this message]
2020-03-16 16:05 ` [dpdk-stable] [dpdk-dev] " Slava Ovsiienko
2020-03-16 17:24 ` Didier Pallard
2020-03-17 8:33 ` Slava Ovsiienko
2020-03-17 9:19 ` Didier Pallard
2020-03-17 9:25 ` Slava Ovsiienko
2020-03-17 9:41 ` Didier Pallard
2020-10-29 11:29 ` Didier Pallard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313095659.19000-1-didier.pallard@6wind.com \
--to=didier.pallard@6wind.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).