From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E01EA0579 for ; Wed, 18 Mar 2020 06:57:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 820021C06D; Wed, 18 Mar 2020 06:57:46 +0100 (CET) Received: from relay.smtp.broadcom.com (relay.smtp.broadcom.com [192.19.211.62]) by dpdk.org (Postfix) with ESMTP id 1F23F1C068 for ; Wed, 18 Mar 2020 06:57:45 +0100 (CET) Received: from dhcp-10-123-153-55.dhcp.broadcom.net (dhcp-10-123-153-55.dhcp.broadcom.net [10.123.153.55]) by relay.smtp.broadcom.com (Postfix) with ESMTP id 1DC65290AA1 for ; Tue, 17 Mar 2020 22:57:44 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 1DC65290AA1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1584511064; bh=qpO7jadtyYLujztEGtw2pks50epGDuUzlG7SfIi8lyQ=; h=From:To:Subject:Date:In-Reply-To:References:From; b=qJUz9j45f5OX/CcyS/iidnQ/MXyOyboQtsFOP1LZ7H8VERgR+SWsXX4h/BxIaYper 71jU2EFuDPm/6UdNxtcHFiSZxprHhF+7sXeAbY4HTRNP0u6s/6eeNe6+gsFzJEGgoL WnPvNZRNouVyZIhto9dw5OoZxfNdA9R/cGnIB+NA= From: Somnath Kotur To: stable@dpdk.org Date: Wed, 18 Mar 2020 11:25:11 +0530 Message-Id: <20200318055513.21622-3-somnath.kotur@broadcom.com> X-Mailer: git-send-email 2.10.1.613.g2cc2e70 In-Reply-To: <20200318055513.21622-1-somnath.kotur@broadcom.com> References: <20200318055513.21622-1-somnath.kotur@broadcom.com> Subject: [dpdk-stable] [PATCH 18.11 2/4] net/bnxt: fix probe in FreeBSD X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" From: Kalesh AP In FreeBSD environment, nic_uio driver does not support interrupts and rte_intr_callback_register() will fail to register interrupts which in turn causes bnxt driver probe failure. Fixed driver to ignore interrupt callback failures in FreeBSD. Fixes: 6de4c538b393 ("net/bnxt: fix error handling in port start") Fixes: 43f78b380f89 ("net/bnxt: retry IRQ callback deregistration") Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde Reviewed-by: Santoshkumar Karanappa Rastapur Signed-off-by: Somnath Kotur --- drivers/net/bnxt/bnxt_ethdev.c | 3 +++ drivers/net/bnxt/bnxt_irq.c | 7 +++++++ 2 files changed, 10 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 878b9f5..f222c79 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -342,8 +342,11 @@ static int bnxt_init_chip(struct bnxt *bp) /* enable uio/vfio intr/eventfd mapping */ rc = rte_intr_enable(intr_handle); +#ifndef RTE_EXEC_ENV_FREEBSD + /* In FreeBSD OS, nic_uio driver does not support interrupts */ if (rc) goto err_free; +#endif rc = bnxt_get_hwrm_link_config(bp, &new); if (rc) { diff --git a/drivers/net/bnxt/bnxt_irq.c b/drivers/net/bnxt/bnxt_irq.c index 57365d7..b5f30bb 100644 --- a/drivers/net/bnxt/bnxt_irq.c +++ b/drivers/net/bnxt/bnxt_irq.c @@ -152,6 +152,13 @@ int bnxt_request_int(struct bnxt *bp) if (!rc) irq->requested = 1; } + #ifdef RTE_EXEC_ENV_FREEBSD + /** + * In FreeBSD OS, nic_uio does not support interrupts and + * interrupt register callback will fail. + */ + rc = 0; + #endif return rc; } -- 1.8.3.1