From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 263B5A0584 for ; Thu, 19 Mar 2020 16:46:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 018D12BAA; Thu, 19 Mar 2020 16:46:12 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 84667F94; Thu, 19 Mar 2020 16:46:09 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 02JFa5Cp002454; Thu, 19 Mar 2020 08:46:08 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pfpt0818; bh=Plz5of25NbzOsvtt8kM8V4iu7sYWY2RNkPPHMub26ew=; b=x5BzfD/c2tlBBeZg+Z+ehROi33rARV29eeCOSfs8wi1rVA8KybwwGGgiknksqpROomwN mX1FkJONE90cw1CfapNpywMSqkowOjZnOGL2KLFm4r9mHfHq5xVI+BqCjXPL2DOEenwg bzgPnb8vhE+gbIi1yzdGGS9fv1+KqbHhiphnbKSePDef6UBTutlDTu9srz6CBKD49w/x 048SFV/OBCJKf9m0qzVilf0Aq1nrcTjXmyet1Qu9jj9IpH8c3+SEjMyf7Rj/3/3r0s7y mikcMpSigdsNuhp248Lu0Oux5NewEUyyMkJrQhK1xWOx1ohUWoA2ujz5Y4Duy3stuOxK CA== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 2yu9rpg101-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 19 Mar 2020 08:46:08 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 19 Mar 2020 08:46:06 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Thu, 19 Mar 2020 08:46:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VdtNJ4N6LTGtSvV6fQA8rXoPR1WByR8La0TiPWicHgvvGokKA4/xdNh8gPz0k8iO+SaopqMELTn1/1PoqrL9QZB7GcSFGRdim6mCRVztNFF20JxG5WCLGPa7DdyOnfa9xzf+A0nFAAu8TDUIDI3prC3tBtLlLMhspDyxJ5bJ/FFsjgSkkRdTViz9EpEFPrBXVJ5Fl6Sdc8fYoC9KTRzuJBIC6jqHZkfeVJQtpVa2AaMWHb7/5YlseUmirr6zOtqTeEHJWU8Fa9fIOyVID+++dZ9nmD599vv20LrqCZu6pw/8Wcl3tYvW72NMTf6kGp6gyOaQHCQwhi+BankG1MHh6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Plz5of25NbzOsvtt8kM8V4iu7sYWY2RNkPPHMub26ew=; b=DA5lUg4F861Xyjes2jzdPKWvuiJ9JLUMarCaves6tL8hbS/MhaSAODRM1P1E6Ku6QiRxljmEACtWw2VLEJ5a5BwhVc6sae1iuGklaY5+Qw1RCJx1v5yZ3w5M5OwtS+4wJ+2SPJ4OlhadEGg2QrI3+PrkhQeOqT1itGb2n7nvtjmT/nUDD5v7dgjSiUxxpKdwX1L/wwUceysLgXRxIT7fPzGotJbyeMnkYm7csMz66++u/zKSC56fX7cLkYPxq2aE4Ag06IaoACGnvC+5zFOZTLbtHu7nbx426pBw5wFyUeOyY+sesVT/i0tFIpPYDa6zMx+SQPsdOqqvETiqgw+l8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Plz5of25NbzOsvtt8kM8V4iu7sYWY2RNkPPHMub26ew=; b=NSAkQNN65dDvyCD6nD+sGwLEAzgQc7uxF2g4FbnhaGnFRVtH0/WX4UbsmYkR+yLep7NxYxV9NtIsbROUG8cUOf7xlFW4gWoWsFhsR2xi/+8XTwfkq9np+cnhGrow4BYqSjDgc/m5cIOE8YFJ3jklu1je0kj6ZrqIsvCO6C5OI+A= Received: from MWHPR1801MB2063.namprd18.prod.outlook.com (2603:10b6:301:6a::11) by MWHPR1801MB1950.namprd18.prod.outlook.com (2603:10b6:301:69::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.18; Thu, 19 Mar 2020 15:46:04 +0000 Received: from MWHPR1801MB2063.namprd18.prod.outlook.com ([fe80::2965:3dfe:ecf5:3145]) by MWHPR1801MB2063.namprd18.prod.outlook.com ([fe80::2965:3dfe:ecf5:3145%3]) with mapi id 15.20.2835.017; Thu, 19 Mar 2020 15:46:04 +0000 Date: Thu, 19 Mar 2020 21:15:50 +0530 From: Nithin Dabilpuram To: Neil Horman CC: David Marchand , Thomas Monjalon , dev , Jerin Jacob Kollanukkaran , dpdk stable , Message-ID: <20200319154550.GA8743@outlook.office365.com> References: <20200319144418.15661-1-ndabilpuram@marvell.com> <20200319154039.GA2864286@hmswarspite.think-freely.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200319154039.GA2864286@hmswarspite.think-freely.org> User-Agent: Mutt/1.12.2 (34cd43c) (2019-09-21) X-ClientProxiedBy: PN1PR01CA0094.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:1::34) To MWHPR1801MB2063.namprd18.prod.outlook.com (2603:10b6:301:6a::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from outlook.office365.com (115.113.156.2) by PN1PR01CA0094.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:1::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.20 via Frontend Transport; Thu, 19 Mar 2020 15:46:01 +0000 X-Originating-IP: [115.113.156.2] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1c176e8e-5ad0-43e8-fec0-08d7cc1ca175 X-MS-TrafficTypeDiagnostic: MWHPR1801MB1950: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1169; X-Forefront-PRVS: 0347410860 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(136003)(346002)(396003)(39860400002)(366004)(199004)(66476007)(966005)(8676002)(81156014)(81166006)(86362001)(55236004)(6666004)(4326008)(53546011)(5660300002)(54906003)(316002)(8936002)(6506007)(2906002)(16526019)(6916009)(66946007)(66556008)(956004)(186003)(26005)(55016002)(9686003)(7696005)(1076003)(52116002)(478600001)(33656002); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR1801MB1950; H:MWHPR1801MB2063.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; Received-SPF: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: r7n3S6KJNRXoy9idU8EKmEv1OfRaCpP+sQTZFcbsij1V/JvKHfWc9fw1KCShf6GO6Tv/4lXS2iwn1u0Tu/IJzgCkOWPGv2NLMlfFbYNuG8PqvERWdhr3K7KbAIHeTi21u6iEiGNlHlSFVerF9ykuRn8+KrBiCI2TPGPyb6P2aHaujiyP/DKYFp8zaHs4NygCB+5EIceFKU+hQ7nWeVasB+SBBoRjtp1i4UX2zKzylmY9Oa/eROFo6h0iWkRv4wBFKs8OGvl5gRy9qVokZj4DfnHE0WfPVjGmLdDpiUf+P1X8ewItq8ySDrD1xjaH1oT6xUYAONXIG64UhjRcHTClk0i189/e3CE6y3imd4LLLHJm9CKNSPCqRUWbkDHaxyNi+DHM4NOcQ0shl3X1gwn+SZ5Uw79B0rIJUqq/I4W/lcnMJWB6skUSRD3B8wbYiNyxwWbJRV4FZEY+dwn1D8XmXuuJMoz0cK/iM59Dm4J87JlKb6LVlfcMkiHRAzIDCpQuKZaaqV3OCszdArCHSnK6cQ== X-MS-Exchange-AntiSpam-MessageData: hj8208Wy7Sxj5cra+fDoHP4lso5RoYjih5CDc1scnz3ZxfbF98kTqdorRxqxqpQ7YXF7igKeF1NHaKDYiczJcoM4pvtoIxyLLJQVUN2zCsruP6LdLTo6PrTGM/ULH7REpg0nm4oUub5OI277rdyHfQ== X-MS-Exchange-CrossTenant-Network-Message-Id: 1c176e8e-5ad0-43e8-fec0-08d7cc1ca175 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2020 15:46:03.8168 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cZgI4B/O01J71mPahYqDRtAKDGw5IQLbTYBgI5I3AxsjQiHiZKBwd1Nhn9yT6xQ0LRwA8jedRW0Ve6DbPKfe2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1801MB1950 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.645 definitions=2020-03-19_05:2020-03-19, 2020-03-19 signatures=0 Subject: Re: [dpdk-stable] [EXT] Re: [PATCH] devtools: fix check symbol change script X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Thu, Mar 19, 2020 at 11:40:39AM -0400, Neil Horman wrote: > External Email > > ---------------------------------------------------------------------- > On Thu, Mar 19, 2020 at 03:56:03PM +0100, David Marchand wrote: > > On Thu, Mar 19, 2020 at 3:44 PM Nithin Dabilpuram > > wrote: > > > > > > Fix check symbol change script to detect new diff file when > > > it is in between "--- /dev/null" to "b/lib/...". > > > Current awk line expects line to start with "a/..." > > > which is not always true for all diffs. > > > As a result if in_map was '1' earlier, it will not be changed > > > to '0' and we get check patch errors which are not true as the non > > > version.map files get interpreted as version map file. > > > > > > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") > > > Cc: nhorman@tuxdriver.com > > > Cc: stable@dpdk.org > > > > There was a previous attempt at fixing this that did not get a review. > > https://urldefense.proofpoint.com/v2/url?u=http-3A__patchwork.dpdk.org_patch_56303_&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=FZ_tPCbgFOh18zwRPO9H0yDx8VW38vuapifdDfc8SFQ&m=HnuykZkNgy_2cx1i0_QuR-C_vdVYLTJ9rSUA1dCM7WI&s=TW-ZZ_dYy8x6EcvJHtYrv9vaIHSmd0GshvClMwiWPi4&e= > > > > I prefer the last submitted patch as it is simpler, but maybe I missed > > something in Bing patch. > > > > Neil, wdyt? > > > I'm not sure why I didn't review the previous patch you refrenced, apologies for > that. > > That said, I'm not sure how this patch detects /dev/null patterns. It looks like > you still expect all lines to start with [+-] [ab]... It doesn't detect /dev/null but the line following /dev/null will start with "b/...". So this checks for .map in that line as well. > > Neil > > > > > -- > > David Marchand > > > > > > > > > > Signed-off-by: Nithin Dabilpuram > > > --- > > > Note: We have two examples where checkpatch errors are because of this > > > because the version.map file change comes earlier in the diff. Because of > > > this bug, any new file change that comes after version.map file diff > > > as "/dev/null" to "b/.." gets misdetected as version.map file. > > > * https://urldefense.proofpoint.com/v2/url?u=http-3A__patches.dpdk.org_patch_66878_&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=FZ_tPCbgFOh18zwRPO9H0yDx8VW38vuapifdDfc8SFQ&m=HnuykZkNgy_2cx1i0_QuR-C_vdVYLTJ9rSUA1dCM7WI&s=0szl1YpYLwfb1OF-R5H4_ci3f5XjBUHFrHVp-LdROFI&e= > > > * https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.dpdk.org_patch_66900_&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=FZ_tPCbgFOh18zwRPO9H0yDx8VW38vuapifdDfc8SFQ&m=HnuykZkNgy_2cx1i0_QuR-C_vdVYLTJ9rSUA1dCM7WI&s=ugH7B1XKoFQEEopU0sJgqKGwjDJS9Kl9OsijSazmyRc&e= > > > devtools/check-symbol-change.sh | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh > > > index c5434f3..19ce82f 100755 > > > --- a/devtools/check-symbol-change.sh > > > +++ b/devtools/check-symbol-change.sh > > > @@ -17,13 +17,13 @@ build_map_changes() > > > # map files are altered, and all section/symbol names > > > # appearing between a triggering of this rule and the > > > # next trigger of this rule are associated with this file > > > - /[-+] a\/.*\.map/ {map=$2; in_map=1} > > > + /[-+] [ab]\/.*\.map/ {map=$2; in_map=1} > > > > > > # Same pattern as above, only it matches on anything that > > > # does not end in 'map', indicating we have left the map chunk. > > > # When we hit this, turn off the in_map variable, which > > > # supresses the subordonate rules below > > > - /[-+] a\/.*\.[^map]/ {in_map=0} > > > + /[-+] [ab]\/.*\.[^map]/ {in_map=0} > > > > > > # Triggering this rule, which starts a line and ends it > > > # with a { identifies a versioned section. The section name is > > > -- > > > 2.8.4 > > > > > > >