From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE1DDA0563 for ; Mon, 23 Mar 2020 10:28:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B12BE1C02E; Mon, 23 Mar 2020 10:28:32 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 58B081C02E; Mon, 23 Mar 2020 10:28:30 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 02N9Q3xJ028303; Mon, 23 Mar 2020 02:28:29 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pfpt0818; bh=SuyUEQ4L1EAUoPCJiIVl38jX0bAZRf9I0aLi9Qbf2IQ=; b=hWtLmUtT4a8KJK62NrV+C6mdt6oxz7lJv3E98WLbmYcpin8LQXDf/3/Ah1m3bYcnsG5C CVaZEWRHLFR4X97EsLV5vScgQhYj9t+WFK8ttf8Yc8KiUZjIPiC0lF2HElB9l6DS+dze KvvnI8HG0C0MKTuf4PkKCvik9wgsmhF2OeYVkq5rlmJYcFoYyaldrLJ0u+rWYNCoJuYn xUt1RUf9cvZjc6XMBjcYmIDVWkJyhEFLEEPeasY2F3l99bx4OlB+6KZnyi54b6Zq5uxd 6fLPL+VQFP5KoMvnRvPghLXGnUcxIfyF7wHIXlNQrShi62FhdWWDhAyTa4lq2ul+q3Ok Bw== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2ywg9ndvc5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 23 Mar 2020 02:28:29 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 23 Mar 2020 02:28:28 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 23 Mar 2020 02:28:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ShQhOiEy5SlZ2IOX0ytDDRWow9C+a2zXjegWJMayi38behxQHzdjilUQkzCl/hoA9OcIJ3cPcW0fgP65Y1Tg9KtV8U2x3BIQ000v/UiIof3mkiGzTqh/ekEeURSZY1/erJp1MbE6Bb+JsVxIzwzTz6ciIwRamJAknWjbGaU7i6HM0WBzc419XYd/7W4fhjGdjalWhsG/GgsGVkzg5wInxGS2Mfz4BH/Y0gJ4hLOMX05a031DP2qKaOkF03EmE3302s1jHpMxfUUDUjn+JHXhBnsppQG8eg+QdOA8hc6aumZPBvZtDoTLh4SX2WP5k4uUUb7Al1kr9LYZpH524X1Huw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SuyUEQ4L1EAUoPCJiIVl38jX0bAZRf9I0aLi9Qbf2IQ=; b=jY9jl/Wgv/BOEuj23JNgOzuaolmJ4QWQrrGE8FZaAF6U5QHS0FXAN1ItkPcg5uwVa/RswDHuiK/k7vTykpDYo1MQaiWzCvYsUKicYnuoveGLZIv6xYOlQ/tLL9Qdu+ryc8WgrtZL2YxI79tQ772il+ZcqNgWmsVj2cndUWTW764Mn+21lA++aimJOarIxtuVviRQb5BjtPVVKCNgK9ry7gRcM4uli+E3Pwb0ft0VdRdaY3YhpK7bZe8IbC2SBGRagYKA/tY5VlWqfY35tTz/0lCi5n6LqLaj2LKIkUuLY3HOT50I0HojOE/r5EiQ4zAQt2Voo5QkE93X4kyPSDCDXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SuyUEQ4L1EAUoPCJiIVl38jX0bAZRf9I0aLi9Qbf2IQ=; b=NQ2SPyISLTBZWo2frWrVbmKf4uAnhzFfOzH7HIVPWtoHwO/4BvlVHtYt4Jd91Y45tYeVmEwvhgwIygDCz98+dmb5v13FdsxemuvTIuaCPk5NIp5usJtpqR4jx1OM3hi6BEjC2wD+cVT9IlCuxHmPO825aqvx6rCMN+YncQE23Mw= Received: from MWHPR1801MB2063.namprd18.prod.outlook.com (2603:10b6:301:6a::11) by MWHPR1801MB1952.namprd18.prod.outlook.com (2603:10b6:301:61::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.19; Mon, 23 Mar 2020 09:28:26 +0000 Received: from MWHPR1801MB2063.namprd18.prod.outlook.com ([fe80::2965:3dfe:ecf5:3145]) by MWHPR1801MB2063.namprd18.prod.outlook.com ([fe80::2965:3dfe:ecf5:3145%3]) with mapi id 15.20.2835.017; Mon, 23 Mar 2020 09:28:26 +0000 Date: Mon, 23 Mar 2020 14:58:09 +0530 From: Nithin Dabilpuram To: David Marchand CC: Thomas Monjalon , Neil Horman , dev , Jerin Jacob Kollanukkaran , dpdk stable , Message-ID: <20200323092809.GA16547@outlook.office365.com> References: <20200319144418.15661-1-ndabilpuram@marvell.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (34cd43c) (2019-09-21) X-ClientProxiedBy: PN1PR01CA0103.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00::19) To MWHPR1801MB2063.namprd18.prod.outlook.com (2603:10b6:301:6a::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from outlook.office365.com (115.113.156.2) by PN1PR01CA0103.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.18 via Frontend Transport; Mon, 23 Mar 2020 09:28:23 +0000 X-Originating-IP: [115.113.156.2] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 19b17568-6d5c-48cb-98f3-08d7cf0c8a1a X-MS-TrafficTypeDiagnostic: MWHPR1801MB1952: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-Forefront-PRVS: 0351D213B3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(396003)(376002)(39850400004)(366004)(346002)(199004)(2906002)(53546011)(55236004)(6506007)(316002)(54906003)(7696005)(52116002)(33656002)(1076003)(6666004)(478600001)(81166006)(81156014)(8676002)(8936002)(6916009)(55016002)(186003)(16526019)(66946007)(66476007)(66556008)(4326008)(26005)(86362001)(956004)(5660300002)(9686003); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR1801MB1952; H:MWHPR1801MB2063.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; Received-SPF: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UdJ/x1c/KXvg+IjlleK1MF3SoJF6DkK5BEeQSfuJEztYg4B2zewrhSBw3OGZW0ATCAd9sou4VCExlMXL+5s6+oe1k6jYEYF2GuWiHascgYCmifPkgj8eE7/5gpcAYngwwTF3i1wEROmRg2cxvi0c5CR1IoxTTIGibA8MxVRwedaOspXZujOLguxMEGpPTr1Vq+C1ANiLGEk5USvMoIB+hhFpOHOEjIt9KE18K4j3tW8ARcxnVH8dxwvcL1wi8aBFxA2OyUJa/cF43sDhoL+N1MBSmQYewZBmXsC9oUgZDRX/K77qyIlKU+LPu78J8xw5T/NSZjti9Wc4lD6DyazrDNeUICvvpORVNafEYlyZmONKZeImQJp0GKVsL2iFzNF4D81aLvjCaWHjpaibfHewOtxqn/Hkwlo8MUN5eJ7IJblmh9kJEQo3QZfBV7LQGpsT X-MS-Exchange-AntiSpam-MessageData: xNVb6yKx3fuBdJkydnwx1v264LRBdQ7u2gf/AvtiA34EgHH6j7GesPtQTcdQylZpQcresOIvABhZDTQH46n72+2UvXmSyhPuv9huvEf0ZyiMwayqiS9JQPVLCHZrpTjAQzo+kKVLSMtCNffiRkHR1g== X-MS-Exchange-CrossTenant-Network-Message-Id: 19b17568-6d5c-48cb-98f3-08d7cf0c8a1a X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2020 09:28:26.2239 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PPQfUXdzl7AT48LwJiDGKrOpHqAQnOEARQRryDJYcdG/GRi4RH1Mn3NRY1PVVlgAKrJ4NkoJGUBD/UJU80qC0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1801MB1952 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.645 definitions=2020-03-23_03:2020-03-21, 2020-03-23 signatures=0 Subject: Re: [dpdk-stable] [EXT] Re: [PATCH] devtools: fix check symbol change script X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Mon, Mar 23, 2020 at 09:13:22AM +0100, David Marchand wrote: > External Email > > ---------------------------------------------------------------------- > On Thu, Mar 19, 2020 at 3:44 PM Nithin Dabilpuram > wrote: > > diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh > > index c5434f3..19ce82f 100755 > > --- a/devtools/check-symbol-change.sh > > +++ b/devtools/check-symbol-change.sh > > @@ -17,13 +17,13 @@ build_map_changes() > > # map files are altered, and all section/symbol names > > # appearing between a triggering of this rule and the > > # next trigger of this rule are associated with this file > > - /[-+] a\/.*\.map/ {map=$2; in_map=1} > > + /[-+] [ab]\/.*\.map/ {map=$2; in_map=1} > > > > # Same pattern as above, only it matches on anything that > > # does not end in 'map', indicating we have left the map chunk. > > # When we hit this, turn off the in_map variable, which > > # supresses the subordonate rules below > > - /[-+] a\/.*\.[^map]/ {in_map=0} > > + /[-+] [ab]\/.*\.[^map]/ {in_map=0} > > [^map] does not mean "not word map" but actually "none of the > character m, a or p". > > So potentially, any file extension starting with m, a or p could > trigger an issue. > For example, a change in .mk files, .py files and > ./devtools/check-forbidden-tokens.awk ./devtools/libabigail.abignore > could lead to incorrect symbol check. > > How about the following change: > > diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh > index c5434f3bb0..ed2178e36e 100755 > --- a/devtools/check-symbol-change.sh > +++ b/devtools/check-symbol-change.sh > @@ -17,13 +17,11 @@ build_map_changes() > # map files are altered, and all section/symbol names > # appearing between a triggering of this rule and the > # next trigger of this rule are associated with this file > - /[-+] a\/.*\.map/ {map=$2; in_map=1} > + /[-+] [ab]\/.*\.map/ {map=$2; in_map=1; next} > > - # Same pattern as above, only it matches on anything that > - # does not end in 'map', indicating we have left the map chunk. > - # When we hit this, turn off the in_map variable, which > - # supresses the subordonate rules below > - /[-+] a\/.*\.[^map]/ {in_map=0} > + # The previous rule catches all .map files, anything else > + # indicates we left the map chunk. > + /[-+] [ab]\// {in_map=0} > > # Triggering this rule, which starts a line and ends it > # with a { identifies a versioned section. The section name is > > Agreed. I tested and it works fine for me. I can send a V2 with this change if it is fine. > -- > David Marchand >