patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Michal Krawczyk <mk@semihalf.com>
Cc: dev@dpdk.org, mw@semihalf.com, mba@semihalf.com,
	gtzalik@amazon.com, evgenys@amazon.com, igorch@amazon.com,
	stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 02/29] net/ena/base: make allocation macros thread-safe
Date: Fri, 27 Mar 2020 07:54:48 -0700	[thread overview]
Message-ID: <20200327075448.417ef984@hermes.lan> (raw)
In-Reply-To: <20200327101823.12646-3-mk@semihalf.com>

On Fri, 27 Mar 2020 11:17:56 +0100
Michal Krawczyk <mk@semihalf.com> wrote:

> From: Igor Chauskin <igorch@amazon.com>
> 
> Memory allocation region id could possibly be non-unique
> due to non-atomic increment, causing allocation failure.
> 
> Fixes: 9ba7981ec992 ("ena: add communication layer for DPDK")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Igor Chauskin <igorch@amazon.com>
> Reviewed-by: Michal Krawczyk <mk@semihalf.com>
> Reviewed-by: Guy Tzalik <gtzalik@amazon.com>

With DPDK all control operations are the device are supposed
to be single threaded by the caller. Do you have an allocation in
some datapath?

  reply	other threads:[~2020-03-27 14:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200327101823.12646-1-mk@semihalf.com>
2020-03-27 10:17 ` [dpdk-stable] " Michal Krawczyk
2020-03-27 14:54   ` Stephen Hemminger [this message]
2020-03-31  9:47     ` [dpdk-stable] [dpdk-dev] " Michał Krawczyk
2020-03-27 10:17 ` [dpdk-stable] [PATCH 03/29] net/ena/base: prevent allocation of 0-sized memory Michal Krawczyk
2020-03-27 10:18 ` [dpdk-stable] [PATCH 15/29] net/ena: set IO ring size to the valid value Michal Krawczyk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200327075448.417ef984@hermes.lan \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=evgenys@amazon.com \
    --cc=gtzalik@amazon.com \
    --cc=igorch@amazon.com \
    --cc=mba@semihalf.com \
    --cc=mk@semihalf.com \
    --cc=mw@semihalf.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).