From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C847CA057C for ; Fri, 27 Mar 2020 15:54:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 819241C210; Fri, 27 Mar 2020 15:54:53 +0100 (CET) Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id D539D1C210 for ; Fri, 27 Mar 2020 15:54:52 +0100 (CET) Received: by mail-pg1-f193.google.com with SMTP id b1so4677866pgm.8 for ; Fri, 27 Mar 2020 07:54:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LEZJelVOWMIkPIWGM2NIO4k5VC4xbOZP4BQXXl6bVr0=; b=HiIMJBbOkhHCTNcQihNLs1kVIKZY4JKAv+RPXSDxc4RKB2eU2zufD+8L3rXHJ2Omlo 2t8IesvrSSukgkQ/sj2gGumz98FrLXTm00Dj8TcYR0x30VMj+HShcu4BqjmV0eRDZZAt cMfiGMS3pbetygNCMHVm+7SKEEoT3RX/jt52XuQkKQ9Ziaw6q9fLT/STR7BxOKXiaoZv bSwdKtWIuB4fAwCRYmjGfhR3z+uErqQdvcopoiH4UZO+UJyvbz1pckvz3R9jOrjgOz0g XLhDAgIl3otbeaJ9hEv6vJl92ragEV9yEXIGVBTFWNxsEt5ptp5L9emt8andE4B38JHk eFDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LEZJelVOWMIkPIWGM2NIO4k5VC4xbOZP4BQXXl6bVr0=; b=jedRGizkLobWhsWFpqkP/TIEFkbagqUJIz4hfbE0osfqsBgI/KlHccglBZDvxJnFp8 usZrkMEyMfqDuNgEMGUS+umx14pcobuuai7dw8cU5LMfcQ6jDxb2mQ+q4QY/S6bsmOC6 NJ3YVbJI8LuBu6qj0iuQMcI0kQwhhc0QYsfPr4/J4RGcHcDiJKT/XVVNvXPhS2+Vzbjd V4FLdWNY5K/QAb733d60yiyHX+LM97jTGE6uy4xQCHi8KNB/aM2vQABcuFzG3Rbsd9rx 8W6LUx/ZZJlGW2OgxLb033wM1qnbCKWb1sA60t44YLJHH1D1bnvr3x3HnbX1OiuQBP92 URHA== X-Gm-Message-State: ANhLgQ2swpvoNrW6TUDfRhiX0EtPbxMgN0pZSF70jrV/HsP6G/mC9rRR b8dOO8/tPdNuA/qoN+v9A56GEw== X-Google-Smtp-Source: ADFU+vvY2FPz8AayHfJ4jgMKQL4NIfuYXdgzUeEf8L5H78UtWlOTjRzYs8XjVae9eSzXmG/o4ogeWw== X-Received: by 2002:a63:7b5e:: with SMTP id k30mr14235602pgn.209.1585320892109; Fri, 27 Mar 2020 07:54:52 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id g81sm4263749pfb.188.2020.03.27.07.54.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2020 07:54:51 -0700 (PDT) Date: Fri, 27 Mar 2020 07:54:48 -0700 From: Stephen Hemminger To: Michal Krawczyk Cc: dev@dpdk.org, mw@semihalf.com, mba@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com, igorch@amazon.com, stable@dpdk.org Message-ID: <20200327075448.417ef984@hermes.lan> In-Reply-To: <20200327101823.12646-3-mk@semihalf.com> References: <20200327101823.12646-1-mk@semihalf.com> <20200327101823.12646-3-mk@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 02/29] net/ena/base: make allocation macros thread-safe X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Fri, 27 Mar 2020 11:17:56 +0100 Michal Krawczyk wrote: > From: Igor Chauskin > > Memory allocation region id could possibly be non-unique > due to non-atomic increment, causing allocation failure. > > Fixes: 9ba7981ec992 ("ena: add communication layer for DPDK") > Cc: stable@dpdk.org > > Signed-off-by: Igor Chauskin > Reviewed-by: Michal Krawczyk > Reviewed-by: Guy Tzalik With DPDK all control operations are the device are supposed to be single threaded by the caller. Do you have an allocation in some datapath?