From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1144FA0598 for ; Thu, 9 Apr 2020 16:51:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E94E01C2E7; Thu, 9 Apr 2020 16:51:37 +0200 (CEST) Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id 9B7401C2BB for ; Thu, 9 Apr 2020 16:51:35 +0200 (CEST) Received: by mail-pf1-f195.google.com with SMTP id b72so4206426pfb.11 for ; Thu, 09 Apr 2020 07:51:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kcHOTTp4xhSbzP0BBR9Wo8qNP7KrQv6VIesM9T6opdY=; b=yijN8T2uFfEsGsLOdtCeND/2PrV4NMwAcwRSMxfYpxalFpIQDDoPk/npRRsE5TYH/K T2PDlrt/zWJ/+0N9Xu41BMdKUVSP/vZEDqCR1YmCB3WSO6OySHT4YC1Qcazf8SJbFTWH 1cGOXa8jrceWKeQJ1vqdWy6BkqZ/1vxB0P3+X4+ssg8KaAg5+LbTSwU39eDipdqImKi4 q+M5MpFrnob1LZpVYCCOIVT0OtQqyUE6AGJ9qg1v++GGjHl+acPdbaCfCcqCI/27kxef NDBNg7I43dgZ/QUNkH6f3s4RUb1aL4app5A2pj4s/P24bfYSxJPolRa3hwYne86yKddj pgSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kcHOTTp4xhSbzP0BBR9Wo8qNP7KrQv6VIesM9T6opdY=; b=Ggf4iof+PuO227zqSnbWtwV+1e/CW6a8JWSHxLe+LCikD/IO66s+XGt6qhYs5EeQSj xgJ8xNBd4DHBAsLqtevGlFLKFPtB/DM26n2PkXbiT5qREYjvqcF9TCtFsn6OYcqOODa/ gXIHBHr4i9HxBbxuMwb5z27t/tdMRyb1x4NnZQnCnKBtC9zySAb8E8ksdMBLc7ZapFJq 3UfOjA0gdcGEFFSfi99HMadl3SOv0rGJJbU77gJBzmch6Q6NMxL11qVTy+w7Bx8XwKaV OYJA7CwCaVaBVY92L3jNXYwP8wazJ3njaSlKqY7JFjAZNLlx9AEEj/NNxv40QiGnqJ11 3J3w== X-Gm-Message-State: AGi0PuZDjehjsiyx554xynM6HAU87DsM3GOQhpCScBLth/tQxSwnOtwE YiaqxvWyU8YTPfw6h25G6K6c8w== X-Google-Smtp-Source: APiQypIrsB6F6B+OFYL7/c8vld/hv42xlqjdswyTWkRL5QH5xifAaeb9A1nhbdfn1hRuit3tvKiHrg== X-Received: by 2002:a65:6405:: with SMTP id a5mr12163281pgv.255.1586443894560; Thu, 09 Apr 2020 07:51:34 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id y19sm20027291pfe.9.2020.04.09.07.51.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2020 07:51:34 -0700 (PDT) Date: Thu, 9 Apr 2020 07:51:24 -0700 From: Stephen Hemminger To: wangyunjian Cc: Ferruh Yigit , "dev@dpdk.org" , "keith.wiles@intel.com" , "Lilijun (Jerry)" , xudingke , "stable@dpdk.org" Message-ID: <20200409075124.018fd49e@hermes.lan> In-Reply-To: <34EFBCA9F01B0748BEB6B629CE643AE60CF5FDB2@DGGEMM533-MBX.china.huawei.com> References: <1586233357-2580-1-git-send-email-wangyunjian@huawei.com> <34EFBCA9F01B0748BEB6B629CE643AE60CF5FDB2@DGGEMM533-MBX.china.huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v3 1/5] net/tap: fix mbuf double free when writev fails X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Thu, 9 Apr 2020 08:03:23 +0000 wangyunjian wrote: > error = tap_write_mbufs(txq, num_mbufs, mbuf, > &num_packets, &num_tx_bytes); > if (error == -1) { > txq->stats.errs++; > /* free tso mbufs */ > for (j = 0; j < ret; j++) > rte_pktmbuf_free(mbuf[j]); > break; > } There is a free bulk, and normally each buf counts against errors. if (error == -1) { txq->stats.errs += num_packets; rte_pktmbuf_free_bulk(mbuf, num_packets); break; }