From: Stephen Hemminger <stephen@networkplumber.org>
To: xiangxia.m.yue@gmail.com
Cc: mattias.ronnblom@ericsson.com, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH dpdk-dev] rte_random: fix crash when random init
Date: Mon, 13 Apr 2020 21:06:58 -0700 [thread overview]
Message-ID: <20200413210658.2308b86e@hermes.lan> (raw)
In-Reply-To: <1586680073-11075-1-git-send-email-xiangxia.m.yue@gmail.com>
On Sun, 12 Apr 2020 16:27:53 +0800
xiangxia.m.yue@gmail.com wrote:
> From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
>
> When rte_rand_init is invoked, and the kernel
> (kernel version < 3.17) running dpdk does't support
> *getentropy, at the same time, the cpu does't support
> rdseed, the rte_rand_init will invoke rte_get_timer_cycles
> which function will invoke rte_get_hpet_cycles
> (RTE_LIBEAL_USE_HPET was enabled) while *eal_hpet is not
> allocated.
>
> Fixes: faf8fd252785 ("eal: improve entropy for initial PRNG seed")
> Fixes: 3f002f069612 ("eal: replace libc-based random generation with LFSR")
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
Are you sure this patch won't change current default to use HPET (which is slower)?
Before this patch users would get TSC as default.
next prev parent reply other threads:[~2020-04-14 4:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-12 8:27 [dpdk-stable] " xiangxia.m.yue
2020-04-14 4:06 ` Stephen Hemminger [this message]
2020-04-14 4:43 ` [dpdk-stable] [dpdk-dev] " Tonghao Zhang
2020-04-14 13:19 ` Mattias Rönnblom
2020-04-14 13:35 ` David Marchand
2020-04-14 15:37 ` Mattias Rönnblom
2020-04-14 23:42 ` Tonghao Zhang
2020-04-15 6:01 ` Mattias Rönnblom
2020-04-15 8:10 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413210658.2308b86e@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=mattias.ronnblom@ericsson.com \
--cc=stable@dpdk.org \
--cc=xiangxia.m.yue@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).