From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 580FFA057B for ; Tue, 14 Apr 2020 09:57:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 667641C1A4; Tue, 14 Apr 2020 09:57:50 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 11CEC1C0DA; Tue, 14 Apr 2020 09:57:46 +0200 (CEST) IronPort-SDR: iMK4PnL7NZfv7tRw3r6GADPii/+qsQ6H9ue8tQE6ZBd8edo9d5mmxS+SOpjYmZ5KpX8E6gkFNC 3vp6ga2M947g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2020 00:57:45 -0700 IronPort-SDR: I4Z9GgvxkEJP4ey9FncYkFKdQOBlQUk/vTh/Cyy2/gy00Rn5FgD87PksuOqGUd4DFzat7gh6cz jqeusEEK9WUA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,381,1580803200"; d="scan'208";a="453454906" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga005.fm.intel.com with ESMTP; 14 Apr 2020 00:57:44 -0700 Date: Tue, 14 Apr 2020 15:53:43 +0800 From: Ye Xiaolong To: Shougang Wang Cc: dev@dpdk.org, Wenzhuo Lu , Qiming Yang , stable@dpdk.org Message-ID: <20200414075342.GB26847@intel.com> References: <20200413013839.71374-1-shougangx.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200413013839.71374-1-shougangx.wang@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/ixgbe: fix link status after port reset X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, Shougang On 04/13, Shougang Wang wrote: >It's a normal behavior to change the link status to up after >resetting the port. So it is unnecessary to set link down before >starting port, and changing the link state(link up/down) frequently >will cause link speed unstable. > >Fixes: c3f2fbff78cf ("net/ixgbe: fix link status") >Cc: stable@dpdk.org > >Signed-off-by: Shougang Wang >--- > drivers/net/ixgbe/ixgbe_ethdev.c | 3 --- > 1 file changed, 3 deletions(-) > >diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c >index 23b3f5b0c..206358b85 100644 >--- a/drivers/net/ixgbe/ixgbe_ethdev.c >+++ b/drivers/net/ixgbe/ixgbe_ethdev.c >@@ -1196,7 +1196,6 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused) > diag = ixgbe_bypass_init_hw(hw); > #else > diag = ixgbe_init_hw(hw); >- hw->mac.autotry_restart = false; Why do we need this change? Seems it is not mentioned in the commit log. > #endif /* RTE_LIBRTE_IXGBE_BYPASS */ > > /* >@@ -1307,8 +1306,6 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused) > /* enable support intr */ > ixgbe_enable_intr(eth_dev); > >- ixgbe_dev_set_link_down(eth_dev); >- > /* initialize filter info */ > memset(filter_info, 0, > sizeof(struct ixgbe_filter_info)); >-- >2.17.1 >