* [dpdk-stable] [PATCH v2 04/10] net/bnxt: fix HWRM command failure during FW reset [not found] ` <20200421200720.81151-1-ajit.khaparde@broadcom.com> @ 2020-04-21 20:07 ` Ajit Khaparde 2020-04-21 20:07 ` [dpdk-stable] [PATCH v2 05/10] net/bnxt: fix to use true/false for bool types Ajit Khaparde ` (2 subsequent siblings) 3 siblings, 0 replies; 8+ messages in thread From: Ajit Khaparde @ 2020-04-21 20:07 UTC (permalink / raw) To: dev; +Cc: Kalesh AP, stable, Lance Richardson, Somnath Kotur From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> FW returns HWRM_ERR_CODE_HOT_RESET_PROGRESS(0xa) when it is unable to process a specific cmd while hot reset is in progress. Host driver is expected to keep retrying the cmd for 2s with a gap of 50ms between each retrial. Also, fixed to fail port start if the HWRM_FUNC_DRV_IF_CHANGE still returns error after 2 seconds. Fixes: 0b533591238f ("net/bnxt: inform firmware about IF state changes") Cc: stable@dpdk.org Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Reviewed-by: Lance Richardson <lance.richardson@broadcom.com> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com> --- drivers/net/bnxt/bnxt.h | 5 +++++ drivers/net/bnxt/bnxt_ethdev.c | 25 +++++++++++++++++-------- drivers/net/bnxt/bnxt_hwrm.c | 4 ++++ 3 files changed, 26 insertions(+), 8 deletions(-) diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h index a7a9e4113..d55a57039 100644 --- a/drivers/net/bnxt/bnxt.h +++ b/drivers/net/bnxt/bnxt.h @@ -480,6 +480,11 @@ struct bnxt_error_recovery_info { uint32_t last_reset_counter; }; +/* Frequency for the FUNC_DRV_IF_CHANGE retry in milliseconds */ +#define BNXT_IF_CHANGE_RETRY_INTERVAL 50 +/* Maximum retry count for FUNC_DRV_IF_CHANGE */ +#define BNXT_IF_CHANGE_RETRY_COUNT 40 + struct bnxt_mark_info { uint32_t mark_id; bool valid; diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 3397c0535..b6c713256 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -1051,7 +1051,7 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev) struct bnxt *bp = eth_dev->data->dev_private; uint64_t rx_offloads = eth_dev->data->dev_conf.rxmode.offloads; int vlan_mask = 0; - int rc; + int rc, retry_cnt = BNXT_IF_CHANGE_RETRY_COUNT; if (!eth_dev->data->nb_tx_queues || !eth_dev->data->nb_rx_queues) { PMD_DRV_LOG(ERR, "Queues are not configured yet!\n"); @@ -1064,14 +1064,23 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev) bp->rx_cp_nr_rings, RTE_ETHDEV_QUEUE_STAT_CNTRS); } - rc = bnxt_hwrm_if_change(bp, 1); - if (!rc) { - if (bp->flags & BNXT_FLAG_IF_CHANGE_HOT_FW_RESET_DONE) { - rc = bnxt_handle_if_change_status(bp); - if (rc) - return rc; - } + do { + rc = bnxt_hwrm_if_change(bp, 1); + if (rc == 0 || rc != -EAGAIN) + break; + + rte_delay_ms(BNXT_IF_CHANGE_RETRY_INTERVAL); + } while (retry_cnt--); + + if (rc) + return rc; + + if (bp->flags & BNXT_FLAG_IF_CHANGE_HOT_FW_RESET_DONE) { + rc = bnxt_handle_if_change_status(bp); + if (rc) + return rc; } + bnxt_enable_int(bp); rc = bnxt_init_chip(bp); diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 4c0fac6be..dc0b40560 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -221,6 +221,8 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg, rc = -EINVAL; \ else if (rc == HWRM_ERR_CODE_CMD_NOT_SUPPORTED) \ rc = -ENOTSUP; \ + else if (rc == HWRM_ERR_CODE_HOT_RESET_PROGRESS) \ + rc = -EAGAIN; \ else if (rc > 0) \ rc = -EIO; \ return rc; \ @@ -249,6 +251,8 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg, rc = -EINVAL; \ else if (rc == HWRM_ERR_CODE_CMD_NOT_SUPPORTED) \ rc = -ENOTSUP; \ + else if (rc == HWRM_ERR_CODE_HOT_RESET_PROGRESS) \ + rc = -EAGAIN; \ else if (rc > 0) \ rc = -EIO; \ return rc; \ -- 2.21.1 (Apple Git-122.3) ^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-stable] [PATCH v2 05/10] net/bnxt: fix to use true/false for bool types [not found] ` <20200421200720.81151-1-ajit.khaparde@broadcom.com> 2020-04-21 20:07 ` [dpdk-stable] [PATCH v2 04/10] net/bnxt: fix HWRM command failure during FW reset Ajit Khaparde @ 2020-04-21 20:07 ` Ajit Khaparde 2020-04-21 20:07 ` [dpdk-stable] [PATCH v2 06/10] net/bnxt: fix to handle port start failure Ajit Khaparde 2020-04-21 20:07 ` [dpdk-stable] [PATCH v2 07/10] net/bnxt: fix vlan add when port is stopped Ajit Khaparde 3 siblings, 0 replies; 8+ messages in thread From: Ajit Khaparde @ 2020-04-21 20:07 UTC (permalink / raw) To: dev; +Cc: Kalesh AP, stable, Somnath Kotur, Lance Richardson From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Fixes: 0b533591238f ("net/bnxt: inform firmware about IF state changes") Cc: stable@dpdk.org Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com> Reviewed-by: Lance Richardson <lance.richardson@broadcom.com> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com> --- drivers/net/bnxt/bnxt_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index b6c713256..780d9c46e 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -1065,7 +1065,7 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev) } do { - rc = bnxt_hwrm_if_change(bp, 1); + rc = bnxt_hwrm_if_change(bp, true); if (rc == 0 || rc != -EAGAIN) break; @@ -1113,7 +1113,7 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev) return 0; error: - bnxt_hwrm_if_change(bp, 0); + bnxt_hwrm_if_change(bp, false); bnxt_shutdown_nic(bp); bnxt_free_tx_mbufs(bp); bnxt_free_rx_mbufs(bp); @@ -1190,7 +1190,7 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev) /* Process any remaining notifications in default completion queue */ bnxt_int_handler(eth_dev); bnxt_shutdown_nic(bp); - bnxt_hwrm_if_change(bp, 0); + bnxt_hwrm_if_change(bp, false); rte_free(bp->mark_table); bp->mark_table = NULL; -- 2.21.1 (Apple Git-122.3) ^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-stable] [PATCH v2 06/10] net/bnxt: fix to handle port start failure [not found] ` <20200421200720.81151-1-ajit.khaparde@broadcom.com> 2020-04-21 20:07 ` [dpdk-stable] [PATCH v2 04/10] net/bnxt: fix HWRM command failure during FW reset Ajit Khaparde 2020-04-21 20:07 ` [dpdk-stable] [PATCH v2 05/10] net/bnxt: fix to use true/false for bool types Ajit Khaparde @ 2020-04-21 20:07 ` Ajit Khaparde 2020-04-21 20:07 ` [dpdk-stable] [PATCH v2 07/10] net/bnxt: fix vlan add when port is stopped Ajit Khaparde 3 siblings, 0 replies; 8+ messages in thread From: Ajit Khaparde @ 2020-04-21 20:07 UTC (permalink / raw) To: dev; +Cc: Kalesh AP, stable, Somnath Kotur From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Fixed to invoke clean up in the reverse sequence of initialization in case any of the FW commands fail during port start. Fixes: 0b533591238f ("net/bnxt: inform firmware about IF state changes") Cc: stable@dpdk.org Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com> --- drivers/net/bnxt/bnxt_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 780d9c46e..206111db5 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -1113,10 +1113,10 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev) return 0; error: - bnxt_hwrm_if_change(bp, false); bnxt_shutdown_nic(bp); bnxt_free_tx_mbufs(bp); bnxt_free_rx_mbufs(bp); + bnxt_hwrm_if_change(bp, false); eth_dev->data->dev_started = 0; return rc; } -- 2.21.1 (Apple Git-122.3) ^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-stable] [PATCH v2 07/10] net/bnxt: fix vlan add when port is stopped [not found] ` <20200421200720.81151-1-ajit.khaparde@broadcom.com> ` (2 preceding siblings ...) 2020-04-21 20:07 ` [dpdk-stable] [PATCH v2 06/10] net/bnxt: fix to handle port start failure Ajit Khaparde @ 2020-04-21 20:07 ` Ajit Khaparde 3 siblings, 0 replies; 8+ messages in thread From: Ajit Khaparde @ 2020-04-21 20:07 UTC (permalink / raw) To: dev; +Cc: Kalesh AP, stable, Venkat Duvvuru From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Driver destroys the vnic when the port is brought down. When user tries to add a vlan when port is stopped, driver issues HWRM command to FW with invalid vnic_id and it fails. Fixed to return an error while setting vlan when port is not started. Fixes: b4e190d55c25 ("net/bnxt: fix MAC/VLAN filter allocation") Cc: stable@dpdk.org Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Reviewed-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com> --- drivers/net/bnxt/bnxt_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 206111db5..589190b37 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -2082,6 +2082,11 @@ static int bnxt_vlan_filter_set_op(struct rte_eth_dev *eth_dev, if (rc) return rc; + if (!eth_dev->data->dev_started) { + PMD_DRV_LOG(ERR, "port must be started before setting vlan\n"); + return -EINVAL; + } + /* These operations apply to ALL existing MAC/VLAN filters */ if (on) return bnxt_add_vlan_filter(bp, vlan_id); -- 2.21.1 (Apple Git-122.3) ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <20200421213351.87219-1-ajit.khaparde@broadcom.com>]
* [dpdk-stable] [PATCH v3 4/9] net/bnxt: fix HWRM command failure during FW reset [not found] ` <20200421213351.87219-1-ajit.khaparde@broadcom.com> @ 2020-04-21 21:33 ` Ajit Khaparde 2020-04-21 21:33 ` [dpdk-stable] [PATCH v3 5/9] net/bnxt: fix to use true/false for bool types Ajit Khaparde ` (2 subsequent siblings) 3 siblings, 0 replies; 8+ messages in thread From: Ajit Khaparde @ 2020-04-21 21:33 UTC (permalink / raw) To: dev; +Cc: Kalesh AP, stable, Lance Richardson, Somnath Kotur From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> FW returns HWRM_ERR_CODE_HOT_RESET_PROGRESS(0xa) when it is unable to process a specific cmd while hot reset is in progress. Host driver is expected to keep retrying the cmd for 2s with a gap of 50ms between each retrial. Also, fixed to fail port start if the HWRM_FUNC_DRV_IF_CHANGE still returns error after 2 seconds. Fixes: 0b533591238f ("net/bnxt: inform firmware about IF state changes") Cc: stable@dpdk.org Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Reviewed-by: Lance Richardson <lance.richardson@broadcom.com> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com> --- drivers/net/bnxt/bnxt.h | 5 +++++ drivers/net/bnxt/bnxt_ethdev.c | 25 +++++++++++++++++-------- drivers/net/bnxt/bnxt_hwrm.c | 4 ++++ 3 files changed, 26 insertions(+), 8 deletions(-) diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h index a7a9e4113..d55a57039 100644 --- a/drivers/net/bnxt/bnxt.h +++ b/drivers/net/bnxt/bnxt.h @@ -480,6 +480,11 @@ struct bnxt_error_recovery_info { uint32_t last_reset_counter; }; +/* Frequency for the FUNC_DRV_IF_CHANGE retry in milliseconds */ +#define BNXT_IF_CHANGE_RETRY_INTERVAL 50 +/* Maximum retry count for FUNC_DRV_IF_CHANGE */ +#define BNXT_IF_CHANGE_RETRY_COUNT 40 + struct bnxt_mark_info { uint32_t mark_id; bool valid; diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 3397c0535..b6c713256 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -1051,7 +1051,7 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev) struct bnxt *bp = eth_dev->data->dev_private; uint64_t rx_offloads = eth_dev->data->dev_conf.rxmode.offloads; int vlan_mask = 0; - int rc; + int rc, retry_cnt = BNXT_IF_CHANGE_RETRY_COUNT; if (!eth_dev->data->nb_tx_queues || !eth_dev->data->nb_rx_queues) { PMD_DRV_LOG(ERR, "Queues are not configured yet!\n"); @@ -1064,14 +1064,23 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev) bp->rx_cp_nr_rings, RTE_ETHDEV_QUEUE_STAT_CNTRS); } - rc = bnxt_hwrm_if_change(bp, 1); - if (!rc) { - if (bp->flags & BNXT_FLAG_IF_CHANGE_HOT_FW_RESET_DONE) { - rc = bnxt_handle_if_change_status(bp); - if (rc) - return rc; - } + do { + rc = bnxt_hwrm_if_change(bp, 1); + if (rc == 0 || rc != -EAGAIN) + break; + + rte_delay_ms(BNXT_IF_CHANGE_RETRY_INTERVAL); + } while (retry_cnt--); + + if (rc) + return rc; + + if (bp->flags & BNXT_FLAG_IF_CHANGE_HOT_FW_RESET_DONE) { + rc = bnxt_handle_if_change_status(bp); + if (rc) + return rc; } + bnxt_enable_int(bp); rc = bnxt_init_chip(bp); diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 4c0fac6be..dc0b40560 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -221,6 +221,8 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg, rc = -EINVAL; \ else if (rc == HWRM_ERR_CODE_CMD_NOT_SUPPORTED) \ rc = -ENOTSUP; \ + else if (rc == HWRM_ERR_CODE_HOT_RESET_PROGRESS) \ + rc = -EAGAIN; \ else if (rc > 0) \ rc = -EIO; \ return rc; \ @@ -249,6 +251,8 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg, rc = -EINVAL; \ else if (rc == HWRM_ERR_CODE_CMD_NOT_SUPPORTED) \ rc = -ENOTSUP; \ + else if (rc == HWRM_ERR_CODE_HOT_RESET_PROGRESS) \ + rc = -EAGAIN; \ else if (rc > 0) \ rc = -EIO; \ return rc; \ -- 2.21.1 (Apple Git-122.3) ^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-stable] [PATCH v3 5/9] net/bnxt: fix to use true/false for bool types [not found] ` <20200421213351.87219-1-ajit.khaparde@broadcom.com> 2020-04-21 21:33 ` [dpdk-stable] [PATCH v3 4/9] net/bnxt: fix HWRM command failure during FW reset Ajit Khaparde @ 2020-04-21 21:33 ` Ajit Khaparde 2020-04-21 21:33 ` [dpdk-stable] [PATCH v3 6/9] net/bnxt: fix to handle port start failure Ajit Khaparde 2020-04-21 21:33 ` [dpdk-stable] [PATCH v3 7/9] net/bnxt: fix vlan add when port is stopped Ajit Khaparde 3 siblings, 0 replies; 8+ messages in thread From: Ajit Khaparde @ 2020-04-21 21:33 UTC (permalink / raw) To: dev; +Cc: Kalesh AP, stable, Somnath Kotur, Lance Richardson From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Fixes: 0b533591238f ("net/bnxt: inform firmware about IF state changes") Cc: stable@dpdk.org Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com> Reviewed-by: Lance Richardson <lance.richardson@broadcom.com> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com> --- drivers/net/bnxt/bnxt_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index b6c713256..780d9c46e 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -1065,7 +1065,7 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev) } do { - rc = bnxt_hwrm_if_change(bp, 1); + rc = bnxt_hwrm_if_change(bp, true); if (rc == 0 || rc != -EAGAIN) break; @@ -1113,7 +1113,7 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev) return 0; error: - bnxt_hwrm_if_change(bp, 0); + bnxt_hwrm_if_change(bp, false); bnxt_shutdown_nic(bp); bnxt_free_tx_mbufs(bp); bnxt_free_rx_mbufs(bp); @@ -1190,7 +1190,7 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev) /* Process any remaining notifications in default completion queue */ bnxt_int_handler(eth_dev); bnxt_shutdown_nic(bp); - bnxt_hwrm_if_change(bp, 0); + bnxt_hwrm_if_change(bp, false); rte_free(bp->mark_table); bp->mark_table = NULL; -- 2.21.1 (Apple Git-122.3) ^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-stable] [PATCH v3 6/9] net/bnxt: fix to handle port start failure [not found] ` <20200421213351.87219-1-ajit.khaparde@broadcom.com> 2020-04-21 21:33 ` [dpdk-stable] [PATCH v3 4/9] net/bnxt: fix HWRM command failure during FW reset Ajit Khaparde 2020-04-21 21:33 ` [dpdk-stable] [PATCH v3 5/9] net/bnxt: fix to use true/false for bool types Ajit Khaparde @ 2020-04-21 21:33 ` Ajit Khaparde 2020-04-21 21:33 ` [dpdk-stable] [PATCH v3 7/9] net/bnxt: fix vlan add when port is stopped Ajit Khaparde 3 siblings, 0 replies; 8+ messages in thread From: Ajit Khaparde @ 2020-04-21 21:33 UTC (permalink / raw) To: dev; +Cc: Kalesh AP, stable, Somnath Kotur From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Fixed to invoke clean up in the reverse sequence of initialization in case any of the FW commands fail during port start. Fixes: 0b533591238f ("net/bnxt: inform firmware about IF state changes") Cc: stable@dpdk.org Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com> --- drivers/net/bnxt/bnxt_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 780d9c46e..206111db5 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -1113,10 +1113,10 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev) return 0; error: - bnxt_hwrm_if_change(bp, false); bnxt_shutdown_nic(bp); bnxt_free_tx_mbufs(bp); bnxt_free_rx_mbufs(bp); + bnxt_hwrm_if_change(bp, false); eth_dev->data->dev_started = 0; return rc; } -- 2.21.1 (Apple Git-122.3) ^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-stable] [PATCH v3 7/9] net/bnxt: fix vlan add when port is stopped [not found] ` <20200421213351.87219-1-ajit.khaparde@broadcom.com> ` (2 preceding siblings ...) 2020-04-21 21:33 ` [dpdk-stable] [PATCH v3 6/9] net/bnxt: fix to handle port start failure Ajit Khaparde @ 2020-04-21 21:33 ` Ajit Khaparde 3 siblings, 0 replies; 8+ messages in thread From: Ajit Khaparde @ 2020-04-21 21:33 UTC (permalink / raw) To: dev; +Cc: Kalesh AP, stable, Venkat Duvvuru From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Driver destroys the vnic when the port is brought down. When user tries to add a vlan when port is stopped, driver issues HWRM command to FW with invalid vnic_id and it fails. Fixed to return an error while setting vlan when port is not started. Fixes: b4e190d55c25 ("net/bnxt: fix MAC/VLAN filter allocation") Cc: stable@dpdk.org Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Reviewed-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com> --- drivers/net/bnxt/bnxt_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 206111db5..589190b37 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -2082,6 +2082,11 @@ static int bnxt_vlan_filter_set_op(struct rte_eth_dev *eth_dev, if (rc) return rc; + if (!eth_dev->data->dev_started) { + PMD_DRV_LOG(ERR, "port must be started before setting vlan\n"); + return -EINVAL; + } + /* These operations apply to ALL existing MAC/VLAN filters */ if (on) return bnxt_add_vlan_filter(bp, vlan_id); -- 2.21.1 (Apple Git-122.3) ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-04-21 21:34 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200421091257.8089-1-kalesh-anakkur.purayil@broadcom.com>
[not found] ` <20200421200720.81151-1-ajit.khaparde@broadcom.com>
2020-04-21 20:07 ` [dpdk-stable] [PATCH v2 04/10] net/bnxt: fix HWRM command failure during FW reset Ajit Khaparde
2020-04-21 20:07 ` [dpdk-stable] [PATCH v2 05/10] net/bnxt: fix to use true/false for bool types Ajit Khaparde
2020-04-21 20:07 ` [dpdk-stable] [PATCH v2 06/10] net/bnxt: fix to handle port start failure Ajit Khaparde
2020-04-21 20:07 ` [dpdk-stable] [PATCH v2 07/10] net/bnxt: fix vlan add when port is stopped Ajit Khaparde
[not found] ` <20200421213351.87219-1-ajit.khaparde@broadcom.com>
2020-04-21 21:33 ` [dpdk-stable] [PATCH v3 4/9] net/bnxt: fix HWRM command failure during FW reset Ajit Khaparde
2020-04-21 21:33 ` [dpdk-stable] [PATCH v3 5/9] net/bnxt: fix to use true/false for bool types Ajit Khaparde
2020-04-21 21:33 ` [dpdk-stable] [PATCH v3 6/9] net/bnxt: fix to handle port start failure Ajit Khaparde
2020-04-21 21:33 ` [dpdk-stable] [PATCH v3 7/9] net/bnxt: fix vlan add when port is stopped Ajit Khaparde
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).