patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Wei Zhao <wei.zhao1@intel.com>
To: dev@dpdk.org
Cc: stable@dpdk.org, beilei.xing@intel.com, maxime.leroy@6wind.com,
	Wei Zhao <wei.zhao1@intel.com>
Subject: [dpdk-stable] [PATCH v4 3/3] net/i40e: remove teardown when flush FDIR filter
Date: Wed, 29 Apr 2020 10:03:53 +0800	[thread overview]
Message-ID: <20200429020353.20266-4-wei.zhao1@intel.com> (raw)
In-Reply-To: <20200429020353.20266-1-wei.zhao1@intel.com>

When we flush FDIR filter, we can not call i40e_fdir_teardown()
function as it will free vsi used for FDIR, then the vsi->base_queue
will be freed from pf->qp_pool, but vsi->base_queue can only get
once when do dev init in i40e_pf_setup(). If we free it, it will
never be alloc again.

Bugzilla ID: 404
Fixes: 2e67a7fbf3ff ("net/i40e: config flow director automatically")
Cc: stable@dpdk.org

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
 drivers/net/i40e/i40e_flow.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
index 1533d5abb..65f877866 100644
--- a/drivers/net/i40e/i40e_flow.c
+++ b/drivers/net/i40e/i40e_flow.c
@@ -5145,7 +5145,6 @@ i40e_flow_destroy(struct rte_eth_dev *dev,
 
 		/* If the last flow is destroyed, disable fdir. */
 		if (!ret && TAILQ_EMPTY(&pf->fdir.fdir_list)) {
-			i40e_fdir_teardown(pf);
 			i40e_fdir_rx_proc_enable(dev, 0);
 		}
 		break;
@@ -5343,8 +5342,6 @@ i40e_flow_flush_fdir_filter(struct i40e_pf *pf)
 			pf->fdir.inset_flag[pctype] = 0;
 	}
 
-	i40e_fdir_teardown(pf);
-
 	return ret;
 }
 
-- 
2.19.1


  parent reply	other threads:[~2020-04-29  2:26 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200427071500.14767-1-wei.zhao1@intel.com>
2020-04-27  7:14 ` [dpdk-stable] [PATCH 1/3] net/i40e: remove ARP type check for " Wei Zhao
2020-04-28  1:20   ` Xing, Beilei
2020-04-28  5:39     ` Zhao1, Wei
2020-04-27  7:15 ` [dpdk-stable] [PATCH 3/3] net/i40e: remove teardown when flush " Wei Zhao
2020-04-28  1:13   ` Xing, Beilei
2020-04-28  1:18     ` Zhao1, Wei
2020-04-28  5:48 ` [dpdk-stable] [PATCH v2 0/3] fix i40e bug for flow filter Wei Zhao
2020-04-28  5:48   ` [dpdk-stable] [PATCH v2 1/3] net/i40e: fix FDIR issue for ARP packets Wei Zhao
2020-04-28  7:38     ` Xing, Beilei
2020-04-28  7:46       ` Zhao1, Wei
2020-04-28  5:48   ` [dpdk-stable] [PATCH v2 2/3] doc: input set requirement of each pctype for FDIR Wei Zhao
2020-04-28  5:48   ` [dpdk-stable] [PATCH v2 3/3] net/i40e: remove teardown when flush FDIR filter Wei Zhao
2020-04-28  7:16     ` Xing, Beilei
2020-04-28  7:44       ` Zhao1, Wei
2020-04-28  7:39   ` [dpdk-stable] [PATCH v3 0/3] fix i40e bug for flow filter Wei Zhao
2020-04-28  7:39     ` [dpdk-stable] [PATCH v3 1/3] net/i40e: fix FDIR issue for ARP packets Wei Zhao
2020-04-28  7:39     ` [dpdk-stable] [PATCH v3 2/3] doc: input set requirement of each pctype for FDIR Wei Zhao
2020-04-28  7:39     ` [dpdk-stable] [PATCH v3 3/3] net/i40e: remove teardown when flush FDIR filter Wei Zhao
2020-04-29  2:03     ` [dpdk-stable] [PATCH v4 0/3] fix i40e bug for flow filter Wei Zhao
2020-04-29  2:03       ` [dpdk-stable] [PATCH v4 1/3] net/i40e: fix FDIR issue for ARP packets Wei Zhao
2020-04-29  2:03       ` [dpdk-stable] [PATCH v4 2/3] doc: input set requirement of each pctype for FDIR Wei Zhao
2020-04-29 10:35         ` Ferruh Yigit
2020-04-30  0:52           ` Zhao1, Wei
2020-04-30 10:19             ` Ferruh Yigit
2020-05-06  1:05               ` Zhao1, Wei
2020-05-06  9:29                 ` Ferruh Yigit
2020-05-06  9:32                   ` Zhao1, Wei
2020-04-29  2:03       ` Wei Zhao [this message]
2020-04-29  3:05       ` [dpdk-stable] [PATCH v4 0/3] fix i40e bug for flow filter Xing, Beilei
2020-04-29  7:17         ` Ye Xiaolong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200429020353.20266-4-wei.zhao1@intel.com \
    --to=wei.zhao1@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.leroy@6wind.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).