From: Junyu Jiang <junyux.jiang@intel.com>
To: dev@dpdk.org
Cc: Qiming Yang <qiming.yang@intel.com>,
Junyu Jiang <junyux.jiang@intel.com>,
stable@dpdk.org
Subject: [dpdk-stable] [PATCH] net/ice: fix core dumped issue in switch filter
Date: Wed, 29 Apr 2020 07:25:16 +0000 [thread overview]
Message-ID: <20200429072516.65403-1-junyux.jiang@intel.com> (raw)
The number of queues in queue group should be checked before
using it to avoid NULL pointer. This patch fixed the issue.
Fixes: 47d460d63233 ("net/ice: rework switch filter")
Cc: stable@dpdk.org
Signed-off-by: Junyu Jiang <junyux.jiang@intel.com>
---
drivers/net/ice/ice_switch_filter.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ice/ice_switch_filter.c b/drivers/net/ice/ice_switch_filter.c
index 179430136..c2762e331 100644
--- a/drivers/net/ice/ice_switch_filter.c
+++ b/drivers/net/ice/ice_switch_filter.c
@@ -1296,6 +1296,8 @@ ice_switch_parse_action(struct ice_pf *pf,
switch (action_type) {
case RTE_FLOW_ACTION_TYPE_RSS:
act_qgrop = action->conf;
+ if (act_qgrop->queue_num <= 1)
+ goto error;
rule_info->sw_act.fltr_act =
ICE_FWD_TO_QGRP;
rule_info->sw_act.fwd_id.q_id =
--
2.17.1
next reply other threads:[~2020-04-29 7:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 7:25 Junyu Jiang [this message]
2020-04-30 6:52 ` Yang, Qiming
2020-04-30 7:42 ` Jiang, JunyuX
2020-04-30 9:09 ` [dpdk-stable] [dpdk-dev] " Xiao, QimaiX
2020-05-06 3:05 ` [dpdk-stable] [PATCH v2] " Junyu Jiang
2020-05-06 6:30 ` Yang, Qiming
2020-05-06 8:57 ` Ye Xiaolong
2020-05-20 9:31 ` [dpdk-stable] [dpdk-dev] " Zhao1, Wei
2020-05-20 9:32 ` Zhao1, Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200429072516.65403-1-junyux.jiang@intel.com \
--to=junyux.jiang@intel.com \
--cc=dev@dpdk.org \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).