From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 620F5A04AF
for <public@inbox.dpdk.org>; Mon, 4 May 2020 11:17:46 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 526561D452;
Mon, 4 May 2020 11:17:46 +0200 (CEST)
Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com
[67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 827BE1C43C;
Mon, 4 May 2020 11:17:43 +0200 (CEST)
Received: from pps.filterd (m0045851.ppops.net [127.0.0.1])
by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id
0449AcFG013739; Mon, 4 May 2020 02:17:43 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;
h=date : from : to :
cc : subject : message-id : references : content-type :
content-transfer-encoding : in-reply-to : mime-version; s=pfpt0818;
bh=9xFWTo1bQxLQnGvd1keMRnxAa4hy93sCQcYiYxW2uqk=;
b=hhNRwd3ehMCjYhNQCTGWfe1+gfsfnqrXhi3gw23v7ip7NcSaI2IZgQItN1VD7CIpQqQI
ctMelGatXWmHmh/3Y6vOH23ohbWHFLOwpPAd9faEfg4RrTsd4xIPnDkfGWIKXSvgACxL
+/ry2pNXyF1OME1bsIYuFWmVUlYr+6ID0zTsAUVWEv4oNHasxC4g4yY9Ft2iFzBnabt+
pUjSZAA+3u/uvIjbwkJoKFzKF4x4hZD91WGqawQ3mRkDJbFbCwE26TChReMGG3OCYHnk
8PrVQCDIs/2Q1ZBFaFM581HeoGvtJjTlO91fOWZeAw0a0A7S0C+4lhwtehKccsWaftzY pw==
Received: from sc-exch02.marvell.com ([199.233.58.182])
by mx0b-0016f401.pphosted.com with ESMTP id 30srykk3n1-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);
Mon, 04 May 2020 02:17:42 -0700
Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH02.marvell.com
(10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2;
Mon, 4 May 2020 02:17:40 -0700
Received: from SC-EXCH03.marvell.com (10.93.176.83) by DC5-EXCH02.marvell.com
(10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2;
Mon, 4 May 2020 02:17:40 -0700
Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.103)
by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id
15.0.1497.2 via Frontend Transport; Mon, 4 May 2020 02:17:39 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=QA0wtj0VdaSSbG7cLR/DtKd2PdLPXFnmcFMyZh/jUGz+6xXT71DOH+55k47j6+62B/usjt06VYyyYb4//Aqe+GPm305osR4BfpncHuiaG8Y/wmhWLF2NaCfWwNR/sMfV3RNALqnx7vV9jxWMXnjkthbK4xygb9dJ2azbcvzrzZ/u2iF/X0gEooUBuamMsjedpOtAsSyicugauiP/Mv73XdoerykKt9gdDLUDZkKODo2InL9uAIoG4IItO96Z0Ymjbignq3bZRNQoBLEMC+BAJPAKa/2VICJXcYiwCoOu9R3H5c2MQhKjXW3DvYhsixQ3ZtpFFmhqYej+Ygbejfa8/Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=9xFWTo1bQxLQnGvd1keMRnxAa4hy93sCQcYiYxW2uqk=;
b=BQPRCR/CFj4aRGqaFdaKhEZ4afxK9BnU6EIhwZtTGBiqgZZVxXpqIv7rXTLeKijHb8FcHNJxZ3arMnqbxzOKuClJQ16v52w2zeq7tYSUg9XaX/Ee7AjeFKUEpGSWJhGdKDi/bxDSDXVGNXO5YkkUa01JbelwS58w0X9tLXyxNs6wN1NViB1hsCfABWnaZ2WIWANajZwptwKS3vcXWlCFCfYzLVU14G/7P+7zNe34b83ODgLl14F1xWulgv6gk3QcOtJp6H8UQRdL7Wp0AShMVngdyCoMLHvesKngVRWTY0X73OdPRHgEMEwApIdyS6Hby1MxgxMgPqZUSqY55SXl+w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com;
dkim=pass header.d=marvell.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=9xFWTo1bQxLQnGvd1keMRnxAa4hy93sCQcYiYxW2uqk=;
b=f/BZJ/XV0vHRJKu5gebEzXJXQkzJPjnP6mA60Lpu6itbq6pBjIXkjMOPAmdHAULaNUpvGuT2wqEa1GW7YU/XwuspBEaNx+97qc8YzSVK0oMyW0dd+iqPS/4Sf4xfZtHMVGHbNnTw1fyLFKEo3WP6pBvLdA8OCdtvwmg1lah10TI=
Received: from MN2PR18MB2848.namprd18.prod.outlook.com (2603:10b6:208:38::19)
by MN2PR18MB2958.namprd18.prod.outlook.com (2603:10b6:208:ff::14)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.20; Mon, 4 May
2020 09:17:36 +0000
Received: from MN2PR18MB2848.namprd18.prod.outlook.com
([fe80::a8b1:45c4:b84:9c02]) by MN2PR18MB2848.namprd18.prod.outlook.com
([fe80::a8b1:45c4:b84:9c02%7]) with mapi id 15.20.2958.030; Mon, 4 May 2020
09:17:36 +0000
Date: Mon, 4 May 2020 14:47:21 +0530
From: Harman Kalra <hkalra@marvell.com>
To: <pbhagavatula@marvell.com>
CC: <jerinj@marvell.com>, <ferruh.yigit@intel.com>, <thomas@monjalon.net>,
<dev@dpdk.org>, <stable@dpdk.org>
Message-ID: <20200504091719.GA128390@outlook.office365.com>
References: <20200502161031.1273-1-pbhagavatula@marvell.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200502161031.1273-1-pbhagavatula@marvell.com>
User-Agent: Mutt/1.10.0 (2018-05-17)
X-ClientProxiedBy: PN1PR0101CA0057.INDPRD01.PROD.OUTLOOK.COM
(2603:1096:c00:d::19) To MN2PR18MB2848.namprd18.prod.outlook.com
(2603:10b6:208:38::19)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from outlook.office365.com (115.113.156.2) by
PN1PR0101CA0057.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:d::19) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.26 via Frontend
Transport; Mon, 4 May 2020 09:17:34 +0000
X-Originating-IP: [115.113.156.2]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 207bef10-51df-4418-3ea9-08d7f00bfc27
X-MS-TrafficTypeDiagnostic: MN2PR18MB2958:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MN2PR18MB29581B007002E7AA116E540DC5A60@MN2PR18MB2958.namprd18.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1360;
X-Forefront-PRVS: 03932714EB
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Ybgt4TAtfwX0QvF6kqbJCY9LHeECZoYFmSkJnAoSH0l63VoPvNAJ6IGzl5eIW5mqVfPLexXN2gQjGuKGGlJGjdolCWvgDrSvqi74V+A/zbF2JZ/hz6aMn03TxtPyyUzaJtB7EAM/X44Rkxanv07s1OH6ceYqtxw41+aaeP0bOqjdoy8qDpHJVjaRq4s3QqHeYD3S7nY5gsUn76wb5Rlf6WH0VragMzi2lQJQ9IYZJub0Xv3G2t8C0bwhZYSPXFVSNd3NCcu1um0J8lA1w60B6dQaDiqeKgAZzN4uGcKP1M1GuomTTIubVVjT3NCGJlka9oWYJuVZIl4WnerpjgI9/djPddNxbK84B8x2jb1++TXrx0WFEQ6KGYAxSL9+NFbbEl58IT17iPkUCjSBHPf6WA2l0czmGFl7Him0jOS2ECKHlAD6scCT0CypYUgTahIbDtoLeI58PzUgV9sznLONu/2qevTPapFwnNBL25ZY5EIN5oX3U2nn1fWWC+Z6v9FZLJsJDXmSFTy5UXIHWmln8Q==
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:MN2PR18MB2848.namprd18.prod.outlook.com; PTR:; CAT:NONE;
SFTY:;
SFS:(4636009)(346002)(136003)(376002)(39850400004)(396003)(366004)(26005)(1076003)(16526019)(55236004)(55016002)(186003)(316002)(9686003)(66946007)(8936002)(86362001)(33656002)(8676002)(478600001)(5660300002)(966005)(6636002)(4326008)(52116002)(956004)(2906002)(7696005)(6666004)(66476007)(6506007)(34206002)(66556008);
DIR:OUT; SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: eTp5+JO/yez9U5MejikgLyhuv40lTuP0h+JA6gn/KXeqC82FhMtzKMt/HLdSM7yRfEG5xB31Ad5vY/q1OmsCSug8YRt0Zl265dgujlIkVGnt92Qu0UzXmN7Ys3L1XVa8lwde306aSnALLYFMRg4+hUZ8cf4eSxxDlMHxgRvgcPE6GVee7oqaT+dTNNIb3pphKy13cFGel14hGETPaZ5EabJAqsFMmQmSchjf6WFXU3osR/JwUY7UB30eQ1Eil1SPK9a4ycTcpCiJmTOAKaT5UuZaOJYHPV8BWyrzQWu5czYGDlqOsNDvVF+15srFoCVjUl0T3ZlGqkijIkcpSLWRKvEAzhhTjKBLYHzEg//7y3II0czTZNweJucQhqgqMycT6EhHHm+Y4Ux+NF+mw0zPQbAiaiqRAkfCs0svf3QCXz2Sa9h4ooHuG483KCV8vZsOt/GGfcgId8sEQmWS98xjiLa/GoQe+1Wp7onzcDBe4wuTfj3t8Tmd2qyWeDIprCQqqru2mKobgAfEXvbSAxD/Vn75JIvKcIqTK8YTL9PpfZ1UbhHThPYf5Pl1gS9rMMTvvV5zFYsdW/4ChOHZXNoEi6LxTzzWJxnuiFH3H6DIPn0QgkglrU+chbcuKUNklZEZBAQwZoY5/5sAOsOVcyiTzxNH/E9ceIvnTSCNhHtTxICcwujaRD4PVVjYFb+djWUgk231uV49l9/aIvuGMW2I2KUMyKr0YVOT9q8bZN+t3TdKGrBIslPNk5NJRyOoamzQVXf6KcCY5U+Kd1e7CqymOS7YnKBunAvsaz8sm+9LVUU=
X-MS-Exchange-CrossTenant-Network-Message-Id: 207bef10-51df-4418-3ea9-08d7f00bfc27
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2020 09:17:36.3270 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3cxAp0h7cbUMTQEANo56sws3/cxfVKTAuQZMnFbolx3wcEP5LfrKu4eiMM2d8RfEcWMvQseCkiP0VLZxTyPebw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2958
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676
definitions=2020-05-04_05:2020-05-01,
2020-05-04 signatures=0
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] common/octeontx: fix GCC 9.1
ABI break
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
On Sat, May 02, 2020 at 09:40:31PM +0530, pbhagavatula@marvell.com wrote:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> GCC 9.1 fixes a bug with passing bitfields as pass by value in function
> parameters and generates a warning for the same as below:
>
> drivers/common/octeontx/octeontx_mbox.c:282:1: note: parameter passing
> for argument of type ‘struct mbox_intf_ver’ changed in GCC 9.1
>
> Fix the warning generated by passing bitfield as pass by reference.
>
> Fixes: b4134b2d31cc ("common/octeontx: update mbox to version 1.1.3")
> Cc: stable@dpdk.org
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Acked-by: Harman Kalra <hkalra@marvell.com>
> ---
> More info on GCC bug
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88469
> https://gcc.gnu.org/git/?p=gcc.git&a=commit;h=c590597c45948c6e6fa282878198fd226da95998
>
> drivers/common/octeontx/octeontx_mbox.c | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/common/octeontx/octeontx_mbox.c b/drivers/common/octeontx/octeontx_mbox.c
> index 2fd253107..effe0b267 100644
> --- a/drivers/common/octeontx/octeontx_mbox.c
> +++ b/drivers/common/octeontx/octeontx_mbox.c
> @@ -279,7 +279,7 @@ octeontx_start_domain(void)
> }
>
> static int
> -octeontx_check_mbox_version(struct mbox_intf_ver app_intf_ver,
> +octeontx_check_mbox_version(struct mbox_intf_ver *app_intf_ver,
> struct mbox_intf_ver *intf_ver)
> {
> struct mbox_intf_ver kernel_intf_ver = {0};
> @@ -290,8 +290,9 @@ octeontx_check_mbox_version(struct mbox_intf_ver app_intf_ver,
> hdr.coproc = NO_COPROC;
> hdr.msg = RM_INTERFACE_VERSION;
>
> - result = octeontx_mbox_send(&hdr, &app_intf_ver, sizeof(app_intf_ver),
> - &kernel_intf_ver, sizeof(kernel_intf_ver));
> + result = octeontx_mbox_send(&hdr, app_intf_ver,
> + sizeof(struct mbox_intf_ver),
> + &kernel_intf_ver, sizeof(kernel_intf_ver));
> if (result != sizeof(kernel_intf_ver)) {
> mbox_log_err("Could not send interface version. Err=%d. FuncErr=%d\n",
> result, hdr.res_code);
> @@ -301,9 +302,9 @@ octeontx_check_mbox_version(struct mbox_intf_ver app_intf_ver,
> if (intf_ver)
> *intf_ver = kernel_intf_ver;
>
> - if (app_intf_ver.platform != kernel_intf_ver.platform ||
> - app_intf_ver.major != kernel_intf_ver.major ||
> - app_intf_ver.minor != kernel_intf_ver.minor)
> + if (app_intf_ver->platform != kernel_intf_ver.platform ||
> + app_intf_ver->major != kernel_intf_ver.major ||
> + app_intf_ver->minor != kernel_intf_ver.minor)
> result = -EINVAL;
>
> return result;
> @@ -312,7 +313,7 @@ octeontx_check_mbox_version(struct mbox_intf_ver app_intf_ver,
> int
> octeontx_mbox_init(void)
> {
> - const struct mbox_intf_ver MBOX_INTERFACE_VERSION = {
> + struct mbox_intf_ver MBOX_INTERFACE_VERSION = {
> .platform = 0x01,
> .major = 0x01,
> .minor = 0x03
> @@ -330,7 +331,7 @@ octeontx_mbox_init(void)
> return ret;
> }
>
> - ret = octeontx_check_mbox_version(MBOX_INTERFACE_VERSION,
> + ret = octeontx_check_mbox_version(&MBOX_INTERFACE_VERSION,
> &rm_intf_ver);
> if (ret < 0) {
> mbox_log_err("MBOX version: Kernel(%d.%d.%d) != DPDK(%d.%d.%d)",
> --
> 2.26.2
>