patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: dev@dpdk.org, ferruh.yigit@intel.com
Cc: stable@dpdk.org, Rohit Raj <rohit.raj@nxp.com>
Subject: [dpdk-stable] [PATCH v6 02/10] net/dpaa2: fix 10G port negotiation issue
Date: Fri,  8 May 2020 18:32:03 +0530	[thread overview]
Message-ID: <20200508130211.14334-3-hemant.agrawal@nxp.com> (raw)
In-Reply-To: <20200508130211.14334-1-hemant.agrawal@nxp.com>

From: Rohit Raj <rohit.raj@nxp.com>

Fixed 10G port negotiation issue with another 10G/non 10G port.

When running testpmd with 10G interfaces on 10BaseT interface
on LS2088ARDB, the ports were showing link as down.

This was identified to be caused by the setting of link as down
during config.
Also, the line rate was not being updated in device link params,
thus having the incorrect link speed in status (as 0).

Fixes: c5acbb5ea20e ("net/dpaa2: support link status event")
Cc: stable@dpdk.org

Signed-off-by: Rohit Raj <rohit.raj@nxp.com>
---
 drivers/net/dpaa2/dpaa2_ethdev.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
index 2cde55e7cc..4fc550a885 100644
--- a/drivers/net/dpaa2/dpaa2_ethdev.c
+++ b/drivers/net/dpaa2/dpaa2_ethdev.c
@@ -553,9 +553,6 @@ dpaa2_eth_dev_configure(struct rte_eth_dev *dev)
 	if (rx_offloads & DEV_RX_OFFLOAD_VLAN_FILTER)
 		dpaa2_vlan_offload_set(dev, ETH_VLAN_FILTER_MASK);
 
-	/* update the current status */
-	dpaa2_dev_link_update(dev, 0);
-
 	return 0;
 }
 
@@ -1757,6 +1754,7 @@ dpaa2_dev_set_link_up(struct rte_eth_dev *dev)
 	/* changing tx burst function to start enqueues */
 	dev->tx_pkt_burst = dpaa2_dev_tx;
 	dev->data->dev_link.link_status = state.up;
+	dev->data->dev_link.link_speed = state.rate;
 
 	if (state.up)
 		DPAA2_PMD_INFO("Port %d Link is Up", dev->data->port_id);
-- 
2.17.1


  parent reply	other threads:[~2020-05-08 13:04 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200302145829.27808-1-hemant.agrawal@nxp.com>
2020-03-02 14:58 ` [dpdk-stable] [PATCH 01/16] net/dpaa2: fix 10g " Hemant Agrawal
2020-03-02 14:58 ` [dpdk-stable] [PATCH 02/16] bus/fslmc: fix dereferencing null pointer Hemant Agrawal
     [not found] ` <20200306095742.18080-1-hemant.agrawal@nxp.com>
2020-03-06  9:57   ` [dpdk-stable] [PATCH v2 01/16] net/dpaa2: fix 10g port negotiation issue Hemant Agrawal
2020-03-06  9:57   ` [dpdk-stable] [PATCH v2 02/16] bus/fslmc: fix dereferencing null pointer Hemant Agrawal
     [not found]   ` <20200504124118.22877-1-hemant.agrawal@nxp.com>
2020-05-04 12:41     ` [dpdk-stable] [PATCH v3 1/8] " Hemant Agrawal
2020-05-06 21:08       ` Ferruh Yigit
2020-05-06 21:09         ` Ferruh Yigit
2020-05-06 21:14       ` Ferruh Yigit
2020-05-04 12:41     ` [dpdk-stable] [PATCH v3 2/8] net/dpaa2: fix 10g port negotiation issue Hemant Agrawal
     [not found]     ` <20200507104645.31990-1-hemant.agrawal@nxp.com>
2020-05-07 10:46       ` [dpdk-stable] [PATCH v4 1/9] bus/fslmc: fix dereferencing null pointer Hemant Agrawal
2020-05-07 10:46       ` [dpdk-stable] [PATCH v4 2/9] net/dpaa2: fix 10g port negotiation issue Hemant Agrawal
2020-05-07 14:36         ` Ferruh Yigit
2020-05-07 10:46       ` [dpdk-stable] [PATCH v4 8/9] net/dpaa2: fix cong group id for multiple tcs Hemant Agrawal
2020-05-07 14:33         ` Ferruh Yigit
2020-05-07 10:46       ` [dpdk-stable] [PATCH v4 9/9] bus/fslmc: fix the size of qman fq desc Hemant Agrawal
     [not found]       ` <20200508125934.14255-1-hemant.agrawal@nxp.com>
2020-05-08 12:59         ` [dpdk-stable] [PATCH v5 1/9] net/dpaa2: fix 10G port negotiation issue Hemant Agrawal
2020-05-08 12:59         ` [dpdk-stable] [PATCH v5 7/9] net/dpaa2: fix cong group id for multiple tcs Hemant Agrawal
2020-05-08 12:59         ` [dpdk-stable] [PATCH v5 8/9] bus/fslmc: fix the size of qman fq desc Hemant Agrawal
     [not found]       ` <20200508130211.14334-1-hemant.agrawal@nxp.com>
2020-05-08 13:02         ` [dpdk-stable] [PATCH v6 01/10] bus/fslmc: fix dereferencing null pointer Hemant Agrawal
2020-05-08 13:02         ` Hemant Agrawal [this message]
2020-05-08 13:02         ` [dpdk-stable] [PATCH v6 08/10] net/dpaa2: fix cong group id for multiple tcs Hemant Agrawal
2020-05-08 13:02         ` [dpdk-stable] [PATCH v6 09/10] bus/fslmc: fix the size of qman fq desc Hemant Agrawal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200508130211.14334-3-hemant.agrawal@nxp.com \
    --to=hemant.agrawal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=rohit.raj@nxp.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).