patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Guinan Sun <guinanx.sun@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v2] net/ixgbe: fix statistics error in flow control mode
Date: Wed, 13 May 2020 08:59:18 +0800	[thread overview]
Message-ID: <20200513005918.GS75514@intel.com> (raw)
In-Reply-To: <20200512081306.16013-1-guinanx.sun@intel.com>

On 05/12, Guinan Sun wrote:
>The register autoneg can't be updated synchronously
>with flow control mode setting in the state of port start
>, so NIC statistics error occurs. AUTO_NEG Advt register
>should be updated by ixgbe_setup_fc() when enabling flow control.
>The patch fixes the issue.
>
>Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting")
>Cc: stable@dpdk.org
>
>Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
>---
>v2 changes:
>* Replaced mac.ops.setup_fc() with ixgbe_setup_fc()
>* Modified commit message.
>---
> drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
>index a4e5c539d..f8a84c565 100644
>--- a/drivers/net/ixgbe/ixgbe_ethdev.c
>+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
>@@ -2543,6 +2543,8 @@ ixgbe_flow_ctrl_enable(struct rte_eth_dev *dev, struct ixgbe_hw *hw)
> 	int err;
> 	uint32_t mflcn;
> 
>+	ixgbe_setup_fc(hw);
>+
> 	err = ixgbe_fc_enable(hw);
> 
> 	/* Not negotiated is not an error case */
>-- 
>2.17.1
>

Applied to dpdk-next-net-intel, Thanks.

  parent reply	other threads:[~2020-05-13  1:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-08  8:29 [dpdk-stable] [PATCH] " Guinan Sun
2020-05-09  3:13 ` [dpdk-stable] [dpdk-dev] " Jiang, YuX
2020-05-11  1:03 ` Zhao1, Wei
2020-05-12  8:28   ` Sun, GuinanX
2020-05-12  8:13 ` [dpdk-stable] [PATCH v2] " Guinan Sun
2020-05-12  8:39   ` [dpdk-stable] [dpdk-dev] " Zhao1, Wei
2020-05-13  0:59   ` Ye Xiaolong [this message]
2020-05-13  7:03     ` Jiang, YuX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200513005918.GS75514@intel.com \
    --to=xiaolong.ye@intel.com \
    --cc=dev@dpdk.org \
    --cc=guinanx.sun@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).