From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DD9EA034F for ; Wed, 13 May 2020 03:07:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6BCD71C01E; Wed, 13 May 2020 03:07:32 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 82C441BFA6; Wed, 13 May 2020 03:07:28 +0200 (CEST) IronPort-SDR: x2uqhLJCfo01cc5TEBtGo5W8VTq5M6wa26gOYfoOhhYvqI/l87DCO2NSyjYpXd+J71Ce9QDOxU m5Uv9I2J8XLA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2020 18:07:27 -0700 IronPort-SDR: VlZsbgSQDYEtNWWmXmRi2gOjbrFFgF8wFrkDYpjV83ER3k/uJkVhAwenWC2ybgZASmg0klDrfW 6Av4kQqII6Sg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,385,1583222400"; d="scan'208";a="286847595" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.116.183]) by fmsmga004.fm.intel.com with ESMTP; 12 May 2020 18:07:26 -0700 Date: Wed, 13 May 2020 08:59:18 +0800 From: Ye Xiaolong To: Guinan Sun Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20200513005918.GS75514@intel.com> References: <20200508082939.32525-1-guinanx.sun@intel.com> <20200512081306.16013-1-guinanx.sun@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200512081306.16013-1-guinanx.sun@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-stable] [PATCH v2] net/ixgbe: fix statistics error in flow control mode X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 05/12, Guinan Sun wrote: >The register autoneg can't be updated synchronously >with flow control mode setting in the state of port start >, so NIC statistics error occurs. AUTO_NEG Advt register >should be updated by ixgbe_setup_fc() when enabling flow control. >The patch fixes the issue. > >Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting") >Cc: stable@dpdk.org > >Signed-off-by: Guinan Sun >--- >v2 changes: >* Replaced mac.ops.setup_fc() with ixgbe_setup_fc() >* Modified commit message. >--- > drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c >index a4e5c539d..f8a84c565 100644 >--- a/drivers/net/ixgbe/ixgbe_ethdev.c >+++ b/drivers/net/ixgbe/ixgbe_ethdev.c >@@ -2543,6 +2543,8 @@ ixgbe_flow_ctrl_enable(struct rte_eth_dev *dev, struct ixgbe_hw *hw) > int err; > uint32_t mflcn; > >+ ixgbe_setup_fc(hw); >+ > err = ixgbe_fc_enable(hw); > > /* Not negotiated is not an error case */ >-- >2.17.1 > Applied to dpdk-next-net-intel, Thanks.