patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Xuan Ding <xuan.ding@intel.com>
Cc: maxime.coquelin@redhat.com, zhihong.wang@intel.com, dev@dpdk.org,
	stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v2] vhost: fix zero-copy cannot be enabled
Date: Tue, 19 May 2020 14:28:25 +0800
Message-ID: <20200519062825.GD38911@intel.com> (raw)
In-Reply-To: <20200513021410.98031-1-xuan.ding@intel.com>

On 05/13, Xuan Ding wrote:
>This patch fixes the situation where vhost-user cannot start as server with
>dequeue_zero_copy enabled.
>
>Using flag instead of vsocket->is_server to determine whether vhost-user is
>in client mode. Because vsocket->is_server is not ready at this time.
>
>Cc: stable@dpdk.org

Fixes: 715070ea10e6 ("vhost: prevent zero-copy with incompatible client mode")

And no need to cc stable since above commit is introduced in this release.

>
>Signed-off-by: Xuan Ding <xuan.ding@intel.com>
>---
>
>v2:
>* Added the description of problem solved in commit log.
>---
> lib/librte_vhost/socket.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
>index bb8d0d780..0a66ef976 100644
>--- a/lib/librte_vhost/socket.c
>+++ b/lib/librte_vhost/socket.c
>@@ -926,7 +926,7 @@ rte_vhost_driver_register(const char *path, uint64_t flags)
> 			ret = -1;
> 			goto out_mutex;
> 		}
>-		if (!vsocket->is_server) {
>+		if ((flags & RTE_VHOST_USER_CLIENT) != 0) {
> 			VHOST_LOG_CONFIG(ERR,
> 			"error: zero copy is incompatible with vhost client mode\n");
> 			ret = -1;
>-- 
>2.17.1
>

Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>

  reply	other threads:[~2020-05-19  6:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-12  9:51 [dpdk-stable] [PATCH] vhost: fix dequeue_zero_zopy " Xuan Ding
2020-05-13  2:14 ` [dpdk-stable] [PATCH v2] vhost: fix zero-copy " Xuan Ding
2020-05-19  6:28   ` Ye Xiaolong [this message]
2020-05-19  7:13     ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
2020-05-19 13:43       ` Ferruh Yigit
2020-05-19  7:03   ` Wang, Yinan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200519062825.GD38911@intel.com \
    --to=xiaolong.ye@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    --cc=xuan.ding@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git