From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7FBAA0093 for ; Tue, 19 May 2020 14:58:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AFD191C1E4; Tue, 19 May 2020 14:58:57 +0200 (CEST) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id 02EA61D620 for ; Tue, 19 May 2020 14:58:56 +0200 (CEST) Received: by mail-wm1-f65.google.com with SMTP id u188so3467697wmu.1 for ; Tue, 19 May 2020 05:58:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rEFkZXce3JYbNFTthrZ6GysrlVYdEdkC8Wg1uQdnkds=; b=hA3wjh57A33wxVqB4Hdd9SsL2d02CVpvPn5IrXpxA01EBJkuMT0ocWmG/Aty2tc6Y4 rRZM1sFcMnE6qh0RaiJrPSKZHkXHby1eLYh7qQVmV9SwZ+MMgu2fNFgh27u98M0jI6+0 Xr4InOaecPXLavb79/Zw36nQv+9/s4qKryLejDSXObe3IWPCoyj1IaD49LnzcWvZcWfO KsXQTkaC9QBN9f+7jLwidMV2S/5qf5Yh4CqLviIYBk+M74QSTaBLOirXmN/b1AcF+Znx nTBofsKeMoOzDbbUSaFcX1NNPUfWcEQOftS54CD91KtxyPlxLh1Spk/A5ITK9YL75dHu EWlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rEFkZXce3JYbNFTthrZ6GysrlVYdEdkC8Wg1uQdnkds=; b=SXQyvbf2NZ8cKNJjBqUQqwbzbO187T+H/iUtpetFNIJqKDI9qj8Fq3Ul3t4xq6cnde OApIIp1MThrGY64YBiNZk7sYB/WE3LiAVuV7fm3alF4tcOfzFZzcNx5AFgVgndd3JUpX cIyhfSNsDzWysfJVR5Kgnn5ExFEeXxiNnm6H8Hg1TM0bPPs+Ss07MVxu2DsebBtPg4Vq mII4AkcE7MdZf9i+4htvCTaa5Sps3Xt9tBHO8l8Kg+9wYQshDxbtnDegprLJV2ILhqIS YdHCf81VhWWJKXlgycjBPlT6x39LftNfO4Xm2CWgEWtDAFSjod+pi8CrwnuC/YQGou79 2ScQ== X-Gm-Message-State: AOAM5301HM9MBAefwwEP5n78ghNkSkgHmqq8KkqbVgzJe2E2O/qzq+vO 4PO9hNN869HOhr5s1sxBcYHlJcVVZPX26La7 X-Google-Smtp-Source: ABdhPJyw6WKi5gIylxbhyuLf7Jkp309dnzlAGFzJclVuhPd0sPuYjy3xMG+O30zTu9KiLe6KfdJ7MA== X-Received: by 2002:a1c:9a45:: with SMTP id c66mr5694303wme.133.1589893135687; Tue, 19 May 2020 05:58:55 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id 37sm21312126wrk.61.2020.05.19.05.58.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 05:58:55 -0700 (PDT) From: luca.boccassi@gmail.com To: Dmitry Kozlyuk Cc: William Tu , Pallavi Kadam , dpdk stable Date: Tue, 19 May 2020 13:53:27 +0100 Message-Id: <20200519125804.104349-17-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200519125804.104349-1-luca.boccassi@gmail.com> References: <20200519125804.104349-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'build: fix linker warnings with clang on Windows' has been queued to stable release 19.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/21/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From c2e90f337dc9bdefdc15b76b32c070ce068c25c1 Mon Sep 17 00:00:00 2001 From: Dmitry Kozlyuk Date: Thu, 27 Feb 2020 07:25:37 +0300 Subject: [PATCH] build: fix linker warnings with clang on Windows [ upstream commit 716f9bb42ecb6df640d4dffebe1ec55aaab29ba0 ] Clang on Windows doesn't use pthread for now, while MinGW does. Removing `-pthread` option with MS linker fixes the following warning: clang: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument] Option `--no-as-needed` is meaningless for PE output. Disabling it on Windows fixes the following warning: LINK : warning LNK4044: unrecognized option '/-no-as-needed'; ignored Fixes: 98edcbb5a ("eal/windows: introduce Windows support") Signed-off-by: Dmitry Kozlyuk Tested-by: William Tu Tested-by: Pallavi Kadam Acked-by: Pallavi Kadam --- config/meson.build | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/config/meson.build b/config/meson.build index 41747012df..cdbe724754 100644 --- a/config/meson.build +++ b/config/meson.build @@ -98,11 +98,15 @@ dpdk_conf.set('RTE_TOOLCHAIN_' + toolchain.to_upper(), 1) dpdk_conf.set('RTE_ARCH_64', cc.sizeof('void *') == 8) -add_project_link_arguments('-Wl,--no-as-needed', language: 'c') +if not is_windows + add_project_link_arguments('-Wl,--no-as-needed', language: 'c') +endif -# use pthreads -add_project_link_arguments('-pthread', language: 'c') -dpdk_extra_ldflags += '-pthread' +# use pthreads if available for the platform +if not is_ms_linker + add_project_link_arguments('-pthread', language: 'c') + dpdk_extra_ldflags += '-pthread' +endif # on some OS, maths functions are in a separate library if cc.find_library('m', required : false).found() -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-19 13:56:19.492440217 +0100 +++ 0017-build-fix-linker-warnings-with-clang-on-Windows.patch 2020-05-19 13:56:18.179501099 +0100 @@ -1,8 +1,10 @@ -From 716f9bb42ecb6df640d4dffebe1ec55aaab29ba0 Mon Sep 17 00:00:00 2001 +From c2e90f337dc9bdefdc15b76b32c070ce068c25c1 Mon Sep 17 00:00:00 2001 From: Dmitry Kozlyuk Date: Thu, 27 Feb 2020 07:25:37 +0300 Subject: [PATCH] build: fix linker warnings with clang on Windows +[ upstream commit 716f9bb42ecb6df640d4dffebe1ec55aaab29ba0 ] + Clang on Windows doesn't use pthread for now, while MinGW does. Removing `-pthread` option with MS linker fixes the following warning: @@ -25,10 +27,10 @@ 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/config/meson.build b/config/meson.build -index 68aeb84703..abedd76f23 100644 +index 41747012df..cdbe724754 100644 --- a/config/meson.build +++ b/config/meson.build -@@ -112,11 +112,15 @@ dpdk_conf.set('RTE_TOOLCHAIN_' + toolchain.to_upper(), 1) +@@ -98,11 +98,15 @@ dpdk_conf.set('RTE_TOOLCHAIN_' + toolchain.to_upper(), 1) dpdk_conf.set('RTE_ARCH_64', cc.sizeof('void *') == 8)