From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0A2AA0093 for ; Tue, 19 May 2020 14:58:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D5D681C1E4; Tue, 19 May 2020 14:58:58 +0200 (CEST) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 556571D62C for ; Tue, 19 May 2020 14:58:58 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id l17so15814247wrr.4 for ; Tue, 19 May 2020 05:58:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=O1ZOMe9/pxxAQUe2qKwNKs3P6yGmf35HGv5wQruIUwA=; b=fBqsnVyMBl9vBOllo6EpoHjSmB2dXZxiu3cUPGcTbz4NpUW0BksSsxjMzelHPGcKhz IUZ8Vf9zMFx2GnqMSgz3AGFRtJCGTowZl4CPEq2QPtU9DV1M7XdMl+fYQII4SM3S7kRE GlBpie2o52ZzFEDgB984NAD50fyfBDHXz1bLQlWvTsRfpEfKfotTT4caVYZRcYYR19UL i/ZvkxveTiU0QbwJx8eZnzv754K4mkcusM/jdSsBwkTHDsowczxdadl8K1Ubqr6XXlUm E9lVuQkw24VR2R4YihddcEAhvBiX1FK6KMegwnlI6qPsPeTjvX2r4ce1myeX1uCtMx8y qniQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=O1ZOMe9/pxxAQUe2qKwNKs3P6yGmf35HGv5wQruIUwA=; b=J4VPDIu5J6Vs3hG5Rk/2a716VrkxZO8Fi5w9JM2ZGOnAfX/IeAaJozIXmPEw2UbyFS SETH3wSqZG6HAdQjgCbpEzaqnJni1H6+DgjerrWuTqa/3E5MVyQzSp7bfYfaGnDKvh86 haVC10YzymuG14lyIHZbRXCHtl/YQn8LfOodxh38IXVaZ8zqsAaoc4UV3W136cd/fZVr AfnLDbvvYeNk4d4nEebC4hDvcqaj6Jip9/vLziSMGwf+M6/XgWWv26ttjQdQTdxLAXzi 44J3TFn6heO0x1Y3gX0Ke1pQe9f289tK31lYB4lcO0frkosBRmKB4dvggcA6WiOuF3NA 6z6w== X-Gm-Message-State: AOAM531SZqmy49skUdGixmP0SIBJlGMRiQlbEW3PTg7OuT62v8iLqsH4 yjNz37LhON2MNqhNtgl0mhA= X-Google-Smtp-Source: ABdhPJzj1WPA49jbAx7xxaWisG3p1c8wLFyGpk2uZW0ipyJztZFYMzIU+Z6GFfces837wkPQqN48TQ== X-Received: by 2002:a5d:46c6:: with SMTP id g6mr26309827wrs.139.1589893138019; Tue, 19 May 2020 05:58:58 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id h1sm4042549wme.42.2020.05.19.05.58.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 05:58:57 -0700 (PDT) From: luca.boccassi@gmail.com To: Gavin Hu Cc: Jerin Jacob , dpdk stable Date: Tue, 19 May 2020 13:53:29 +0100 Message-Id: <20200519125804.104349-19-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200519125804.104349-1-luca.boccassi@gmail.com> References: <20200519125804.104349-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/i40e: relax barrier in Tx' has been queued to stable release 19.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/21/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 3e387d591e7b421397349d772ff55cf52ebe9c0b Mon Sep 17 00:00:00 2001 From: Gavin Hu Date: Wed, 12 Feb 2020 13:56:21 +0800 Subject: [PATCH] net/i40e: relax barrier in Tx [ upstream commit bade47a7570b99cf77e71343cf43efed66ab8307 ] To keep ordering of mixed accesses, rte_cio is sufficient. The rte_io barrier inside the I40E_PCI_REG_WRITE is overkill.[1] [1] http://inbox.dpdk.org/dev/CALBAE1M-ezVWCjqCZDBw+MMDEC4O9 qf0Kpn89EMdGDajepKoZQ@mail.gmail.com Fixes: 4861cde46116 ("i40e: new poll mode driver") Signed-off-by: Gavin Hu Reviewed-by: Jerin Jacob --- drivers/net/i40e/i40e_rxtx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index 0ae47b807b..9a1eab4653 100644 --- a/drivers/net/i40e/i40e_rxtx.c +++ b/drivers/net/i40e/i40e_rxtx.c @@ -1248,7 +1248,8 @@ end_of_tx: (unsigned) txq->port_id, (unsigned) txq->queue_id, (unsigned) tx_id, (unsigned) nb_tx); - I40E_PCI_REG_WRITE(txq->qtx_tail, tx_id); + rte_cio_wmb(); + I40E_PCI_REG_WRITE_RELAXED(txq->qtx_tail, tx_id); txq->tx_tail = tx_id; return nb_tx; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-19 13:56:19.563316099 +0100 +++ 0019-net-i40e-relax-barrier-in-Tx.patch 2020-05-19 13:56:18.183501171 +0100 @@ -1,8 +1,10 @@ -From bade47a7570b99cf77e71343cf43efed66ab8307 Mon Sep 17 00:00:00 2001 +From 3e387d591e7b421397349d772ff55cf52ebe9c0b Mon Sep 17 00:00:00 2001 From: Gavin Hu Date: Wed, 12 Feb 2020 13:56:21 +0800 Subject: [PATCH] net/i40e: relax barrier in Tx +[ upstream commit bade47a7570b99cf77e71343cf43efed66ab8307 ] + To keep ordering of mixed accesses, rte_cio is sufficient. The rte_io barrier inside the I40E_PCI_REG_WRITE is overkill.[1] @@ -10,7 +12,6 @@ qf0Kpn89EMdGDajepKoZQ@mail.gmail.com Fixes: 4861cde46116 ("i40e: new poll mode driver") -Cc: stable@dpdk.org Signed-off-by: Gavin Hu Reviewed-by: Jerin Jacob @@ -19,7 +20,7 @@ 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c -index f6d23c9fb6..fdc1e00355 100644 +index 0ae47b807b..9a1eab4653 100644 --- a/drivers/net/i40e/i40e_rxtx.c +++ b/drivers/net/i40e/i40e_rxtx.c @@ -1248,7 +1248,8 @@ end_of_tx: