From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62F0FA0093 for ; Tue, 19 May 2020 15:00:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9A0771D625; Tue, 19 May 2020 15:00:25 +0200 (CEST) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by dpdk.org (Postfix) with ESMTP id E0B501D62E for ; Tue, 19 May 2020 15:00:23 +0200 (CEST) Received: by mail-wr1-f42.google.com with SMTP id w7so15748842wre.13 for ; Tue, 19 May 2020 06:00:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5Fljhmuu1daC4XfwkgEKH7piyN5LsEr8lAdxPVSJa0g=; b=GkzGVi8lCMLcYzFqQD15EJp7XLB2Qy4tL4QXufAr6oy/I334d+uQ5XwPEcOdeyBxJU tqXlsQ3EXqoefV/S1o5VbgkmltrPLoih5b8siF/ofD7vF5mgbBu7/jQ99zX1w9N8qDqb Q51VhdU607YuFX8fj9UKXsSNutR42haEtIgEg7vDBbpISUPkLX8DcPNhnvd7uH6mdLpd 7UsDutU0nUiVZuHTm9vNd+Qcw2glVBBFSaBpzm34j//l8LvIYRDPYGEK1wOLHX3W/EN1 qf0hrtkMnHfXvZRcInDC/Vh0H5kdb1TedSXdW7Bd4I4ESIA0rkfKL4xbr9K67ujx4P89 me9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5Fljhmuu1daC4XfwkgEKH7piyN5LsEr8lAdxPVSJa0g=; b=XUAjJ0PCXiVaYC0jZoLV90VdJmTKGzTiwIt/2eYON+pLiaEGhoUMM9H5lj2FB6scsN YjnRAj/Le7nJehDSyShDv2qhvmqICjxrz4fgLzw4phS2a51h1k4CvagCPvikR+mi3zVN PugDk47Rly+TAglSZJND6hBT11mrGW/Gq/xu1zqNhMkNOiuwrGzHELLsFV89qpulPBGb ncUrgaFBcVwCQjMgh/zOvV6gqC+ruEgEXpKl4rK9MwstYm6WR1SHFr/FSTW1tkBH13EA VdFWgq5RyrDM1WWgc6i93o20fJMDFGR7jle5DDa17hrPUX0Y2GrX19SRGlREbhWx70T1 7P6g== X-Gm-Message-State: AOAM533VT4yg6YrQHr9ImlIpdA+NcUZ0DjT5h9YEUA11g3RzXcwohqyy S63+FjUaAYToMGgnlVz5QrU= X-Google-Smtp-Source: ABdhPJynHrBGszrwgW8gxwu+n425arHx281xN4WJpdNZY7SLBcTnRWmXoWzT1ffG8elQ7hJATueabw== X-Received: by 2002:adf:e90b:: with SMTP id f11mr25685146wrm.364.1589893223603; Tue, 19 May 2020 06:00:23 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id a15sm20814698wrw.56.2020.05.19.06.00.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 06:00:23 -0700 (PDT) From: luca.boccassi@gmail.com To: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= Cc: Ola Liljedahl , dpdk stable Date: Tue, 19 May 2020 13:54:17 +0100 Message-Id: <20200519125804.104349-67-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200519125804.104349-1-luca.boccassi@gmail.com> References: <20200519125804.104349-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'event/dsw: remove unnecessary read barrier' has been queued to stable release 19.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/21/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From b0843e567101508860040091b5c58e9b147b6975 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= Date: Mon, 9 Mar 2020 07:51:05 +0100 Subject: [PATCH] event/dsw: remove unnecessary read barrier MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit cea7bc671311e8cf5fbc21dceb15f5f8af8ee36b ] Remove unnecessary read barrier (and misleading comment) on control message dequeue. Fixes: f6257b22e767 ("event/dsw: add load balancing") Suggested-by: Ola Liljedahl Signed-off-by: Mattias Rönnblom --- drivers/event/dsw/dsw_event.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/event/dsw/dsw_event.c b/drivers/event/dsw/dsw_event.c index 8ea68cd966..10e44fd497 100644 --- a/drivers/event/dsw/dsw_event.c +++ b/drivers/event/dsw/dsw_event.c @@ -930,11 +930,6 @@ dsw_port_ctl_process(struct dsw_evdev *dsw, struct dsw_port *port) { struct dsw_ctl_msg msg; - /* So any table loads happens before the ring dequeue, in the - * case of a 'paus' message. - */ - rte_smp_rmb(); - if (dsw_port_ctl_dequeue(port, &msg) == 0) { switch (msg.type) { case DSW_CTL_PAUS_REQ: -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-19 13:56:21.543998949 +0100 +++ 0067-event-dsw-remove-unnecessary-read-barrier.patch 2020-05-19 13:56:18.295503187 +0100 @@ -1,4 +1,4 @@ -From cea7bc671311e8cf5fbc21dceb15f5f8af8ee36b Mon Sep 17 00:00:00 2001 +From b0843e567101508860040091b5c58e9b147b6975 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= Date: Mon, 9 Mar 2020 07:51:05 +0100 Subject: [PATCH] event/dsw: remove unnecessary read barrier @@ -6,11 +6,12 @@ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit +[ upstream commit cea7bc671311e8cf5fbc21dceb15f5f8af8ee36b ] + Remove unnecessary read barrier (and misleading comment) on control message dequeue. Fixes: f6257b22e767 ("event/dsw: add load balancing") -Cc: stable@dpdk.org Suggested-by: Ola Liljedahl Signed-off-by: Mattias Rönnblom @@ -19,10 +20,10 @@ 1 file changed, 5 deletions(-) diff --git a/drivers/event/dsw/dsw_event.c b/drivers/event/dsw/dsw_event.c -index c31a4c492f..94c8efdbcf 100644 +index 8ea68cd966..10e44fd497 100644 --- a/drivers/event/dsw/dsw_event.c +++ b/drivers/event/dsw/dsw_event.c -@@ -1065,11 +1065,6 @@ dsw_port_ctl_process(struct dsw_evdev *dsw, struct dsw_port *port) +@@ -930,11 +930,6 @@ dsw_port_ctl_process(struct dsw_evdev *dsw, struct dsw_port *port) { struct dsw_ctl_msg msg;