From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8449A0093 for ; Tue, 19 May 2020 15:00:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9FBF71D627; Tue, 19 May 2020 15:00:44 +0200 (CEST) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 256481D625 for ; Tue, 19 May 2020 15:00:43 +0200 (CEST) Received: by mail-wm1-f67.google.com with SMTP id m185so3446394wme.3 for ; Tue, 19 May 2020 06:00:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QyhK6f9vJToPDnHcHeanojJwhpf4qXU/szdL+MhjHWo=; b=MvhE4udRUbcOSmal1SfVvky+dULG8C1ffJkS4uOTZGgtS2rZ8vhIbLV7qfsPSPEBpn XSdcnXraSkwC7svmRtq7agIEMM/UBXRil9IDz1v992sGp4PDDNwecpf6jgqHZy5i6tBG dNFqeO6Rizgwgc6F2eDDPc6YlWepnAcW93YZeiG9UldbbvcEJ8IgMlf9nz2jMDFuQpRz 9FAxkbuRHISYWKOpMnXKWWfZdUnxcGSgGFUm3wPtDDrUiH9dcMMrOWp3FXtGrgII4pFs lCO1iZY7fq1amlHZBD0ec30EO1oyzTGPBuWWS1WLAQKxc5Q8zTVEG9v7hv1XJgKOZqOO TQ0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QyhK6f9vJToPDnHcHeanojJwhpf4qXU/szdL+MhjHWo=; b=UnV4WN6UW/WoWrU9+Lm5zNeT67EpGPXTJGrunWCAUhg9+RV0xtvn4dFUUobOOGojc2 uN2AqMlCBilBgyuPl+DGF6bxVA+juJI5YfDaAZyzuIo3YsVLDNCVWvrKnT+o7y7X48N4 8TSOSQr5yOtWJIa8pFKwnPjOak3XvWGp7lzJ672uGBYuFPisGNLVTM88RIQuThvmyfeH Ev4UfI4VC0lt4br5mdgW0NYHNKBXdGsiW23p7x4rhho6p+2CZN/0vSJVY2KOjWsHTCI+ a4pPc5t7iCuylXETKVMZ0znqC0XLlIPhqDfAgTzAttojIvB2jy/lzOaM6LEU1teK+zyr lGsg== X-Gm-Message-State: AOAM533r9WyBtvWUq02wAjoapjnInbklb1gZHVdmVcGlMGRd1ck/GRUv B8anNCrbJOTip8gvXRZO/Pll9+rI7oYi314D X-Google-Smtp-Source: ABdhPJz7PDjx6MHm/qjEo6DStez3QmLXpVJzAFaqOw9Enbba1b7Kw+MINxnuCi8WPgXcbsaMoVKqnA== X-Received: by 2002:a7b:cf15:: with SMTP id l21mr5330876wmg.172.1589893242892; Tue, 19 May 2020 06:00:42 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id 5sm3936712wmd.19.2020.05.19.06.00.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 06:00:42 -0700 (PDT) From: luca.boccassi@gmail.com To: Pablo de Lara Cc: Fiona Trahe , dpdk stable Date: Tue, 19 May 2020 13:54:28 +0100 Message-Id: <20200519125804.104349-78-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200519125804.104349-1-luca.boccassi@gmail.com> References: <20200519125804.104349-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'test/crypto: fix flag check' has been queued to stable release 19.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/21/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 8d5349e781421047b8dac4966acd3a443d97a053 Mon Sep 17 00:00:00 2001 From: Pablo de Lara Date: Thu, 16 Apr 2020 18:12:46 +0100 Subject: [PATCH] test/crypto: fix flag check [ upstream commit 042bb5654404643afcebef194d23f559606665ef ] An incorrect flag check was done, using "&&" instead of "&". Fixes: 2717246ecd7d ("cryptodev: replace mbuf scatter gather flag") Signed-off-by: Pablo de Lara Acked-by: Fiona Trahe --- app/test/test_cryptodev_blockcipher.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_cryptodev_blockcipher.c b/app/test/test_cryptodev_blockcipher.c index 5bfe2d009f..2f91d000a2 100644 --- a/app/test/test_cryptodev_blockcipher.c +++ b/app/test/test_cryptodev_blockcipher.c @@ -93,7 +93,7 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t, uint64_t feat_flags = dev_info.feature_flags; uint64_t oop_flag = RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT; - if (t->feature_mask && BLOCKCIPHER_TEST_FEATURE_OOP) { + if (t->feature_mask & BLOCKCIPHER_TEST_FEATURE_OOP) { if (!(feat_flags & oop_flag)) { printf("Device doesn't support out-of-place " "scatter-gather in input mbuf. " -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-19 13:56:21.974938861 +0100 +++ 0078-test-crypto-fix-flag-check.patch 2020-05-19 13:56:18.311503476 +0100 @@ -1,12 +1,13 @@ -From 042bb5654404643afcebef194d23f559606665ef Mon Sep 17 00:00:00 2001 +From 8d5349e781421047b8dac4966acd3a443d97a053 Mon Sep 17 00:00:00 2001 From: Pablo de Lara Date: Thu, 16 Apr 2020 18:12:46 +0100 Subject: [PATCH] test/crypto: fix flag check +[ upstream commit 042bb5654404643afcebef194d23f559606665ef ] + An incorrect flag check was done, using "&&" instead of "&". Fixes: 2717246ecd7d ("cryptodev: replace mbuf scatter gather flag") -Cc: stable@dpdk.org Signed-off-by: Pablo de Lara Acked-by: Fiona Trahe @@ -15,7 +16,7 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_cryptodev_blockcipher.c b/app/test/test_cryptodev_blockcipher.c -index 2ff7fc91ba..4973c74a92 100644 +index 5bfe2d009f..2f91d000a2 100644 --- a/app/test/test_cryptodev_blockcipher.c +++ b/app/test/test_cryptodev_blockcipher.c @@ -93,7 +93,7 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t,