From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A5A9A0093 for ; Tue, 19 May 2020 15:11:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 51E2D1D702; Tue, 19 May 2020 15:11:39 +0200 (CEST) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id 0A2C81D713 for ; Tue, 19 May 2020 15:11:37 +0200 (CEST) Received: by mail-wm1-f65.google.com with SMTP id z72so3513844wmc.2 for ; Tue, 19 May 2020 06:11:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fQPGmLbyrPGruSMp8vJe6iy9PmPC/lRUf+k1OBjY264=; b=veDDA+MszqnL32btuq0QgxJWnyEB8lZ4p1/fJH3BHAY9K6hUDoPhCyNFl83AXrg47y SOmEgB8QFI64pmXTZzdogSEWHrVfeNLNZTjNlXHFdvPhzL85b5vfbFu9RryY0vTsdOWd /LNSswwgSSKAEfTS6oXJeRSBh+DGhHnQSbJc0fKiOHnff+AXzinXl7USi7IOtko2lIga txaNsoPyMzJljxKepyJQ20PTAsABRv3LsbL8pT+JgG7lusY6Npc3Z6y7Xp+bSKzNphOQ edtcqe/c+p+qsLPDcj3BD+rY2++IrrU7eq1a7AxkhpAcW16HjjFf9DzToWjunv82/7hM y/fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fQPGmLbyrPGruSMp8vJe6iy9PmPC/lRUf+k1OBjY264=; b=t0KY4WkuX0FYTKUeHNsb4sL3G6GyADBrxN8w39oPrgLk7D77oFn/53L5bw9ixs6RaT ZrAdyo/u0xeh4nn6EVsLOP0yg6vSihqb0PZMX2XhO4hkvA+rDnybY6vqEYw12t9+pzI2 naSMHHj1Enk4e/jy+oFdK4MeSEzRtZjyXMvhaGuS/ttDy9mnzgnRoSRx+2OwpOXR1flp I6ZsY719DF77366/yFnmYUXySb1mXmXB5HIxmb5t4zNiK6t3ztuUhYdzRG1Q4pSlVYqY WT3n8f+MWYTf9spo7dbjaJBE+HlvAceEcGlda3Or0lM6dB4hiABDOHdUTY11U6poqe0C BCsQ== X-Gm-Message-State: AOAM533Vmwhp+K4dlGF1K/VcD2EpyW+lpx2Fxst1EuEsLyoE+LY+gXIk ePQ6hWnFLo4zDzSO2xNO9h0= X-Google-Smtp-Source: ABdhPJxTUvvVcNAqrBgQ6yh7EC5KRdoySV6T5ZcGZyhTmWi3qMmlkL2ihTZwYYCcpnakSylpG/lh3A== X-Received: by 2002:a1c:2457:: with SMTP id k84mr5113206wmk.96.1589893896703; Tue, 19 May 2020 06:11:36 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id v126sm4501056wma.9.2020.05.19.06.11.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 06:11:36 -0700 (PDT) From: luca.boccassi@gmail.com To: Shougang Wang Cc: Qiming Yang , Xueming Zhang , dpdk stable Date: Tue, 19 May 2020 14:04:05 +0100 Message-Id: <20200519130549.112823-110-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200519130549.112823-1-luca.boccassi@gmail.com> References: <20200519125804.104349-1-luca.boccassi@gmail.com> <20200519130549.112823-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/ixgbe: fix link status after port reset' has been queued to stable release 19.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/21/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From ca2ecc15f20193a74bd9e6a0c14162e48daade97 Mon Sep 17 00:00:00 2001 From: Shougang Wang Date: Mon, 13 Apr 2020 01:38:39 +0000 Subject: [PATCH] net/ixgbe: fix link status after port reset [ upstream commit dfcea7f90f703dabcb3589ea06070a228dbcef12 ] It's a normal behavior to change the link status to up after resetting the port. So it is unnecessary to set link down before starting port, and changing the link state(link up/down) frequently will cause link speed unstable. Fixes: c3f2fbff78cf ("net/ixgbe: fix link status") Signed-off-by: Shougang Wang Acked-by: Qiming Yang Tested-by: Xueming Zhang --- drivers/net/ixgbe/ixgbe_ethdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 89d0e1c66a..29b7501e0a 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -1195,7 +1195,6 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused) diag = ixgbe_bypass_init_hw(hw); #else diag = ixgbe_init_hw(hw); - hw->mac.autotry_restart = false; #endif /* RTE_LIBRTE_IXGBE_BYPASS */ /* @@ -1306,8 +1305,6 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused) /* enable support intr */ ixgbe_enable_intr(eth_dev); - ixgbe_dev_set_link_down(eth_dev); - /* initialize filter info */ memset(filter_info, 0, sizeof(struct ixgbe_filter_info)); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-19 14:04:48.965781779 +0100 +++ 0110-net-ixgbe-fix-link-status-after-port-reset.patch 2020-05-19 14:04:44.368651128 +0100 @@ -1,15 +1,16 @@ -From dfcea7f90f703dabcb3589ea06070a228dbcef12 Mon Sep 17 00:00:00 2001 +From ca2ecc15f20193a74bd9e6a0c14162e48daade97 Mon Sep 17 00:00:00 2001 From: Shougang Wang Date: Mon, 13 Apr 2020 01:38:39 +0000 Subject: [PATCH] net/ixgbe: fix link status after port reset +[ upstream commit dfcea7f90f703dabcb3589ea06070a228dbcef12 ] + It's a normal behavior to change the link status to up after resetting the port. So it is unnecessary to set link down before starting port, and changing the link state(link up/down) frequently will cause link speed unstable. Fixes: c3f2fbff78cf ("net/ixgbe: fix link status") -Cc: stable@dpdk.org Signed-off-by: Shougang Wang Acked-by: Qiming Yang @@ -19,10 +20,10 @@ 1 file changed, 3 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c -index d26cf0ab9e..aa1e8aac51 100644 +index 89d0e1c66a..29b7501e0a 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c -@@ -1197,7 +1197,6 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused) +@@ -1195,7 +1195,6 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused) diag = ixgbe_bypass_init_hw(hw); #else diag = ixgbe_init_hw(hw); @@ -30,7 +31,7 @@ #endif /* RTE_LIBRTE_IXGBE_BYPASS */ /* -@@ -1308,8 +1307,6 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused) +@@ -1306,8 +1305,6 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused) /* enable support intr */ ixgbe_enable_intr(eth_dev);