From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4FA1A0093 for ; Tue, 19 May 2020 15:11:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AD99B1D71F; Tue, 19 May 2020 15:11:52 +0200 (CEST) Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by dpdk.org (Postfix) with ESMTP id 77DED1D702 for ; Tue, 19 May 2020 15:11:51 +0200 (CEST) Received: by mail-wr1-f47.google.com with SMTP id e1so15864806wrt.5 for ; Tue, 19 May 2020 06:11:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pEelgjTXtPlNyvfk366RlA9+CWTI5FMzQZa6VRJGzQE=; b=sHa6YKw5GgbxJ1qs/VxyJszUmagxGaK0LyVNfRoImTOwB4+W16iBQdVZt94r5BVPzE q/KLcHTuDHFWEhRopgH08t5wF83rXPtsq5VT3oUqBTJ6q7QPP6jK8H3hF5vG/lXNxy5z O205ulMF+CAdl07ncEAuoya03zMW7vbP4gSQgWqAs8MMNV1oSlFvTfKFyQTUsUy96vp2 d7vgKY2CGqV4GFC2asCLr8xToquI9aE7yijlJ/ui5pHaM6UBMyXy+ARccaQp+Z9gDI0z U5puIkDhXfLUMlZP/FmKmvXxOrpmMKHwolPyX67hpNRas7aCtFzHnVz0awneilYL4Hlx c4Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pEelgjTXtPlNyvfk366RlA9+CWTI5FMzQZa6VRJGzQE=; b=dZ/Zjq/n+Wq2HS4HQx3BpcIh4L4WpoTkr0HKIzgfcNQRooJ4MCLXPlPHFDVW6QO4gM LL5eqzA9XKdL9s0zUZtcShmkhiTanbKpLsjjO+UhCFTOOzyyd3URtrmBtHWZlJw2HRVu IEdF4nH1GukcFTFpz4wDpR9MFIfAmNx+/m5BiD5++W1nQKDrZ/uYzTSfiyVruhD6jygs biXG+cXeO2uXNiIoh+/8aTjgf7qC4ZteBwPiMRO3awPQni/HSGljpinq0IwtW9Wcyc3D eKkI5QB6X3gRKxZ1S4S4cZH9O9wATk9a6WpzMKsopThdN3nZn4HNHyfTYlEtjDluiHP+ A98g== X-Gm-Message-State: AOAM532HV4zklIoRVlxJ45lNu+FREdv/gkrkGeqLjHTOnI6PAtUAOgLH jSD3ZT8o4XAyrVAQ8oh/jhQ= X-Google-Smtp-Source: ABdhPJzPTDGrQh+al9DK07fP4os9r0im5rh77Uqi2mPQtg7VuQ5m3fJ4s4p0aVAxwhT/gwuyyGJ4Rg== X-Received: by 2002:a5d:66c5:: with SMTP id k5mr25156455wrw.17.1589893911188; Tue, 19 May 2020 06:11:51 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id l13sm20518846wrm.55.2020.05.19.06.11.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 06:11:50 -0700 (PDT) From: luca.boccassi@gmail.com To: Kalesh AP Cc: Somnath Kotur , Ajit Khaparde , dpdk stable Date: Tue, 19 May 2020 14:04:09 +0100 Message-Id: <20200519130549.112823-114-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200519130549.112823-1-luca.boccassi@gmail.com> References: <20200519125804.104349-1-luca.boccassi@gmail.com> <20200519130549.112823-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/bnxt: fix port start failure handling' has been queued to stable release 19.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/21/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From a62880c4d4ae861422c966ebbbb33082e474ddc1 Mon Sep 17 00:00:00 2001 From: Kalesh AP Date: Tue, 21 Apr 2020 14:33:48 -0700 Subject: [PATCH] net/bnxt: fix port start failure handling [ upstream commit cf2445374c573bdbccb8144962367cb21e99e58e ] Fixed to invoke clean up in the reverse sequence of initialization in case any of the FW commands fail during port start. Fixes: 0b533591238f ("net/bnxt: inform firmware about IF state changes") Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index ed88b594df..cddcd427df 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -891,10 +891,10 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev) return 0; error: - bnxt_hwrm_if_change(bp, false); bnxt_shutdown_nic(bp); bnxt_free_tx_mbufs(bp); bnxt_free_rx_mbufs(bp); + bnxt_hwrm_if_change(bp, false); eth_dev->data->dev_started = 0; return rc; } -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-19 14:04:49.133136338 +0100 +++ 0114-net-bnxt-fix-port-start-failure-handling.patch 2020-05-19 14:04:44.384651418 +0100 @@ -1,14 +1,15 @@ -From cf2445374c573bdbccb8144962367cb21e99e58e Mon Sep 17 00:00:00 2001 +From a62880c4d4ae861422c966ebbbb33082e474ddc1 Mon Sep 17 00:00:00 2001 From: Kalesh AP Date: Tue, 21 Apr 2020 14:33:48 -0700 Subject: [PATCH] net/bnxt: fix port start failure handling +[ upstream commit cf2445374c573bdbccb8144962367cb21e99e58e ] + Fixed to invoke clean up in the reverse sequence of initialization in case any of the FW commands fail during port start. Fixes: 0b533591238f ("net/bnxt: inform firmware about IF state changes") -Cc: stable@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur @@ -18,10 +19,10 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c -index 780d9c46e9..206111db5b 100644 +index ed88b594df..cddcd427df 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c -@@ -1113,10 +1113,10 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev) +@@ -891,10 +891,10 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev) return 0; error: