From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 251ABA0093 for ; Tue, 19 May 2020 15:12:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 020B51D71E; Tue, 19 May 2020 15:12:06 +0200 (CEST) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by dpdk.org (Postfix) with ESMTP id B5FDE1D715 for ; Tue, 19 May 2020 15:12:04 +0200 (CEST) Received: by mail-wm1-f54.google.com with SMTP id h4so2996540wmb.4 for ; Tue, 19 May 2020 06:12:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZXU8spA3RRdlG4Fll4F1wytVTlr+SymsTp4xgTHPpas=; b=UPJK4ziQgY/5n+nwdle2pj5TfaxIs3fghekEHjww1Z/99AFcJbUjbLWeQqKSCWdBeT sZKT1j0EGpMVc6p0/yY3s1fZFt/27v2mrqdAkUPIMFh5NyyjihM98uNzg42B4FJ97MML SOZeHZ6L+qmtWJHAIt7I4S6ct1E2jdfpkj97PsjSJ1ePOS2AqLBSet+Fjk4h5wFBUJoB 2Q5hsB/90NUNxV8UmJD26TR6seo2zRunCzEm9M90FNnBZ9LX2vU8+vNesltSNZqDoEzK iwd6vGgMt6Yu/Kn2wf1oKaZIFx2VEgremhvZhLj9dCLSv/5R6Bnj+g+RZMJMHveAB04+ j97w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZXU8spA3RRdlG4Fll4F1wytVTlr+SymsTp4xgTHPpas=; b=Pr/oX2SMmCwHEExqHVm1LR4KjC2n8Be6/Dtu9Bx0coDsC5XOyKF6GGPOz0v4FuUJG/ HgOL3YjV47EjFIt0YQ9xHRsGfYZe2FAvWeRGZXNbRQnttihDZCdihjhK2yCDXU4k78yA +yK9ilUO/MsqtCYttnQYGpsh4IOiyUJRsdas7S5d0P/RUTrXzalNesUzuTkOuKuJBoPZ f2MaUGaDmblkm+hOKMracwEk8X5bI7tyPCpFsoVZweDL8e/6xrJWSQKU9f6RbDOK6Soc H0QyM9x1kn7NDpF9bPvGdpLYYGrJ0NPy7bjfiC3MRmfDz3q+yeP1efxd+glwMgRQ9X9q hZ5Q== X-Gm-Message-State: AOAM533/zkzRewGELOJWkhu714civ3Dk7xZrmJiYYxejdHYDMRdOs+hv i81FSqIPqhjmLF/a3Mg2leA= X-Google-Smtp-Source: ABdhPJwiDi075uiq6D6VNayXki7jNGzUnwOpAA66PfS+Tcd7yUti0sYkUVkLk+IQjwzmUnLnC3lduw== X-Received: by 2002:a1c:6182:: with SMTP id v124mr5480888wmb.30.1589893924432; Tue, 19 May 2020 06:12:04 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id v205sm3941579wmg.11.2020.05.19.06.12.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 06:12:03 -0700 (PDT) From: luca.boccassi@gmail.com To: Fady Bader Cc: Andrew Rybchenko , dpdk stable Date: Tue, 19 May 2020 14:04:12 +0100 Message-Id: <20200519130549.112823-117-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200519130549.112823-1-luca.boccassi@gmail.com> References: <20200519125804.104349-1-luca.boccassi@gmail.com> <20200519130549.112823-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'mempool: remove inline functions from export list' has been queued to stable release 19.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/21/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 8426cebb497d7588ccb0ce7d717d8241466ef260 Mon Sep 17 00:00:00 2001 From: Fady Bader Date: Wed, 22 Apr 2020 10:37:44 +0300 Subject: [PATCH] mempool: remove inline functions from export list [ upstream commit 036d82365e7e26adc5061cae49778f96c431e697 ] The code didn't compile when using exported mempool functions under Windows. compilation error logs: rte_mempool_exports.def : error LNK2001: unresolved external symbol rte_mempool_cache_flush rte_mempool_exports.def : error LNK2001: unresolved external symbol rte_mempool_default_cache rte_mempool_exports.def : error LNK2001: unresolved external symbol rte_mempool_generic_get rte_mempool_exports.def : error LNK2001: unresolved external symbol rte_mempool_generic_put lib\librte_mempool.dll.a : fatal error LNK1120: 4 unresolved externals clang: error: linker command failed with exit code 1120 (use -v to see invocation) The cause was that there were some inline functions that were included in the export list. To solve this the functions, which are implemented in the header and shouldn't be exported, were removed from rte_mempool_version.map export list. Fixes: 4b5062755aa7 ("mempool: allow user-owned cache") Fixes: 656f2d3ede96 ("mempool: deprecate specific get and put functions") Signed-off-by: Fady Bader Acked-by: Andrew Rybchenko --- lib/librte_mempool/rte_mempool_version.map | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib/librte_mempool/rte_mempool_version.map b/lib/librte_mempool/rte_mempool_version.map index d002dfc46f..d67ed2e2b9 100644 --- a/lib/librte_mempool/rte_mempool_version.map +++ b/lib/librte_mempool/rte_mempool_version.map @@ -4,18 +4,14 @@ DPDK_20.0 { rte_mempool_audit; rte_mempool_avail_count; rte_mempool_cache_create; - rte_mempool_cache_flush; rte_mempool_cache_free; rte_mempool_calc_obj_size; rte_mempool_check_cookies; rte_mempool_contig_blocks_check_cookies; rte_mempool_create; rte_mempool_create_empty; - rte_mempool_default_cache; rte_mempool_dump; rte_mempool_free; - rte_mempool_generic_get; - rte_mempool_generic_put; rte_mempool_in_use_count; rte_mempool_list_dump; rte_mempool_lookup; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-19 14:04:49.248275586 +0100 +++ 0117-mempool-remove-inline-functions-from-export-list.patch 2020-05-19 14:04:44.388651490 +0100 @@ -1,8 +1,10 @@ -From 036d82365e7e26adc5061cae49778f96c431e697 Mon Sep 17 00:00:00 2001 +From 8426cebb497d7588ccb0ce7d717d8241466ef260 Mon Sep 17 00:00:00 2001 From: Fady Bader Date: Wed, 22 Apr 2020 10:37:44 +0300 Subject: [PATCH] mempool: remove inline functions from export list +[ upstream commit 036d82365e7e26adc5061cae49778f96c431e697 ] + The code didn't compile when using exported mempool functions under Windows. @@ -26,7 +28,6 @@ Fixes: 4b5062755aa7 ("mempool: allow user-owned cache") Fixes: 656f2d3ede96 ("mempool: deprecate specific get and put functions") -Cc: stable@dpdk.org Signed-off-by: Fady Bader Acked-by: Andrew Rybchenko @@ -35,7 +36,7 @@ 1 file changed, 4 deletions(-) diff --git a/lib/librte_mempool/rte_mempool_version.map b/lib/librte_mempool/rte_mempool_version.map -index 4fffd3ea41..695dd6e04f 100644 +index d002dfc46f..d67ed2e2b9 100644 --- a/lib/librte_mempool/rte_mempool_version.map +++ b/lib/librte_mempool/rte_mempool_version.map @@ -4,18 +4,14 @@ DPDK_20.0 {