From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC93DA0093 for ; Tue, 19 May 2020 15:14:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B588A1D90C; Tue, 19 May 2020 15:14:12 +0200 (CEST) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id D27D01D702 for ; Tue, 19 May 2020 15:14:11 +0200 (CEST) Received: by mail-wm1-f66.google.com with SMTP id m185so3505437wme.3 for ; Tue, 19 May 2020 06:14:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fLrmuSzgyY9S33p8qJw9/0oO2A8PiTwZl8mogwwd0lc=; b=qApz+AWYikWPyLp7IPuPyirC8kbPnQcenAmJT9Td3bMD+JE/RH0A06PnadZZvEDdmV ssP52oft6idz5a3Ibe185S72+riBNJUTTanyBSSUI5aJ+intRcPFH88tLikDzxSTxycu 98AEe3BLvMw/9nx0+bRQm0qTeUkTS6cvpziaRQyz6sD0gGFj+Y6CIkiMP+HnXbivRBWe f1J74pLjou/A98zGykPS54ThncXim5wODO0D3LAiBoYgew86AxyxVz9l305hLzzPLs81 ZG8KpSkGNra7novMgSqMiWaAfgUNb+xJVjkvHJ8TaRAJkr3jE5eRpDTsasN6OKayrC7J XDlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fLrmuSzgyY9S33p8qJw9/0oO2A8PiTwZl8mogwwd0lc=; b=doIhkwk26II/V3gvhhy+6bpcBnyBMEyds5mFSuMMCjMIMQ4Cemitig0PbJXPpPrpG3 gy2YUZAyiuc6BWQkMG3BUoFdYEEPLGf5hyG1okov5xRLZ4auhK4uy8AfoqM3Uo14TfFx I2kjBgGfhG+Q5o9S4VMO2UFFNNUzfhx6CobLl93RtLm/AQLYwd6wimdkYiSaKruUqckt Dkoe8oQA9m9X3MN/rQTxt/FnUknKax81X//+5ErAQMcwFEMjMPkeqeYzLiHYFIEWFeHX FBnVfL72WZfMDviGvosUWCUaDxj/UgyuMZ5G/TbaJCEbZSPRhgzbJkor5GGtanpoxG2J 791A== X-Gm-Message-State: AOAM532M5eRoIM2t4IyJyYShthYBIYGn+g6X5PJVbbmrpYBDWei/wwS5 Z9Z3NwcCTqN75ZxDCkUTXTA= X-Google-Smtp-Source: ABdhPJyGisthQZ2uHfBT/FaUaAshYvHSSBsGoxZacQtyt+YnDOJQeKzNwR75ghQf06/zBDSzUCt4Pg== X-Received: by 2002:a1c:a793:: with SMTP id q141mr5403676wme.70.1589894051541; Tue, 19 May 2020 06:14:11 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id h133sm4041318wmf.25.2020.05.19.06.14.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 06:14:10 -0700 (PDT) From: luca.boccassi@gmail.com To: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= Cc: Venky Venkatesh , dpdk stable Date: Tue, 19 May 2020 14:04:54 +0100 Message-Id: <20200519130549.112823-159-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200519130549.112823-1-luca.boccassi@gmail.com> References: <20200519125804.104349-1-luca.boccassi@gmail.com> <20200519130549.112823-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'event/dsw: avoid reusing previously recorded events' has been queued to stable release 19.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/21/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 9022ffe0031ffea6b711869627945e96760a7bc8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= Date: Mon, 4 May 2020 11:30:59 +0200 Subject: [PATCH] event/dsw: avoid reusing previously recorded events MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 52b66b2f208aea74e5fc3b004c1e14056bb22970 ] Avoid reusing recorded events when performing a migration, since this may make the migration selection logic pick an already-moved flow. Fixes: f6257b22e767 ("event/dsw: add load balancing") Reported-by: Venky Venkatesh Signed-off-by: Mattias Rönnblom --- drivers/event/dsw/dsw_event.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/event/dsw/dsw_event.c b/drivers/event/dsw/dsw_event.c index 10e44fd497..f3873c54e5 100644 --- a/drivers/event/dsw/dsw_event.c +++ b/drivers/event/dsw/dsw_event.c @@ -658,6 +658,9 @@ dsw_port_consider_migration(struct dsw_evdev *dsw, if (dsw->num_ports == 1) return; + if (seen_events_len < DSW_MAX_EVENTS_RECORDED) + return; + DSW_LOG_DP_PORT(DEBUG, source_port->id, "Considering migration.\n"); /* Randomize interval to avoid having all threads considering -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-19 14:04:50.967379207 +0100 +++ 0159-event-dsw-avoid-reusing-previously-recorded-events.patch 2020-05-19 14:04:44.500653521 +0100 @@ -1,4 +1,4 @@ -From 52b66b2f208aea74e5fc3b004c1e14056bb22970 Mon Sep 17 00:00:00 2001 +From 9022ffe0031ffea6b711869627945e96760a7bc8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= Date: Mon, 4 May 2020 11:30:59 +0200 Subject: [PATCH] event/dsw: avoid reusing previously recorded events @@ -6,11 +6,12 @@ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit +[ upstream commit 52b66b2f208aea74e5fc3b004c1e14056bb22970 ] + Avoid reusing recorded events when performing a migration, since this may make the migration selection logic pick an already-moved flow. Fixes: f6257b22e767 ("event/dsw: add load balancing") -Cc: stable@dpdk.org Reported-by: Venky Venkatesh Signed-off-by: Mattias Rönnblom @@ -19,17 +20,17 @@ 1 file changed, 3 insertions(+) diff --git a/drivers/event/dsw/dsw_event.c b/drivers/event/dsw/dsw_event.c -index 8323903736..e5e3597aae 100644 +index 10e44fd497..f3873c54e5 100644 --- a/drivers/event/dsw/dsw_event.c +++ b/drivers/event/dsw/dsw_event.c -@@ -821,6 +821,9 @@ dsw_port_consider_emigration(struct dsw_evdev *dsw, +@@ -658,6 +658,9 @@ dsw_port_consider_migration(struct dsw_evdev *dsw, if (dsw->num_ports == 1) return; + if (seen_events_len < DSW_MAX_EVENTS_RECORDED) + return; + - DSW_LOG_DP_PORT(DEBUG, source_port->id, "Considering emigration.\n"); + DSW_LOG_DP_PORT(DEBUG, source_port->id, "Considering migration.\n"); /* Randomize interval to avoid having all threads considering --