From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC690A0093 for ; Tue, 19 May 2020 15:14:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A5D621D702; Tue, 19 May 2020 15:14:44 +0200 (CEST) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 1CB0B1D925 for ; Tue, 19 May 2020 15:14:43 +0200 (CEST) Received: by mail-wm1-f67.google.com with SMTP id u1so2237537wmn.3 for ; Tue, 19 May 2020 06:14:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5MNhfdKyo+idVuSSWvVu4/pgripdWLJHErwbSbv8icw=; b=lXaZQyYFvByvXvo4J2xS6KSokXcZyzNmHxfP/8gEgaVWTh9VxavGsctDi1samKilfH dXZaHKzsXXKRFoe2LPD9DnmVVjyUMml6PeikGhZ4L+3dHTnjGhRLLUGWG78L04IyQ8r0 ILN0RlPY7VvG9y5+0YS7EPbT89+FStTLV1aA0xk/X1EuMSrKfziF3j60SUKO+Klgp03K ZHGmDTRDznZ1zww4srxd+tC7To2WzXU/zeBc9zkJdVTFHPZ4xzKLq9ofljIVcBkyvQyb YtfUQ5l/WY9RRpRS/xovcYm+wbqNwWLYAyEqNHSj9xjvb44f9ivFQNJVYRc+kvCEAhGd Mncw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5MNhfdKyo+idVuSSWvVu4/pgripdWLJHErwbSbv8icw=; b=smKaEJzgPVB9bUAw5oidDmLMmAU/7U42ns81aOzlqJf0Hc2vyBTn/6hR8R9QlaL+DD T7BIK3LgcsvZdW0EaRSr6EpEeFZAFXlGtOdRuluCeN+a9IxgpkQnS+pJTqS/9FkHdr1/ EmEkdvQuxX2pgfn546gxq7fgYtsyUxdbpB2bRCpaYOorsSbbBTKyiTX/ut2XKPvh4sXR 79DLuasBLBj77rVML2RiNgAFtKm8D5/jClul/5xz97t0PqV/4lkbVgVZIHq/1Kw0sjg3 2nzuu8FI85agZG0cT38XX/MjhD+pEeSfSnqndpCQt5laCO+L9WUc4m1UV3Q7TikbJJmn mMxg== X-Gm-Message-State: AOAM531v/w0YUWbX7j2Gw02mqNLeD3fJYiLUkQb/n6LrwNxPJQZsNkGf Y4hK/1bJ66nL+rmh4V/EMG9Tagi0V5GPcMbd X-Google-Smtp-Source: ABdhPJxlGXSqxkHfnCxQdMNbUnvq3/FGl37iLUrgK/ZjKFStXTHuE0iwk0UFRkVfeoi9oFcnA6sQJw== X-Received: by 2002:a1c:5fd4:: with SMTP id t203mr5701906wmb.175.1589894082841; Tue, 19 May 2020 06:14:42 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id d6sm22602901wra.63.2020.05.19.06.14.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 06:14:41 -0700 (PDT) From: luca.boccassi@gmail.com To: Ferruh Yigit Cc: Jerin Jacob , dpdk stable Date: Tue, 19 May 2020 14:05:04 +0100 Message-Id: <20200519130549.112823-169-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200519130549.112823-1-luca.boccassi@gmail.com> References: <20200519125804.104349-1-luca.boccassi@gmail.com> <20200519130549.112823-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'mempool/octeontx2: fix build for gcc O1 optimization' has been queued to stable release 19.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/21/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From c6f6f3d8e13cd78421fd7803599483ec6c59eaac Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Mon, 11 May 2020 17:07:23 +0100 Subject: [PATCH] mempool/octeontx2: fix build for gcc O1 optimization MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 0403b233ee4fd4857808fcc811054bc9109feb97 ] Can be reproduced with "make EXTRA_CFLAGS='-O1'" command using gcc (GCC) 9.3.1 20200408 (Red Hat 9.3.1-2) Build error: In file included from .../drivers/mempool/octeontx2/otx2_mempool.h:13, from .../drivers/mempool/octeontx2/otx2_mempool_ops.c:8: .../drivers/mempool/octeontx2/otx2_mempool_ops.c: In function ‘otx2_npa_alloc’: .../drivers/common/octeontx2/otx2_common.h:94:2: error: ‘aura_handle’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 94 | rte_log(RTE_LOG_DEBUG, otx2_logtype_ ## subsystem, \ | ^~~~~~~ .../drivers/mempool/octeontx2/otx2_mempool_ops.c:643:11: note: ‘aura_handle’ was declared here 643 | uint64_t aura_handle; | ^~~~~~~~~~~ This looks like false positive, assigning an initial value to 'aura_handle' to fix the build error. Signed-off-by: Ferruh Yigit Acked-by: Jerin Jacob --- drivers/mempool/octeontx2/otx2_mempool_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mempool/octeontx2/otx2_mempool_ops.c b/drivers/mempool/octeontx2/otx2_mempool_ops.c index ea4b1c45d2..18bdb0b4c4 100644 --- a/drivers/mempool/octeontx2/otx2_mempool_ops.c +++ b/drivers/mempool/octeontx2/otx2_mempool_ops.c @@ -637,10 +637,10 @@ static int otx2_npa_alloc(struct rte_mempool *mp) { uint32_t block_size, block_count; + uint64_t aura_handle = 0; struct otx2_npa_lf *lf; struct npa_aura_s aura; struct npa_pool_s pool; - uint64_t aura_handle; int rc; lf = otx2_npa_lf_obj_get(); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-19 14:04:51.400660538 +0100 +++ 0169-mempool-octeontx2-fix-build-for-gcc-O1-optimization.patch 2020-05-19 14:04:44.512653738 +0100 @@ -1,4 +1,4 @@ -From 0403b233ee4fd4857808fcc811054bc9109feb97 Mon Sep 17 00:00:00 2001 +From c6f6f3d8e13cd78421fd7803599483ec6c59eaac Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Mon, 11 May 2020 17:07:23 +0100 Subject: [PATCH] mempool/octeontx2: fix build for gcc O1 optimization @@ -6,6 +6,8 @@ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit +[ upstream commit 0403b233ee4fd4857808fcc811054bc9109feb97 ] + Can be reproduced with "make EXTRA_CFLAGS='-O1'" command using gcc (GCC) 9.3.1 20200408 (Red Hat 9.3.1-2) @@ -34,7 +36,7 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mempool/octeontx2/otx2_mempool_ops.c b/drivers/mempool/octeontx2/otx2_mempool_ops.c -index 162b7f01da..a14c9c5e94 100644 +index ea4b1c45d2..18bdb0b4c4 100644 --- a/drivers/mempool/octeontx2/otx2_mempool_ops.c +++ b/drivers/mempool/octeontx2/otx2_mempool_ops.c @@ -637,10 +637,10 @@ static int @@ -46,9 +48,9 @@ struct npa_aura_s aura; struct npa_pool_s pool; - uint64_t aura_handle; - size_t padding; int rc; + lf = otx2_npa_lf_obj_get(); -- 2.20.1