From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D79BEA0093 for ; Tue, 19 May 2020 15:14:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CA5901D702; Tue, 19 May 2020 15:14:46 +0200 (CEST) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 0D7F41D702 for ; Tue, 19 May 2020 15:14:44 +0200 (CEST) Received: by mail-wm1-f66.google.com with SMTP id g14so2426669wme.1 for ; Tue, 19 May 2020 06:14:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aqqoTDBk+WT/fIcnkEHUEK/vhwfvqiHPi5lMiP7/4aU=; b=Z+g07Rhn5FwWjhxwHaF8Ljk4AXilx8stDt6PAT3QUk7enpOxkPf2Zhd2tRiK3voz05 W1cCs+2qCryH7fzusXTPaC0g6836o2GJ3/ZIQuEhoUuN04BeJieWDrKP9ugxsk1ZEVzj 7SO5nwJxYiEZ6AaQMiHRYjrYKPu7jrq8N5Se31IvYvrB1eQudabtgYEFkogeh47ndTnt q+toE7duXInjUQdHfAfJuTlHqyfh6q1T5H8CeNBFiLxlaAoaDKeW/DGc0VQOk14bHEub U57PHBF0/agVFzUIez0piVK6a04SorUMjDzY6uv3q1rnvqiV1mJhMddVMD8j4m/EoF+C wuDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aqqoTDBk+WT/fIcnkEHUEK/vhwfvqiHPi5lMiP7/4aU=; b=tOZBEIVcn41uOLOdS38R2SsV56DqzxpwfOQC3gzzHgyq1G9os3rTEALgbhXZx6xI/X hDuk9cDb4/+dxcnyqpsgJk1cZ5Qgjk13bTdDvA96YQPIZ9jZu0Rq+136zE3m2gi5fEoT FA4JkYVNJDevTxyZh28J+4WtVa1vSZhdUPDcAU+ZJyaH0cfSPni6nbDUyhM0YkgX3hCN s4QPFTo/A4Zkt4DtvBTcu5Epl/0LPCrZ/1483KPggvMujkGxzcXQz8PRsuqYfCncnw7w L/C00zQ9gGpfAYp6sIF50CCzdCr7+IayR9UaTOe0U5MCa80UcmiqD7xlOoe+B3ffikzi rbMQ== X-Gm-Message-State: AOAM531AC5PqMe1Oxrr1/HxTlOgtsMYhKrFZDyCpaxdnW23u20CSa8Zz mcENZW/zXvIf7EbrKLrKPko= X-Google-Smtp-Source: ABdhPJwcc33g5aG+9HPUDUtrHvJLRpiXBEGqx1JPkycLArAHuv7hfeXF7owojmm5jXXt0ULE+vOuoA== X-Received: by 2002:a1c:b354:: with SMTP id c81mr5352861wmf.136.1589894083819; Tue, 19 May 2020 06:14:43 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id 205sm4188065wmc.12.2020.05.19.06.14.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 06:14:43 -0700 (PDT) From: luca.boccassi@gmail.com To: Ferruh Yigit Cc: Michal Krawczyk , dpdk stable Date: Tue, 19 May 2020 14:05:05 +0100 Message-Id: <20200519130549.112823-170-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200519130549.112823-1-luca.boccassi@gmail.com> References: <20200519125804.104349-1-luca.boccassi@gmail.com> <20200519130549.112823-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/ena: fix build for O1 optimization' has been queued to stable release 19.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/21/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 6fc3588de0e2085d1ac60aae506e61ba98ee80a5 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Mon, 11 May 2020 17:07:24 +0100 Subject: [PATCH] net/ena: fix build for O1 optimization MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 5f267cb01b41def2af37b8fa56828e75ae91add0 ] Can be reproduced with "make EXTRA_CFLAGS='-O1'" command using gcc (GCC) 9.3.1 20200408 (Red Hat 9.3.1-2) Build error: .../drivers/net/ena/ena_ethdev.c: In function ‘eth_ena_dev_init’: .../drivers/net/ena/ena_ethdev.c:1815:20: error: ‘wd_state’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 1815 | adapter->wd_state = wd_state; | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ This looks like false positive, fixing by assigning initial value to 'wd_state' variable. Signed-off-by: Ferruh Yigit Acked-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 36e9b4ad9e..e8753ce010 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -1674,7 +1674,7 @@ static int eth_ena_dev_init(struct rte_eth_dev *eth_dev) int rc; static int adapters_found; - bool wd_state; + bool wd_state = false; eth_dev->dev_ops = &ena_dev_ops; eth_dev->rx_pkt_burst = ð_ena_recv_pkts; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-19 14:04:51.443739711 +0100 +++ 0170-net-ena-fix-build-for-O1-optimization.patch 2020-05-19 14:04:44.512653738 +0100 @@ -1,4 +1,4 @@ -From 5f267cb01b41def2af37b8fa56828e75ae91add0 Mon Sep 17 00:00:00 2001 +From 6fc3588de0e2085d1ac60aae506e61ba98ee80a5 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Mon, 11 May 2020 17:07:24 +0100 Subject: [PATCH] net/ena: fix build for O1 optimization @@ -6,6 +6,8 @@ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit +[ upstream commit 5f267cb01b41def2af37b8fa56828e75ae91add0 ] + Can be reproduced with "make EXTRA_CFLAGS='-O1'" command using gcc (GCC) 9.3.1 20200408 (Red Hat 9.3.1-2) @@ -27,13 +29,13 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c -index c3fd3a4ac0..fbddc79f79 100644 +index 36e9b4ad9e..e8753ce010 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c -@@ -1756,7 +1756,7 @@ static int eth_ena_dev_init(struct rte_eth_dev *eth_dev) +@@ -1674,7 +1674,7 @@ static int eth_ena_dev_init(struct rte_eth_dev *eth_dev) int rc; + static int adapters_found; - bool disable_meta_caching; - bool wd_state; + bool wd_state = false;