From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 549EFA0093 for ; Tue, 19 May 2020 15:16:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 48DA21D97C; Tue, 19 May 2020 15:16:17 +0200 (CEST) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 047E91D970 for ; Tue, 19 May 2020 15:16:16 +0200 (CEST) Received: by mail-wr1-f67.google.com with SMTP id l17so15882992wrr.4 for ; Tue, 19 May 2020 06:16:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fxpDwQM0OepVNxZ5N/cC9GVlVapo3EjwFy79+Ppnx9M=; b=pzxtqk7BDHdYRlRMWY9wCgrL1aiMxOdukrisUpD5e5NnPgXu2sUSVu0wy9wON3vM87 BAl+39JFQNvSVTmn3XiJryVyEH6nPFspzAQHWadt3tY/n1TieXWt6sVHBR4j0xCOXjgY hmt+SiRtHRH1daQQn4/gHit4MAYvVaiRY5pdAdWBahIMfvcxUDrLxPJ+A9jJLnUQblR4 21/HKrFn65AyFUxlz20+AjIX3TBvIHf9Luptonh+4BXZYkG+vBupLne6JNQlBWB+jNpm lKBKLkPupJXzJj2e9zu4AmmOOCSk+tVPv2LAchrcgeEIiJpn0PGKsLMw3dirgSwu2IOd pQTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fxpDwQM0OepVNxZ5N/cC9GVlVapo3EjwFy79+Ppnx9M=; b=JNoEaApoNtqe5+lKLG+XXMQA4GGuwHpJFTjc/oyvVQAKYL6UJcnNKcYKsOJMQd+wHm 0rWlvjmHFV1+LcljJBru6Md3HE3oj+UqbymP0190DccLflFzUcdJCZLZWeu3+XZ6n6lK PozLt78acMhOp3MQZXXhZFKf9ksh1hPJXvwb99xMDXIQBVcbiv1S1wl5G5ObSpYeO0g1 zifccsE6VBuxr+QKCtxZC9piVuyRuZbNnZiJx6xoWfRHYXbKidx1zxHQ+p0ek07dlv68 l9Vpnj/eQbyCZFwyiD3il5E6VuvQjuO6xciwADJSD/uQBh3vZlT8AcqZ8vtrrY78wnPV KKPA== X-Gm-Message-State: AOAM5320zy6UhrUx3svBGaJ+FonJVqbm4LcU0izGSBKbKJtz6a/hwiqy Ne8gDeZojjLXhz/hVpIXpyJBYprkS9tYj90B X-Google-Smtp-Source: ABdhPJztAZZ9bf/FB+uqIPgOYKF4UhKJG65CB0Al9PfEUqfAeWqCAz7+JSFlz9zZ5E/IxeDiIjhlrw== X-Received: by 2002:adf:edc1:: with SMTP id v1mr25412412wro.125.1589894175770; Tue, 19 May 2020 06:16:15 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id d13sm3715018wmb.39.2020.05.19.06.16.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 06:16:15 -0700 (PDT) From: luca.boccassi@gmail.com To: Rohit Raj Cc: Hemant Agrawal , dpdk stable Date: Tue, 19 May 2020 14:05:34 +0100 Message-Id: <20200519130549.112823-199-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200519130549.112823-1-luca.boccassi@gmail.com> References: <20200519125804.104349-1-luca.boccassi@gmail.com> <20200519130549.112823-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/dpaa2: fix 10G port negotiation' has been queued to stable release 19.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/21/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From a71e30e6b072eb83febbe3a4fa282c518eee6788 Mon Sep 17 00:00:00 2001 From: Rohit Raj Date: Fri, 8 May 2020 18:32:03 +0530 Subject: [PATCH] net/dpaa2: fix 10G port negotiation [ upstream commit 7e6ecac281e4571d942889d6de687bb87623899b ] Fixed 10G port negotiation issue with another 10G/non 10G port. When running testpmd with 10G interfaces on 10BaseT interface on LS2088ARDB, the ports were showing link as down. This was identified to be caused by the setting of link as down during config. Also, the line rate was not being updated in device link params, thus having the incorrect link speed in status (as 0). Fixes: c5acbb5ea20e ("net/dpaa2: support link status event") Signed-off-by: Rohit Raj Acked-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index 2cde55e7cc..4fc550a885 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.c +++ b/drivers/net/dpaa2/dpaa2_ethdev.c @@ -553,9 +553,6 @@ dpaa2_eth_dev_configure(struct rte_eth_dev *dev) if (rx_offloads & DEV_RX_OFFLOAD_VLAN_FILTER) dpaa2_vlan_offload_set(dev, ETH_VLAN_FILTER_MASK); - /* update the current status */ - dpaa2_dev_link_update(dev, 0); - return 0; } @@ -1757,6 +1754,7 @@ dpaa2_dev_set_link_up(struct rte_eth_dev *dev) /* changing tx burst function to start enqueues */ dev->tx_pkt_burst = dpaa2_dev_tx; dev->data->dev_link.link_status = state.up; + dev->data->dev_link.link_speed = state.rate; if (state.up) DPAA2_PMD_INFO("Port %d Link is Up", dev->data->port_id); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-19 14:04:52.721428481 +0100 +++ 0199-net-dpaa2-fix-10G-port-negotiation.patch 2020-05-19 14:04:44.572654826 +0100 @@ -1,8 +1,10 @@ -From 7e6ecac281e4571d942889d6de687bb87623899b Mon Sep 17 00:00:00 2001 +From a71e30e6b072eb83febbe3a4fa282c518eee6788 Mon Sep 17 00:00:00 2001 From: Rohit Raj Date: Fri, 8 May 2020 18:32:03 +0530 Subject: [PATCH] net/dpaa2: fix 10G port negotiation +[ upstream commit 7e6ecac281e4571d942889d6de687bb87623899b ] + Fixed 10G port negotiation issue with another 10G/non 10G port. When running testpmd with 10G interfaces on 10BaseT interface @@ -14,7 +16,6 @@ thus having the incorrect link speed in status (as 0). Fixes: c5acbb5ea20e ("net/dpaa2: support link status event") -Cc: stable@dpdk.org Signed-off-by: Rohit Raj Acked-by: Hemant Agrawal