From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B13FA0093 for ; Tue, 19 May 2020 15:07:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 834591D603; Tue, 19 May 2020 15:07:22 +0200 (CEST) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id D3C651D65D for ; Tue, 19 May 2020 15:07:20 +0200 (CEST) Received: by mail-wm1-f66.google.com with SMTP id z72so3494571wmc.2 for ; Tue, 19 May 2020 06:07:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3XQAOOnFpzhFnVtcMuBttnb+D7a2VHl7scy5EGIvK8E=; b=I19AYcQLXIpEM1D67wap5HxCoBQC5Eot19XN+RvuwFDWqx2LCEGOj8EJkeAT6s7/L9 PpmmJ5QxvIF/XC7/V2kywSlFiv9aQykgYD0neDzaGaRIYIcr5TX+yRuwJhQhhKI2Pp2O 1WV6GvhNlfX6WbX/KhAocNIJfJTjWrp0Vu00LVeUjaMTehMrOHzj75ipd8iu8n2Oru1X DW0QWVJ5Bftij+ujNoxJGKD+kGZFPkHBSdX9dmPWlTmGZeLbNaPLt9+1H3b91iw1ndEp 88MraSLTiNXe/MDzac1KVpuPxJ1XfglloSl6nkvvRgqZp3rKFFF8ou5n7h9RDOYTDXwj RoMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3XQAOOnFpzhFnVtcMuBttnb+D7a2VHl7scy5EGIvK8E=; b=g1wKXleoIi4pCZ8qMcemoF+a4SeTnLIHgjgvoWZb2OEz7P/HSpl4OcM1PZNQN4XdMg jbBbjljXD7r0R7GI5Wy2u9lzpeBmTfuv9B2kEe4lL3YC8KYx3UkyR1RVHQV9cmAua110 et+oRpulC/1xPCnWewYQomYK2oQE4JIrJPOH1vuOXHWwQmef6PP/9PCD+GZXVY6IYf4V gPWtNmX80v0MzVy9Hjx8PCh+c9AxUG2HTn7+VpRN0XFs7Qd1FYQpwwpzwm+VN8i3enr+ uY9iwdHJ9j6oBO9UliHEaQLwwXGu9Zwl4bEbczizw6mYhDwyiEQ3LTGVGFV8xkYDiz6U p78A== X-Gm-Message-State: AOAM531e/fAJtOTpweQIAVmvfoD99HwknwcjI3ragQQhXZFmE22HGm9d EP1KJqG45hrsDChLWJkN9Yk= X-Google-Smtp-Source: ABdhPJw8FjbfEPZzmCApZARoAf29SMEmaY2P+Aq/S6bXCsGgn8pkmH4oj4v8SJy5ZV0l8BsRI17SJA== X-Received: by 2002:a7b:c767:: with SMTP id x7mr5630391wmk.181.1589893640615; Tue, 19 May 2020 06:07:20 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id g184sm4111491wmg.1.2020.05.19.06.07.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 06:07:20 -0700 (PDT) From: luca.boccassi@gmail.com To: Stephen Hemminger Cc: Ferruh Yigit , dpdk stable Date: Tue, 19 May 2020 14:02:43 +0100 Message-Id: <20200519130549.112823-28-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200519130549.112823-1-luca.boccassi@gmail.com> References: <20200519125804.104349-1-luca.boccassi@gmail.com> <20200519130549.112823-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/tap: do not use PMD log type' has been queued to stable release 19.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/21/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 64ca12ff65049c28e5130ef4705fee83f9f697ea Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Mon, 30 Mar 2020 21:41:52 -0700 Subject: [PATCH] net/tap: do not use PMD log type [ upstream commit bd3b90d53a62c2147f747dfaf863117f39099a32 ] The PMD logtype is legacy and drivers should use their own logtype. Fixes: 050316a88313 ("net/tap: support TSO (TCP Segment Offload)") Signed-off-by: Stephen Hemminger Reviewed-by: Ferruh Yigit --- drivers/net/tap/rte_eth_tap.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 05470a2115..2c9fb76b63 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -778,7 +778,7 @@ apply: case SIOCSIFMTU: break; default: - RTE_LOG(WARNING, PMD, "%s: ioctl() called with wrong arg\n", + TAP_LOG(WARNING, "%s: ioctl() called with wrong arg", pmd->name); return -EINVAL; } @@ -1301,7 +1301,9 @@ tap_gso_ctx_setup(struct rte_gso_ctx *gso_ctx, struct rte_eth_dev *dev) SOCKET_ID_ANY); if (!mp) { struct pmd_internals *pmd = dev->data->dev_private; - RTE_LOG(DEBUG, PMD, "%s: failed to create mbuf pool for device %s\n", + + TAP_LOG(ERR, + "%s: failed to create mbuf pool for device %s\n", pmd->name, dev->device->name); return -1; } -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-19 14:04:45.753242798 +0100 +++ 0028-net-tap-do-not-use-PMD-log-type.patch 2020-05-19 14:04:44.164647430 +0100 @@ -1,12 +1,13 @@ -From bd3b90d53a62c2147f747dfaf863117f39099a32 Mon Sep 17 00:00:00 2001 +From 64ca12ff65049c28e5130ef4705fee83f9f697ea Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Mon, 30 Mar 2020 21:41:52 -0700 Subject: [PATCH] net/tap: do not use PMD log type +[ upstream commit bd3b90d53a62c2147f747dfaf863117f39099a32 ] + The PMD logtype is legacy and drivers should use their own logtype. Fixes: 050316a88313 ("net/tap: support TSO (TCP Segment Offload)") -Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger Reviewed-by: Ferruh Yigit