From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01CD3A0093 for ; Tue, 19 May 2020 15:08:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ED24C1D603; Tue, 19 May 2020 15:08:21 +0200 (CEST) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 7F14B1D603 for ; Tue, 19 May 2020 15:08:20 +0200 (CEST) Received: by mail-wm1-f67.google.com with SMTP id f134so3009871wmf.1 for ; Tue, 19 May 2020 06:08:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=j4biwvsXbliIYGgflhLMwg83zhmPk+nYH55+b1JiT8c=; b=fkXwVMCRcDHaguo0hHUFmE0KSqGGqL5LpaCFgh5cP1ktU2rUFvr0q2XMEYAksodDEf H3GNOnKx84xupnz4otwTMQBWoYxebIGHPYe1HuUGsuVtrydGQUKmhjyOX04egBXElIVL B0NzOhp07y4Sq2avKn9HYdCHwzuzBL/iivrIvawwgHNRJoPyQfOp3V+A+M6er3LABXJI vuqDVhUMVuofvdhK7pOPHhQbNooPUWlhiFEvOchCENEWH4shlO2Fz5SzgOp9PagjiN5c 4xEo73zlox+Xwxqp+D3qBs49pbRT8UFMMsyh5tCBnUhThrEaEuVzzpMRFW4qifDpW8/F Ok/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=j4biwvsXbliIYGgflhLMwg83zhmPk+nYH55+b1JiT8c=; b=URmWeWqsY046ATT5QeUX6l3jNLss4L9m9u+Jn5mjBw+w7D6u1zieComgpyBFc4Cbe7 D1qyUdA/IpTg91px9zdz+EcTkneZezbyfSWBBsXNdWeyfT5GcGCgLw7lGCF8F0D+kcSg WGaxDr21ReqCh2KvitqvGzvSp6AJue3a1VS73IQN6SdlrXGhoLWP6FkFNUpIYOOfUFYj 3VFfddV9toq0x0B5M2zYvBCYfHZdzVcZOdWuJ3qAGLQa7UhsBmaD8oTJVOYovtILi4v9 FXWJXL5nTUbxCGP6XC3vK3hzb0U+EyVNBUd42YMRQcbdIRMsseVwz8yGz72gII1RmKIx 7SRQ== X-Gm-Message-State: AOAM533UwSmfAiUYELroH2wyOPqtoZQUsLDpTkmvULp9ABpvfHkK9EKp CgPmzsGSdnQKgSNNUQP1gMaHvurmkN0pMQOE X-Google-Smtp-Source: ABdhPJxLhPJG70pVTS7DZzE4qgUgpbgfbAoOxOgqrfqYE5VVCpWPOBNz922i7t0YGe0ZP5b/N2qyUg== X-Received: by 2002:a1c:2289:: with SMTP id i131mr5535024wmi.111.1589893700202; Tue, 19 May 2020 06:08:20 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id c25sm3689914wmb.44.2020.05.19.06.08.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 06:08:19 -0700 (PDT) From: luca.boccassi@gmail.com To: Stephen Hemminger Cc: dpdk stable Date: Tue, 19 May 2020 14:03:01 +0100 Message-Id: <20200519130549.112823-46-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200519130549.112823-1-luca.boccassi@gmail.com> References: <20200519125804.104349-1-luca.boccassi@gmail.com> <20200519130549.112823-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/netvsc: remove process event optimization' has been queued to stable release 19.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/21/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 62ec946eec4fefabcb4bf2314f78579edf29fe8c Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Tue, 31 Mar 2020 10:14:01 -0700 Subject: [PATCH] net/netvsc: remove process event optimization [ upstream commit dfd3f0fce8bd64182b984b4a9226f2d23c44b2d5 ] Remove unlocked check for data in receive ring. This check is not safe because of missing barriers etc. Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_rxtx.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c index 32c03e3da0..e8df846042 100644 --- a/drivers/net/netvsc/hn_rxtx.c +++ b/drivers/net/netvsc/hn_rxtx.c @@ -969,10 +969,6 @@ uint32_t hn_process_events(struct hn_data *hv, uint16_t queue_id, rxq = queue_id == 0 ? hv->primary : dev->data->rx_queues[queue_id]; - /* If no pending data then nothing to do */ - if (rte_vmbus_chan_rx_empty(rxq->chan)) - return 0; - /* * Since channel is shared between Rx and TX queue need to have a lock * since DPDK does not force same CPU to be used for Rx/Tx. -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-19 14:04:46.415451914 +0100 +++ 0046-net-netvsc-remove-process-event-optimization.patch 2020-05-19 14:04:44.184647792 +0100 @@ -1,13 +1,14 @@ -From dfd3f0fce8bd64182b984b4a9226f2d23c44b2d5 Mon Sep 17 00:00:00 2001 +From 62ec946eec4fefabcb4bf2314f78579edf29fe8c Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Tue, 31 Mar 2020 10:14:01 -0700 Subject: [PATCH] net/netvsc: remove process event optimization +[ upstream commit dfd3f0fce8bd64182b984b4a9226f2d23c44b2d5 ] + Remove unlocked check for data in receive ring. This check is not safe because of missing barriers etc. Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") -Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger ---