From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3D44A0093 for ; Tue, 19 May 2020 15:10:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 99D711D6DF; Tue, 19 May 2020 15:10:16 +0200 (CEST) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id D31C81D6DF for ; Tue, 19 May 2020 15:10:15 +0200 (CEST) Received: by mail-wr1-f68.google.com with SMTP id l17so15859859wrr.4 for ; Tue, 19 May 2020 06:10:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LXdWfCIBQ5MXcEKANwnmzfIzuxYJtXKChqC5YIhoFaM=; b=QbSEyC3MS65EpEt3kC/kJeU59CpECULX2qzfKmikONln7YK5JDvMw3e/A16Cy24AIo WQBnMcGkB81tiX8I1bOO8div6uC5pdysLaLOEtLXblEEywEaTv/mhvIfulVJ49fq25f8 EPs0xg/ZwIaysq0cecxxccLwFuby1c2gSxb2rKKjg1D/pq0SqRD34S0Z6MWoOZaRpJTv NSByzqZxsZsbvRLE/nP1kWQ4LXFScDsJRg7WTstOvIjX3F7dtHppnJ8WZ3f4cl8KsgKU XR7JAnU1vVmvoQWMP9OlmfiC0VCHIkKo+tJ6QycVeHA3cjj3w/2oLC4hG50DWSBtySCj Ui6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LXdWfCIBQ5MXcEKANwnmzfIzuxYJtXKChqC5YIhoFaM=; b=FY6e9GC76VuvBKj3crzkgc6uqT76Fgj9UcITQ0Zv45l6DnVwsAgXpJapVQR3De9Nz0 gHNXusoCURVPVEEOE4lyZlWwTFQomCtO4eYMMnSVJGotQvB8L4XOSn/s2EDUgXY0AU/O MFLVRDsuB5y8ODTT4Md6GtIoIURNJ4WHuDurLx1cicJP17u7VSB+bggVVqdVGB4k3ciM Y8UCD421U/tM88jWdzi93eIwk3Ejcr+ozAcxxbykSgCfWrdfLorVwdk0FSQESoFxVkyn G6c/023PlmCM6W8iG1ANU+RscFN5ynzeFqmJ23ZFMkc2u8rVgYjxzm6X10IBflVXtt95 NWBQ== X-Gm-Message-State: AOAM531Pkk0DeAOeiDvyAISYff23fa6hdJUlMBq9zxDaAbx1rjStGPel Ma+DXuto6lfggpTsiYKpefdvGZ692I+byDDP X-Google-Smtp-Source: ABdhPJxX5PHsnQJKN3NIRramXNnjYGBzo4otwQEepd+v5Goo07PXye+Rbji28MZpQN+bqiTf48PzMQ== X-Received: by 2002:adf:8b98:: with SMTP id o24mr26506262wra.156.1589893815539; Tue, 19 May 2020 06:10:15 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id b65sm4056380wmc.30.2020.05.19.06.10.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 06:10:14 -0700 (PDT) From: luca.boccassi@gmail.com To: Gavin Hu Cc: Jerin Jacob , dpdk stable Date: Tue, 19 May 2020 14:03:39 +0100 Message-Id: <20200519130549.112823-84-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200519130549.112823-1-luca.boccassi@gmail.com> References: <20200519125804.104349-1-luca.boccassi@gmail.com> <20200519130549.112823-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/i40e: relax barrier in Tx for NEON' has been queued to stable release 19.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/21/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 31d1b373d5ab079273f9f5b164b2d5720081b39e Mon Sep 17 00:00:00 2001 From: Gavin Hu Date: Tue, 14 Apr 2020 00:40:24 +0800 Subject: [PATCH] net/i40e: relax barrier in Tx for NEON [ upstream commit 6b50c489a3bb1d82e2549ae2f1e2c46961572c27 ] To keep ordering of mixed accesses, 'DMB OSH' is sufficient. 'DSB' inside the I40E_PCI_REG_WRITE is overkill.[1] This patch fixes by replacing with just sufficient barriers in the normal PMD and vPMD. It showed 7% performance uplift on ThunderX2 and 4% on Arm N1SDP. The test case is the RFC2544 zero-loss test running testpmd. [1] http://inbox.dpdk.org/dev/CALBAE1M-ezVWCjqCZDBw+MMDEC4O9 qf0Kpn89EMdGDajepKoZQ@mail.gmail.com Fixes: ae0eb310f253 ("net/i40e: implement vector PMD for ARM") Signed-off-by: Gavin Hu Acked-by: Jerin Jacob --- drivers/net/i40e/i40e_rxtx_vec_neon.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c b/drivers/net/i40e/i40e_rxtx_vec_neon.c index deb185fe2f..4376d8911c 100644 --- a/drivers/net/i40e/i40e_rxtx_vec_neon.c +++ b/drivers/net/i40e/i40e_rxtx_vec_neon.c @@ -72,8 +72,9 @@ i40e_rxq_rearm(struct i40e_rx_queue *rxq) rx_id = (uint16_t)((rxq->rxrearm_start == 0) ? (rxq->nb_rx_desc - 1) : (rxq->rxrearm_start - 1)); + rte_cio_wmb(); /* Update the tail pointer on the NIC */ - I40E_PCI_REG_WRITE(rxq->qrx_tail, rx_id); + I40E_PCI_REG_WRITE_RELAXED(rxq->qrx_tail, rx_id); } static inline void @@ -564,7 +565,8 @@ i40e_xmit_fixed_burst_vec(void *tx_queue, struct rte_mbuf **tx_pkts, txq->tx_tail = tx_id; - I40E_PCI_REG_WRITE(txq->qtx_tail, txq->tx_tail); + rte_cio_wmb(); + I40E_PCI_REG_WRITE_RELAXED(txq->qtx_tail, tx_id); return nb_pkts; } -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-19 14:04:47.870108580 +0100 +++ 0084-net-i40e-relax-barrier-in-Tx-for-NEON.patch 2020-05-19 14:04:44.252649025 +0100 @@ -1,8 +1,10 @@ -From 6b50c489a3bb1d82e2549ae2f1e2c46961572c27 Mon Sep 17 00:00:00 2001 +From 31d1b373d5ab079273f9f5b164b2d5720081b39e Mon Sep 17 00:00:00 2001 From: Gavin Hu Date: Tue, 14 Apr 2020 00:40:24 +0800 Subject: [PATCH] net/i40e: relax barrier in Tx for NEON +[ upstream commit 6b50c489a3bb1d82e2549ae2f1e2c46961572c27 ] + To keep ordering of mixed accesses, 'DMB OSH' is sufficient. 'DSB' inside the I40E_PCI_REG_WRITE is overkill.[1] @@ -16,7 +18,6 @@ qf0Kpn89EMdGDajepKoZQ@mail.gmail.com Fixes: ae0eb310f253 ("net/i40e: implement vector PMD for ARM") -Cc: stable@dpdk.org Signed-off-by: Gavin Hu Acked-by: Jerin Jacob @@ -25,7 +26,7 @@ 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c b/drivers/net/i40e/i40e_rxtx_vec_neon.c -index d7d6decafd..8b99354a5f 100644 +index deb185fe2f..4376d8911c 100644 --- a/drivers/net/i40e/i40e_rxtx_vec_neon.c +++ b/drivers/net/i40e/i40e_rxtx_vec_neon.c @@ -72,8 +72,9 @@ i40e_rxq_rearm(struct i40e_rx_queue *rxq)