From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 094A8A00BE for ; Fri, 22 May 2020 11:20:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DAA071D948; Fri, 22 May 2020 11:20:00 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 891EF1D930; Fri, 22 May 2020 11:19:57 +0200 (CEST) IronPort-SDR: nLFD6KG0Aj7/0BvCFActLiXvwDRE8PmcTW+eef+CVa/QMAapNE5yBsRapHc8fmF68xwA1hLbIJ XoEHWlM7xYFA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2020 02:19:56 -0700 IronPort-SDR: lsqBcom/6zPCmrNbeYXTWHWOWdxfuRu54nHZT4lkWFeqjR07iD29xPIpvxIHh77QZw68b+Ql2Y Lxo23zPG4tpA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,421,1583222400"; d="scan'208";a="467120393" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.116.183]) by fmsmga005.fm.intel.com with ESMTP; 22 May 2020 02:19:55 -0700 Date: Fri, 22 May 2020 17:11:13 +0800 From: Ye Xiaolong To: Guinan Sun Cc: dev@dpdk.org, Zhao1 Wei , stable@dpdk.org Message-ID: <20200522091113.GB82475@intel.com> References: <20200522055955.30712-1-guinanx.sun@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200522055955.30712-1-guinanx.sun@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-stable] [PATCH] net/ixgbe: fix MACsec private API X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 05/22, Guinan Sun wrote: >The driver type need to be checked in private API. >The patch fixes the issue. > >Fixes: 50556c88104c ("net/ixgbe: fix MACsec setting") >Cc: stable@dpdk.org > >Signed-off-by: Guinan Sun >--- > drivers/net/ixgbe/rte_pmd_ixgbe.c | 6 ++++++ > 1 file changed, 6 insertions(+) > >diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.c b/drivers/net/ixgbe/rte_pmd_ixgbe.c >index 8bcaded6e..9bff557f9 100644 >--- a/drivers/net/ixgbe/rte_pmd_ixgbe.c >+++ b/drivers/net/ixgbe/rte_pmd_ixgbe.c >@@ -522,6 +522,9 @@ rte_pmd_ixgbe_macsec_enable(uint16_t port, uint8_t en, uint8_t rp) > > dev = &rte_eth_devices[port]; > >+ if (!is_ixgbe_supported(dev)) >+ return -ENOTSUP; >+ > macsec_setting.offload_en = 1; > macsec_setting.encrypt_en = en; > macsec_setting.replayprotect_en = rp; >@@ -542,6 +545,9 @@ rte_pmd_ixgbe_macsec_disable(uint16_t port) > > dev = &rte_eth_devices[port]; > >+ if (!is_ixgbe_supported(dev)) >+ return -ENOTSUP; >+ > ixgbe_dev_macsec_setting_reset(dev); > > ixgbe_dev_macsec_register_disable(dev); >-- >2.17.1 > Applied to dpdk-next-net-intel, Thanks.