From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 121CFA00BE for ; Fri, 22 May 2020 11:27:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A52011D95B; Fri, 22 May 2020 11:27:02 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id A950E1D91B; Fri, 22 May 2020 11:27:00 +0200 (CEST) IronPort-SDR: bCcxhvzGpIa0TWJ1fUqvgk7HfSfInGBOPlxZcxGoDYirq37hy7z0j3bzZgxxdQ4WNtsMhKstBF YG6ruWEh5nOA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2020 02:26:59 -0700 IronPort-SDR: tef/6xNS0hGc/qK/Al18etroyKhmMEOkrWzCgbZzi/J0TRdVauZmk+fGcXzKb4Fzi29W1cuvtr piYJPe3TZ6DA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,421,1583222400"; d="scan'208";a="255548683" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.116.183]) by fmsmga008.fm.intel.com with ESMTP; 22 May 2020 02:26:58 -0700 Date: Fri, 22 May 2020 17:18:16 +0800 From: Ye Xiaolong To: Wei Zhao Cc: dev@dpdk.org, stable@dpdk.org, beilei.xing@intel.com, jia.guo@intel.com Message-ID: <20200522091816.GD82475@intel.com> References: <20200519071652.26537-1-wei.zhao1@intel.com> <20200521080306.17404-1-wei.zhao1@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200521080306.17404-1-wei.zhao1@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-stable] [PATCH v2] net/i40e: fix flow FDIR enable issue X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 05/21, Wei Zhao wrote: >When we flush flow FDIR, all queues are disabled for FDIR. >If FDIR rule is created again, then the flow list is empty, >as it is the first time to create rule after flush fdir filter, >so we need to enable FDIR for all queues. And also, disable FDIR >for queues should be done in function i40e_flow_flush_fdir_filter(). > >Fixes: 1491f63c7559 ("net/i40e: fix flush of flow director filter") >Fixes: 6ae9b2b5e8c2 ("net/i40e: cache flow director enable value in Rx queue") >Cc: stable@dpdk.org > >Signed-off-by: Wei Zhao > >--- > >v2: >update log info >--- > drivers/net/i40e/i40e_flow.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > >diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c >index 25c77e7aa..8f8df6fae 100644 >--- a/drivers/net/i40e/i40e_flow.c >+++ b/drivers/net/i40e/i40e_flow.c >@@ -3462,6 +3462,10 @@ i40e_flow_parse_fdir_filter(struct rte_eth_dev *dev, > } > } > >+ /* If create the first fdir rule, enable fdir check for rx queues */ >+ if (TAILQ_EMPTY(&pf->fdir.fdir_list)) >+ i40e_fdir_rx_proc_enable(dev, 1); >+ > return 0; > err: > i40e_fdir_teardown(pf); >@@ -5330,9 +5334,6 @@ i40e_flow_flush(struct rte_eth_dev *dev, struct rte_flow_error *error) > return -rte_errno; > } > >- /* Disable FDIR processing as all FDIR rules are now flushed */ >- i40e_fdir_rx_proc_enable(dev, 0); >- > return ret; > } > >@@ -5368,6 +5369,9 @@ i40e_flow_flush_fdir_filter(struct i40e_pf *pf) > for (pctype = I40E_FILTER_PCTYPE_NONF_IPV4_UDP; > pctype <= I40E_FILTER_PCTYPE_L2_PAYLOAD; pctype++) > pf->fdir.inset_flag[pctype] = 0; >+ >+ /* Disable FDIR processing as all FDIR rules are now flushed */ >+ i40e_fdir_rx_proc_enable(dev, 0); > } > > return ret; >-- >2.19.1 > Applied to dpdk-next-net-intel, Thanks.