From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2680A0093 for ; Fri, 22 May 2020 11:40:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DBB4A1D969; Fri, 22 May 2020 11:40:32 +0200 (CEST) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by dpdk.org (Postfix) with ESMTP id C3E611D969 for ; Fri, 22 May 2020 11:40:31 +0200 (CEST) Received: by mail-wm1-f43.google.com with SMTP id f13so8045082wmc.5 for ; Fri, 22 May 2020 02:40:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pEq4a7RPDmawnYg0B5W/oZHJVusT5swoclzjHF8Ise4=; b=PAfok69k24kMZEFOVHHmu0sEYwwW2cPuhDcHM0LNAanv8yajBC2dokuo0lWCx6Kl/e 6QUcl/L9agZpBqX3zn4FXc3TrXb/kUPOFIduIByRsMcVfX0OssyOzg8L3YqqNDiKjxN3 Z3t3IYwgezlOVqC0zUR+Tp8XTOMB0TP1tiJxi6xoGKplPRHhoz4fNKgKu6CuBB81XwGu WMk8Of+ryDa9gCq4dYT3gWaMvtQMBncrxU1yi9Dl3lVeX1sCyTy111sxIYZFEAuyYun2 cfz8oXvjQre+OsyN10SoL1Wo+rQFyytHoXdGW/IiPMwbp9Mqq+DpRxb0WAfrWUhsAFZI HrdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pEq4a7RPDmawnYg0B5W/oZHJVusT5swoclzjHF8Ise4=; b=hRgPQFCaRAeoYFIhM5Uf3lks7DUiBr5YJUK1ro+RXmYHqZRYM9yWb3haQj1xN0COvN Yy18xN9+hYCjVzoDebmA+7STRj2eINn4zkiJfj90Ovjway29a6P+lSrdmgffxC08uEuF 5fdsV4P342bHj0nZMsQzM59NRqNUHY39LrIu/jxRL2QFBnrWwBo4iEUSMEt8y8kHpxWd at9UHlC2AGLYPPpPN5xhAv5XnVgfBT9WbWuCXsWECHPGQiU7cksYECWIfXmEaY+d24go hyCNGIyIecsw5urbXntZyprQsk/7UzkoTtAX3stwBNErIWw4V+keArTsCnXZ2TfjE71B X5Dw== X-Gm-Message-State: AOAM530EMfO+B6uiPbb8Ui01IV8ZUuyGG2nZL6CVWaTMIJssFy+oElhX CRZ8hJa4y/5u2nNIimf8Spg= X-Google-Smtp-Source: ABdhPJxdHWAaq0vvYizpErCjVMkPWuBpbaK1rTbhhGXso5fOM9LenzDDBWD1Z8QJ1qO61WBG5oHA6A== X-Received: by 2002:a1c:9e52:: with SMTP id h79mr12592573wme.84.1590140431451; Fri, 22 May 2020 02:40:31 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id z132sm10065997wmc.29.2020.05.22.02.40.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2020 02:40:30 -0700 (PDT) From: luca.boccassi@gmail.com To: Pavan Nikhilesh Cc: Jerin Jacob , dpdk stable Date: Fri, 22 May 2020 10:39:41 +0100 Message-Id: <20200522094022.1025696-2-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200522094022.1025696-1-luca.boccassi@gmail.com> References: <20200519130549.112823-214-luca.boccassi@gmail.com> <20200522094022.1025696-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'app/eventdev: check Tx adapter service ID' has been queued to stable release 19.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/24/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 053c7ff9b5bc6166d3456098ac206a566d2d763b Mon Sep 17 00:00:00 2001 From: Pavan Nikhilesh Date: Thu, 14 May 2020 01:52:48 +0530 Subject: [PATCH] app/eventdev: check Tx adapter service ID [ upstream commit 40984bf253e1bccea72a38b2a0edd7c16ea22831 ] Fix unchecked return values reported by coverity. Coverity issue: 357755 Fixes: 032a965a8f1d ("app/eventdev: support Tx adapter") Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- app/test-eventdev/test_pipeline_common.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c index fa91bf2290..126e2165a3 100644 --- a/app/test-eventdev/test_pipeline_common.c +++ b/app/test-eventdev/test_pipeline_common.c @@ -385,12 +385,16 @@ pipeline_event_tx_adapter_setup(struct evt_options *opt, if (!(cap & RTE_EVENT_ETH_TX_ADAPTER_CAP_INTERNAL_PORT)) { uint32_t service_id = -1U; - rte_event_eth_tx_adapter_service_id_get(consm, - &service_id); + ret = rte_event_eth_tx_adapter_service_id_get(consm, + &service_id); + if (ret != -ESRCH && ret != 0) { + evt_err("Failed to get Tx adptr service ID"); + return ret; + } ret = evt_service_setup(service_id); if (ret) { evt_err("Failed to setup service core" - " for Tx adapter\n"); + " for Tx adapter"); return ret; } } -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-22 10:37:39.328432193 +0100 +++ 0002-app-eventdev-check-Tx-adapter-service-ID.patch 2020-05-22 10:37:39.052411351 +0100 @@ -1,13 +1,14 @@ -From 40984bf253e1bccea72a38b2a0edd7c16ea22831 Mon Sep 17 00:00:00 2001 +From 053c7ff9b5bc6166d3456098ac206a566d2d763b Mon Sep 17 00:00:00 2001 From: Pavan Nikhilesh Date: Thu, 14 May 2020 01:52:48 +0530 Subject: [PATCH] app/eventdev: check Tx adapter service ID +[ upstream commit 40984bf253e1bccea72a38b2a0edd7c16ea22831 ] + Fix unchecked return values reported by coverity. Coverity issue: 357755 Fixes: 032a965a8f1d ("app/eventdev: support Tx adapter") -Cc: stable@dpdk.org Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob @@ -16,10 +17,10 @@ 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c -index 84c42b33ce..17088b1b48 100644 +index fa91bf2290..126e2165a3 100644 --- a/app/test-eventdev/test_pipeline_common.c +++ b/app/test-eventdev/test_pipeline_common.c -@@ -392,12 +392,16 @@ pipeline_event_tx_adapter_setup(struct evt_options *opt, +@@ -385,12 +385,16 @@ pipeline_event_tx_adapter_setup(struct evt_options *opt, if (!(cap & RTE_EVENT_ETH_TX_ADAPTER_CAP_INTERNAL_PORT)) { uint32_t service_id = -1U;