From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94506A0093 for ; Fri, 22 May 2020 11:41:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8BA221D966; Fri, 22 May 2020 11:41:35 +0200 (CEST) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 30CE31D96A for ; Fri, 22 May 2020 11:41:34 +0200 (CEST) Received: by mail-wm1-f68.google.com with SMTP id w64so9166725wmg.4 for ; Fri, 22 May 2020 02:41:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OWKvxAEpGlO70SJ94gYuEIReDTruDcvE3vYWSXx+V2M=; b=ev++zQmVLA3XrsypXRnIy1rOE/NOK0kF9zx/rBGLr+q1hz/Mmtsfk8MIo34db5zLM3 3JLFp63RqHtLG+zLAnKkdBr64QbqtZYJ6qxjxrueagBSgnPMWewSNeVoW8anjk7Eg6/U 6Y4+7a8E6KpP7lyIzyN8NwfV8eBJMWxUmGvl+AwwE3k47b4amdWwN8aPqiQABhm/1KpK YtGEpVcaOGoH18stDXL2FvJDWbrtg2sk8UHOr6m0Ur7oSYEsvcgUTKR83KsTmLKQwGBz tagVB7cTGDJp+GbW9wlnX4kfEwOvZZZHyTTmttDaCDd0H9t6+UBVVZ6JmVCvRrCfOkwY tsXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OWKvxAEpGlO70SJ94gYuEIReDTruDcvE3vYWSXx+V2M=; b=H381B+ilHQT0t3dUQnjzI5Hn8uoa68f5kCwFS/h+j6SUh+UA9LdkTqk59xrFvhEuWC OlhYJq6VsJqK4KGDpmzf934zXRQnHjK5gi5Zpid/tatL9tZnbR+F/Poe5b+wpTiVzmBu yTXgG51jZxuI3RXw84GKGhscuwQLWGEE1WC/oBR77nn/y91+ynENN8okMMrUihJR9m0O GzqLGdWhWEC1LPCkBrqqEwvGBdDlcBPHf4Z5wiV1Jwik04eiGrmbv4rYOXc8i7VzWYtQ fl4Nrg37c57hBr1HJjv7tb/GHyocNLqdmmBtwutthBmxx1rbIjBVO4KY7Xn4kpg0ekI9 qJyg== X-Gm-Message-State: AOAM530hQ0M8TuQwFcdcE6YU+vpJdaq6iH6tVgWrowcONtmAdFpklNon W2LiRC5g3Wi0IhrSm0hyxrtp7f5W0iCVBA== X-Google-Smtp-Source: ABdhPJzxI/pLOoxK9dhKCkguCFJwkhRwPu2cyLWAhnnKhm9DTqNVI/MYYCNG6yAkUUQXz+WD9CLFbA== X-Received: by 2002:a7b:c3d2:: with SMTP id t18mr12578099wmj.100.1590140493852; Fri, 22 May 2020 02:41:33 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id h27sm10243912wrc.46.2020.05.22.02.41.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2020 02:41:33 -0700 (PDT) From: luca.boccassi@gmail.com To: Ajit Khaparde Cc: Somnath Kotur , Kalesh AP , dpdk stable Date: Fri, 22 May 2020 10:40:01 +0100 Message-Id: <20200522094022.1025696-22-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200522094022.1025696-1-luca.boccassi@gmail.com> References: <20200519130549.112823-214-luca.boccassi@gmail.com> <20200522094022.1025696-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/bnxt: fix error log for command timeout' has been queued to stable release 19.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/24/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 2109b14aa9bc684000a5521f476ec46a51bad239 Mon Sep 17 00:00:00 2001 From: Ajit Khaparde Date: Thu, 14 May 2020 23:37:34 -0700 Subject: [PATCH] net/bnxt: fix error log for command timeout [ upstream commit 4939f374ad369b4b15ba17a186bd17bf736371f0 ] Log the command sequence number to aid debug in case of a FW command timeout. Fixes: 804e746c7b73 ("net/bnxt: add hardware resource manager init code") Signed-off-by: Ajit Khaparde Reviewed-by: Somnath Kotur Reviewed-by: Kalesh AP --- drivers/net/bnxt/bnxt_hwrm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 7de5b88f0c..9dad6bd319 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -164,8 +164,9 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg, rte_cpu_to_le_16(req->req_type) == HWRM_VER_GET) return -ETIMEDOUT; - PMD_DRV_LOG(ERR, "Error(timeout) sending msg 0x%04x\n", - req->req_type); + PMD_DRV_LOG(ERR, + "Error(timeout) sending msg 0x%04x, seq_id %d\n", + req->req_type, req->seq_id); return -ETIMEDOUT; } return 0; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-22 10:37:40.061006253 +0100 +++ 0022-net-bnxt-fix-error-log-for-command-timeout.patch 2020-05-22 10:37:39.120412571 +0100 @@ -1,13 +1,14 @@ -From 4939f374ad369b4b15ba17a186bd17bf736371f0 Mon Sep 17 00:00:00 2001 +From 2109b14aa9bc684000a5521f476ec46a51bad239 Mon Sep 17 00:00:00 2001 From: Ajit Khaparde Date: Thu, 14 May 2020 23:37:34 -0700 Subject: [PATCH] net/bnxt: fix error log for command timeout +[ upstream commit 4939f374ad369b4b15ba17a186bd17bf736371f0 ] + Log the command sequence number to aid debug in case of a FW command timeout. Fixes: 804e746c7b73 ("net/bnxt: add hardware resource manager init code") -Cc: stable@dpdk.org Signed-off-by: Ajit Khaparde Reviewed-by: Somnath Kotur @@ -17,7 +18,7 @@ 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c -index 77a911067e..d80d67a2d5 100644 +index 7de5b88f0c..9dad6bd319 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -164,8 +164,9 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg,