From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DEDF3A0093 for ; Fri, 22 May 2020 11:42:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CCD211D975; Fri, 22 May 2020 11:42:09 +0200 (CEST) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id 10A531D973 for ; Fri, 22 May 2020 11:42:09 +0200 (CEST) Received: by mail-wm1-f65.google.com with SMTP id v19so2270839wmj.0 for ; Fri, 22 May 2020 02:42:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lsUGQTptfztFxq3t4xcj7JKP2SYKMgCksMKuO46gWMc=; b=ReB8qaxg04cRe/84puk0YS0dKbqokKoEoGei7OuFmIAAiyJaIXXMjUTDzP9nZZ6J2R cfg5fBD7RACeYOyqUwKTwMxkyPcKfUzzswBdhvZKNG9imTJTjwjhXki8wCReDfPILcw5 yhDPUxSKmElrVh4QQR16+WtVzbPihvTnjK+HxNjQ3nUArSfSG49EAGmcaPZOAaH8PoEy BF1iHgu/YgKATwqDxeQ3GcV+swWfsaeeBLT18AiOT6kbdaaNJFTk9aagisDhyryF1Wpx A4qTg7ULOaKP8pAgpSZJMZ8Bho5x2EUDTZ5fJEFLZPrElM7Nc5ctmY7LV/5bZpMyrICu 6fug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lsUGQTptfztFxq3t4xcj7JKP2SYKMgCksMKuO46gWMc=; b=eKGlqwYr5lnxLKOtGXZ+wek5v0bfwCKuitPxWhBumGUQlhmjqADhNhgfGpJCLCGf8J GV7fQTT+sVhqxfBIB7H9h0/5fn3FAk/obcxRrk8pr+xAXiF3LDtnobw4ySbfCxM/6UoJ 1VensHXN/8j2BSf8XONmDzP+UTAFwHly8/dPxS/qg/z1deuNCtLtPmb68zTWLeD0ZcVD ztHZ6BMrAvuWyfCoXaCS7pEx1B4LTisa3d8A+WnBqbht1nytRFGseVttydSHIe41pLpf LS4rL6KyOzxfxoWgK2DlE/jtvMAlHGxJAclveNBv5La2+UZOsC67Ee/YEuAD2IlbfWp7 f9gQ== X-Gm-Message-State: AOAM53159iPv4pKXpnqEuKvop/eTj+8xVAU453+7ykrJP7Wc6An3TYfl z5Vsb3oMEtQEUa2WftO1BRU= X-Google-Smtp-Source: ABdhPJxSNFzcKLOlfvnB2YT14diOt8oaeOfEaXWYImU3IUw4VqfJjU7Wlwiv6XdGHAzVY3NZGDzlXg== X-Received: by 2002:a7b:caf1:: with SMTP id t17mr11877793wml.136.1590140528779; Fri, 22 May 2020 02:42:08 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id e21sm8896473wme.34.2020.05.22.02.42.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2020 02:42:08 -0700 (PDT) From: luca.boccassi@gmail.com To: Gaetan Rivet Cc: Ray Kinsella , dpdk stable Date: Fri, 22 May 2020 10:40:14 +0100 Message-Id: <20200522094022.1025696-35-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200522094022.1025696-1-luca.boccassi@gmail.com> References: <20200519130549.112823-214-luca.boccassi@gmail.com> <20200522094022.1025696-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'doc: fix typos in ABI policy' has been queued to stable release 19.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/24/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 0b45ef6e391e82585f9fb7dc50fc5a52ab769347 Mon Sep 17 00:00:00 2001 From: Gaetan Rivet Date: Wed, 13 May 2020 12:43:01 +0200 Subject: [PATCH] doc: fix typos in ABI policy [ upstream commit ec5c0f80e8c6894269d9a8a467f9f0ffb769a313 ] Some errors in the document: * API instead of ABI once. Some typos: * __rte_depreciated instead of __rte_deprecated. * missing ```` around value. * inconsistent reference to major ABI version, most of the time described without the minor appended, except once. Verbosity and grammar: * Long sentences that would be better cut short. * Comma abuse. * 'May' used where 'can' seems more fitting. I'm not a native speaker though, so grain of salt applies. Fixes: fdf7471cccb8 ("doc: introduce major ABI versions") Signed-off-by: Gaetan Rivet Acked-by: Ray Kinsella --- doc/guides/contributing/abi_policy.rst | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/doc/guides/contributing/abi_policy.rst b/doc/guides/contributing/abi_policy.rst index 05ca95980b..2198519d9b 100644 --- a/doc/guides/contributing/abi_policy.rst +++ b/doc/guides/contributing/abi_policy.rst @@ -220,19 +220,18 @@ Examples of ABI Changes The following are examples of allowable ABI changes occurring between declarations of major ABI versions. -* DPDK 19.11 release, defines the function ``rte_foo()``, and ``rte_foo()`` - as part of the major ABI version ``20``. +* DPDK 19.11 release defines the function ``rte_foo()`` ; ``rte_foo()`` + is part of the major ABI version ``20``. -* DPDK 20.02 release defines a new function ``rte_foo(uint8_t bar)``, and - this is not a problem as long as the symbol ``rte_foo@DPDK20`` is +* DPDK 20.02 release defines a new function ``rte_foo(uint8_t bar)``. + This is not a problem as long as the symbol ``rte_foo@DPDK20`` is preserved through :ref:`abi_versioning`. - The new function may be marked with the ``__rte_experimental`` tag for a number of releases, as described in the section :ref:`experimental_apis`. - - Once ``rte_foo(uint8_t bar)`` becomes non-experimental ``rte_foo()`` is then - declared as ``__rte_depreciated``, with an associated deprecation notice - provided. + - Once ``rte_foo(uint8_t bar)`` becomes non-experimental, ``rte_foo()`` is + declared as ``__rte_deprecated`` and an deprecation notice is provided. * DPDK 19.11 is not re-released to include ``rte_foo(uint8_t bar)``, the new version of ``rte_foo`` only exists from DPDK 20.02 onwards as described in the @@ -242,13 +241,13 @@ declarations of major ABI versions. rte_baz()``. This function may or may not exist in the DPDK 20.05 release. * An application ``dPacket`` wishes to use ``rte_foo(uint8_t bar)``, before the - declaration of the DPDK ``21`` major API version. The application can only + declaration of the DPDK ``21`` major ABI version. The application can only ensure its runtime dependencies are met by specifying ``DPDK (>= 20.2)`` as - an explicit package dependency, as the soname only may only indicate the + an explicit package dependency, as the soname can only indicate the supported major ABI version. * At the release of DPDK 20.11, the function ``rte_foo(uint8_t bar)`` becomes - formally part of then new major ABI version DPDK 21.0 and ``rte_foo()`` may be + formally part of then new major ABI version DPDK ``21`` and ``rte_foo()`` may be removed. .. _deprecation_notices: @@ -322,6 +321,6 @@ Libraries Libraries marked as ``experimental`` are entirely not considered part of an ABI version, and may change without warning at any time. Experimental libraries -always have a major version of ``0`` to indicate they exist outside of +always have a major ABI version of ``0`` to indicate they exist outside of :ref:`abi_versioning` , with the minor version incremented with each ABI change to library. -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-22 10:37:40.620187250 +0100 +++ 0035-doc-fix-typos-in-ABI-policy.patch 2020-05-22 10:37:39.240414721 +0100 @@ -1,8 +1,10 @@ -From ec5c0f80e8c6894269d9a8a467f9f0ffb769a313 Mon Sep 17 00:00:00 2001 +From 0b45ef6e391e82585f9fb7dc50fc5a52ab769347 Mon Sep 17 00:00:00 2001 From: Gaetan Rivet Date: Wed, 13 May 2020 12:43:01 +0200 Subject: [PATCH] doc: fix typos in ABI policy +[ upstream commit ec5c0f80e8c6894269d9a8a467f9f0ffb769a313 ] + Some errors in the document: * API instead of ABI once. @@ -23,7 +25,6 @@ I'm not a native speaker though, so grain of salt applies. Fixes: fdf7471cccb8 ("doc: introduce major ABI versions") -Cc: stable@dpdk.org Signed-off-by: Gaetan Rivet Acked-by: Ray Kinsella @@ -32,10 +33,10 @@ 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/doc/guides/contributing/abi_policy.rst b/doc/guides/contributing/abi_policy.rst -index b921928689..ee17ccb200 100644 +index 05ca95980b..2198519d9b 100644 --- a/doc/guides/contributing/abi_policy.rst +++ b/doc/guides/contributing/abi_policy.rst -@@ -226,19 +226,18 @@ Examples of ABI Changes +@@ -220,19 +220,18 @@ Examples of ABI Changes The following are examples of allowable ABI changes occurring between declarations of major ABI versions. @@ -61,7 +62,7 @@ * DPDK 19.11 is not re-released to include ``rte_foo(uint8_t bar)``, the new version of ``rte_foo`` only exists from DPDK 20.02 onwards as described in the -@@ -248,13 +247,13 @@ declarations of major ABI versions. +@@ -242,13 +241,13 @@ declarations of major ABI versions. rte_baz()``. This function may or may not exist in the DPDK 20.05 release. * An application ``dPacket`` wishes to use ``rte_foo(uint8_t bar)``, before the @@ -78,7 +79,7 @@ removed. .. _deprecation_notices: -@@ -333,6 +332,6 @@ Libraries +@@ -322,6 +321,6 @@ Libraries Libraries marked as ``experimental`` are entirely not considered part of an ABI version, and may change without warning at any time. Experimental libraries