From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05530A04A4 for ; Wed, 27 May 2020 11:25:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F0B631D654; Wed, 27 May 2020 11:25:23 +0200 (CEST) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id B0F7F1D654 for ; Wed, 27 May 2020 11:25:22 +0200 (CEST) Received: by mail-wr1-f65.google.com with SMTP id j10so7677873wrw.8 for ; Wed, 27 May 2020 02:25:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pf1w7Vd+j06mTHnfEjQJ1wr79SPCs13zb9m2wn6APAI=; b=uyBEkl5LbrXjQRAkQEzkSKpLDnSo+fLxy2lrcvI+u79EQNjyf1FSj7ErlDJGHlA81q okvUF4E1XtdfApjVHma85ckiRgoRB30VIRecMlKlal3GRaOAhDVTX4q1sFbGSB1CULfV ZmsklZmwe/G74oucOj2zgfeXttNTFeuiLubTOqaJ1PkWKifbSsgkzm+yS8bPAimcIcnG PoxBJYxzFWfE9gEbG2p3yAOi5WtmdLk1yyrlX4bkBsHGitzuhoJ3IKKqUNQ7zt0Ve93m QooddK9rwGC8cv12CevIqCPCWy8u8rrhvIFhB1XJxQM2o1EfX2EBejhfsgtiNULWpghZ osyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pf1w7Vd+j06mTHnfEjQJ1wr79SPCs13zb9m2wn6APAI=; b=TacNLLZOUpgyS1f/80dqvcta2UKuFcJThwIje8vyQLfwV7JZJ1cYj42P7rXZSFxYQt bifKWK/4b//V3VozyBBWobC2RV1kHTdYDGP8ufIPr7TsBtCZP75qZ0HcViMliecMK/zA 0OPNszS+xTlTDmRXD9572dGIBHV6LMfBgOyoTXsFx9KolodHNq7yveNSJGgtbrzQWVz+ 9pVNmaf/Rqog6onNsle55L6JTfdSJbV5BH2hucRTITcY6stGxHA5vbVJJUpxCDEq0N+N CJx0LBYD7vLb6XqD8JYdANjcBi2DmMa6vuPF3XOfydKMNxm0/vUiYgNftWPGpMo+Wxm0 r9xg== X-Gm-Message-State: AOAM532d29Stt601IpTareVpbXbFNmkVn5pqdbXywXVdlq/7rjRVcP7I YIrWIIJB8BTsGL+MHxXmf7I= X-Google-Smtp-Source: ABdhPJyAsyKqhFEKnDXtgAf23q65g0oEG+0caaMzgTaiw3ChSnjaXRGovetvR3uyoPvS8nTn9Bfusw== X-Received: by 2002:adf:a4dd:: with SMTP id h29mr13420639wrb.372.1590571522205; Wed, 27 May 2020 02:25:22 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id r7sm731560wmb.32.2020.05.27.02.25.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2020 02:25:21 -0700 (PDT) From: luca.boccassi@gmail.com To: Jasvinder Singh Cc: Cristian Dumitrescu , dpdk stable Date: Wed, 27 May 2020 10:24:19 +0100 Message-Id: <20200527092422.258652-16-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200527092422.258652-1-luca.boccassi@gmail.com> References: <20200522094022.1025696-43-luca.boccassi@gmail.com> <20200527092422.258652-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'examples/ip_pipeline: remove check of null response' has been queued to stable release 19.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/29/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 029c527ef48b34c20436d2306487c3b288d2c778 Mon Sep 17 00:00:00 2001 From: Jasvinder Singh Date: Mon, 27 Apr 2020 17:56:49 +0100 Subject: [PATCH] examples/ip_pipeline: remove check of null response [ upstream commit 358eb13389070b34809f478678351ab99f813e5b ] For sending request messages to data plane threads, the caller invokes *_msg_send_recv() functions which never return null response. Thus, removed redundant check on the returned response. Coverity issue: 357750, 357740, 357749, 357758, 357702, 357736 Coverity issue: 357679, 357791, 357738, 357778, 357716, 357705 Coverity issue: 357776, 357753, 357729, 357735, 357773, 357723 Fixes: 32e5d9b154cb ("examples/ip_pipeline: add enable and disable commands") Fixes: 50e73d051806 ("examples/ip_pipeline: add stats read commands") Fixes: 6b1b3c3c9d30 ("examples/ip_pipeline: add port enable and disable commands") Fixes: a3a95b7d58b9 ("examples/ip_pipeline: add table entry commands") Fixes: 3186282f8e12 ("examples/ip_pipeline: add table bulk add command") Fixes: f634e4c5698a ("examples/ip_pipeline: add table entry delete command") Fixes: c64b9121a963 ("examples/ip_pipeline: add table entry stats command") Fixes: 7e11393e40ef ("examples/ip_pipeline: add meter profile commands") Fixes: e92058d604e6 ("examples/ip_pipeline: add meter stats command") Fixes: 2b82ef4861c0 ("examples/ip_pipeline: add DSCP table update command") Fixes: d0d306c7f2a1 ("examples/ip_pipeline: add TTL stats command") Fixes: a3169ee5ec59 ("examples/ip_pipeline: support rule time read") Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitrescu --- examples/ip_pipeline/thread.c | 44 ----------------------------------- 1 file changed, 44 deletions(-) diff --git a/examples/ip_pipeline/thread.c b/examples/ip_pipeline/thread.c index 272fbbeed1..adb83167cd 100644 --- a/examples/ip_pipeline/thread.c +++ b/examples/ip_pipeline/thread.c @@ -325,8 +325,6 @@ thread_pipeline_enable(uint32_t thread_id, /* Send request and wait for response */ rsp = thread_msg_send_recv(thread_id, req); - if (rsp == NULL) - return -1; /* Read response */ status = rsp->status; @@ -412,8 +410,6 @@ thread_pipeline_disable(uint32_t thread_id, /* Send request and wait for response */ rsp = thread_msg_send_recv(thread_id, req); - if (rsp == NULL) - return -1; /* Read response */ status = rsp->status; @@ -815,8 +811,6 @@ pipeline_port_in_stats_read(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) - return -1; /* Read response */ status = rsp->status; @@ -863,8 +857,6 @@ pipeline_port_in_enable(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) - return -1; /* Read response */ status = rsp->status; @@ -909,8 +901,6 @@ pipeline_port_in_disable(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) - return -1; /* Read response */ status = rsp->status; @@ -963,8 +953,6 @@ pipeline_port_out_stats_read(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) - return -1; /* Read response */ status = rsp->status; @@ -1019,8 +1007,6 @@ pipeline_table_stats_read(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) - return -1; /* Read response */ status = rsp->status; @@ -1436,10 +1422,6 @@ pipeline_table_rule_add(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) { - free(rule); - return -1; - } /* Read response */ status = rsp->status; @@ -1538,10 +1520,6 @@ pipeline_table_rule_add_default(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) { - free(rule); - return -1; - } /* Read response */ status = rsp->status; @@ -1655,10 +1633,6 @@ pipeline_table_rule_add_bulk(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) { - table_rule_list_free(list); - return -ENOMEM; - } /* Read response */ status = rsp->status; @@ -1733,8 +1707,6 @@ pipeline_table_rule_delete(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) - return -1; /* Read response */ status = rsp->status; @@ -1790,8 +1762,6 @@ pipeline_table_rule_delete_default(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) - return -1; /* Read response */ status = rsp->status; @@ -1857,8 +1827,6 @@ pipeline_table_rule_stats_read(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) - return -1; /* Read response */ status = rsp->status; @@ -1915,8 +1883,6 @@ pipeline_table_mtr_profile_add(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) - return -1; /* Read response */ status = rsp->status; @@ -1967,8 +1933,6 @@ pipeline_table_mtr_profile_delete(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) - return -1; /* Read response */ status = rsp->status; @@ -2037,8 +2001,6 @@ pipeline_table_rule_mtr_read(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) - return -1; /* Read response */ status = rsp->status; @@ -2096,8 +2058,6 @@ pipeline_table_dscp_table_update(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) - return -1; /* Read response */ status = rsp->status; @@ -2164,8 +2124,6 @@ pipeline_table_rule_ttl_read(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) - return -1; /* Read response */ status = rsp->status; @@ -2229,8 +2187,6 @@ pipeline_table_rule_time_read(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) - return -1; /* Read response */ status = rsp->status; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-27 10:23:32.185445631 +0100 +++ 0016-examples-ip_pipeline-remove-check-of-null-response.patch 2020-05-27 10:23:31.651933946 +0100 @@ -1,8 +1,10 @@ -From 358eb13389070b34809f478678351ab99f813e5b Mon Sep 17 00:00:00 2001 +From 029c527ef48b34c20436d2306487c3b288d2c778 Mon Sep 17 00:00:00 2001 From: Jasvinder Singh Date: Mon, 27 Apr 2020 17:56:49 +0100 Subject: [PATCH] examples/ip_pipeline: remove check of null response +[ upstream commit 358eb13389070b34809f478678351ab99f813e5b ] + For sending request messages to data plane threads, the caller invokes *_msg_send_recv() functions which never return null response. Thus, removed redundant check on @@ -23,7 +25,6 @@ Fixes: 2b82ef4861c0 ("examples/ip_pipeline: add DSCP table update command") Fixes: d0d306c7f2a1 ("examples/ip_pipeline: add TTL stats command") Fixes: a3169ee5ec59 ("examples/ip_pipeline: support rule time read") -Cc: stable@dpdk.org Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitrescu