* [dpdk-stable] [PATCH] bugfix: udptcp_checksum should tread tcp and udp differently
@ 2020-05-27 14:40 guohongzhi
0 siblings, 0 replies; 2+ messages in thread
From: guohongzhi @ 2020-05-27 14:40 UTC (permalink / raw)
To: dev
Cc: stable, olivier.matz, mb, konstantin.ananyev, jiayu.hu,
ferruh.yigit, nicolas.chautru, cristian.dumitrescu, zhoujingbin,
chenchanghu, jerry.lilijun, haifeng.lin, guohongzhi1
RFC 768 for UDP specifies:
If the computed checksum is zero, it is transmitted as all ones.
An all zero transmitted checksum value means that the transmitter
generated no checksum.
RFC 793 for TCP has no such special treatment for the checksum of zero.
Signed-off-by: guohongzhi <guohongzhi1@huawei.com>
---
lib/librte_net/rte_ip.h | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h
index 1ceb7b7..8bef313 100644
--- a/lib/librte_net/rte_ip.h
+++ b/lib/librte_net/rte_ip.h
@@ -324,8 +324,7 @@ rte_ipv4_phdr_cksum(const struct rte_ipv4_hdr *ipv4_hdr, uint64_t ol_flags)
* @param l4_hdr
* The pointer to the beginning of the L4 header.
* @return
- * The complemented checksum to set in the IP packet
- * or 0 on error
+ * The complemented checksum to set in the IP packet.
*/
static inline uint16_t
rte_ipv4_udptcp_cksum(const struct rte_ipv4_hdr *ipv4_hdr, const void *l4_hdr)
@@ -344,7 +343,10 @@ rte_ipv4_udptcp_cksum(const struct rte_ipv4_hdr *ipv4_hdr, const void *l4_hdr)
cksum = ((cksum & 0xffff0000) >> 16) + (cksum & 0xffff);
cksum = (~cksum) & 0xffff;
- if (cksum == 0)
+ /* For Udp, if the computed checksum is zero,
+ * it is transmitted as all ones.RFC768
+ */
+ if (cksum == 0 && ipv4_hdr->next_proto_id == IPPROTO_UDP)
cksum = 0xffff;
return (uint16_t)cksum;
@@ -436,7 +438,10 @@ rte_ipv6_udptcp_cksum(const struct rte_ipv6_hdr *ipv6_hdr, const void *l4_hdr)
cksum = ((cksum & 0xffff0000) >> 16) + (cksum & 0xffff);
cksum = (~cksum) & 0xffff;
- if (cksum == 0)
+ /* For Udp, if the computed checksum is zero,
+ * it is transmitted as all ones.RFC768
+ */
+ if (cksum == 0 && ipv6_hdr->proto == IPPROTO_UDP)
cksum = 0xffff;
return (uint16_t)cksum;
--
2.21.0.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [dpdk-stable] [PATCH] bugfix: udptcp_checksum should tread tcp and udp differently
@ 2020-05-27 14:41 guohongzhi
0 siblings, 0 replies; 2+ messages in thread
From: guohongzhi @ 2020-05-27 14:41 UTC (permalink / raw)
To: dev
Cc: stable, olivier.matz, mb, konstantin.ananyev, jiayu.hu,
ferruh.yigit, nicolas.chautru, cristian.dumitrescu, zhoujingbin,
chenchanghu, jerry.lilijun, haifeng.lin, guohongzhi1
From: Hongzhi Guo <guohongzhi1@huawei.com>
RFC 768 for UDP specifies:
If the computed checksum is zero, it is transmitted as all ones.
An all zero transmitted checksum value means that the transmitter
generated no checksum.
RFC 793 for TCP has no such special treatment for the checksum of zero.
Signed-off-by: Hongzhi Guo <guohongzhi1@huawei.com>
---
lib/librte_net/rte_ip.h | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h
index 1ceb7b7..8bef313 100644
--- a/lib/librte_net/rte_ip.h
+++ b/lib/librte_net/rte_ip.h
@@ -324,8 +324,7 @@ rte_ipv4_phdr_cksum(const struct rte_ipv4_hdr *ipv4_hdr, uint64_t ol_flags)
* @param l4_hdr
* The pointer to the beginning of the L4 header.
* @return
- * The complemented checksum to set in the IP packet
- * or 0 on error
+ * The complemented checksum to set in the IP packet.
*/
static inline uint16_t
rte_ipv4_udptcp_cksum(const struct rte_ipv4_hdr *ipv4_hdr, const void *l4_hdr)
@@ -344,7 +343,10 @@ rte_ipv4_udptcp_cksum(const struct rte_ipv4_hdr *ipv4_hdr, const void *l4_hdr)
cksum = ((cksum & 0xffff0000) >> 16) + (cksum & 0xffff);
cksum = (~cksum) & 0xffff;
- if (cksum == 0)
+ /* For Udp, if the computed checksum is zero,
+ * it is transmitted as all ones.RFC768
+ */
+ if (cksum == 0 && ipv4_hdr->next_proto_id == IPPROTO_UDP)
cksum = 0xffff;
return (uint16_t)cksum;
@@ -436,7 +438,10 @@ rte_ipv6_udptcp_cksum(const struct rte_ipv6_hdr *ipv6_hdr, const void *l4_hdr)
cksum = ((cksum & 0xffff0000) >> 16) + (cksum & 0xffff);
cksum = (~cksum) & 0xffff;
- if (cksum == 0)
+ /* For Udp, if the computed checksum is zero,
+ * it is transmitted as all ones.RFC768
+ */
+ if (cksum == 0 && ipv6_hdr->proto == IPPROTO_UDP)
cksum = 0xffff;
return (uint16_t)cksum;
--
2.21.0.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-27 14:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-27 14:40 [dpdk-stable] [PATCH] bugfix: udptcp_checksum should tread tcp and udp differently guohongzhi
2020-05-27 14:41 guohongzhi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).