From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8855DA0093 for ; Thu, 28 May 2020 18:24:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 37C401DC1D; Thu, 28 May 2020 18:24:45 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id A5B841D996 for ; Thu, 28 May 2020 18:24:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590683082; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VKUidMxg+oXYnB6K0WFGAgCqcYDONTVniqj1VAUX9vY=; b=aTE+JRch0CEsp/PN8yki/G35VIXFAVkj6FI+QotFhu8n+2E0y9MB8OyIJBBwyKfQJ56Poc hT2lPEpyAbtq+Ku6aqvtiC/c4tUelinU76/oLjgvBH+o2MJUjhUm8e40LgCcXYJG3E9++G UfTLuI7+1VoNPd4a9jGEN4wN8QIKa3w= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-484-x3yrek5wPdeUrWTfz4L9Cw-1; Thu, 28 May 2020 12:24:38 -0400 X-MC-Unique: x3yrek5wPdeUrWTfz4L9Cw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DE8211052502; Thu, 28 May 2020 16:24:36 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.235]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0563960C05; Thu, 28 May 2020 16:24:35 +0000 (UTC) From: Kevin Traynor To: Igor Romanov Cc: Andrew Rybchenko , dpdk stable Date: Thu, 28 May 2020 17:22:04 +0100 Message-Id: <20200528162322.7863-17-ktraynor@redhat.com> In-Reply-To: <20200528162322.7863-1-ktraynor@redhat.com> References: <20200528162322.7863-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/sfc/base: reject automatic filter creation by users' has been queued to LTS release 18.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/03/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/86786f06fb1e97ababd0b0778b404eba3673a8fa Thanks. Kevin. --- >From 86786f06fb1e97ababd0b0778b404eba3673a8fa Mon Sep 17 00:00:00 2001 From: Igor Romanov Date: Tue, 10 Mar 2020 09:48:37 +0000 Subject: [PATCH] net/sfc/base: reject automatic filter creation by users [ upstream commit fbf423bbf2d298e4fc0e3f3a0d498ddb8bada94b ] The automatic filter priority may only be used by filter implementation, so reject the attempts to create such filters by client drivers. Fixes: f9565517ff4f ("net/sfc/base: import filters support") Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/efx_filter.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/sfc/base/efx_filter.c b/drivers/net/sfc/base/efx_filter.c index c55b1c7761..9e53af7538 100644 --- a/drivers/net/sfc/base/efx_filter.c +++ b/drivers/net/sfc/base/efx_filter.c @@ -94,6 +94,13 @@ efx_filter_insert( } + if (spec->efs_priority == EFX_FILTER_PRI_AUTO) { + rc = EINVAL; + goto fail3; + } + return (efop->efo_add(enp, spec, B_FALSE)); +fail3: + EFSYS_PROBE(fail3); fail2: EFSYS_PROBE(fail2); -- 2.21.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-28 17:13:00.057764112 +0100 +++ 0017-net-sfc-base-reject-automatic-filter-creation-by-use.patch 2020-05-28 17:12:59.067557170 +0100 @@ -1 +1 @@ -From fbf423bbf2d298e4fc0e3f3a0d498ddb8bada94b Mon Sep 17 00:00:00 2001 +From 86786f06fb1e97ababd0b0778b404eba3673a8fa Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit fbf423bbf2d298e4fc0e3f3a0d498ddb8bada94b ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 575f6228be..36332a2801 100644 +index c55b1c7761..9e53af7538 100644