From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E706A0093 for ; Thu, 28 May 2020 18:24:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EE3501D996; Thu, 28 May 2020 18:24:19 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 462BE1D996 for ; Thu, 28 May 2020 18:24:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590683057; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mekfubFzvhmzA7dzP4y7SlwYGHDgJNh9he4MqXRXvCg=; b=M6ShMNjuqv7xOkgGbPNksOfD84Nq9klVaRfetB/slnBvAZKa9927171nODM+NGOEzgjyCS 8LxnAwkpFZe0BV/OSyzdsgqdNsoLbmkqZ99xXEnEtRXAfyWu5bIo5cqVotwEFueoHcJO9F yvNMNYhf2SrocLnHZOtW0kDihR+emzE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-298-1gS7C1ebOSaMMO8B9ysBfA-1; Thu, 28 May 2020 12:24:12 -0400 X-MC-Unique: 1gS7C1ebOSaMMO8B9ysBfA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8CB28100CCC6 for ; Thu, 28 May 2020 16:24:11 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.235]) by smtp.corp.redhat.com (Postfix) with ESMTP id A2C4060C81; Thu, 28 May 2020 16:24:01 +0000 (UTC) From: Kevin Traynor To: Timothy Redaelli Cc: David Marchand , dpdk stable Date: Thu, 28 May 2020 17:21:49 +0100 Message-Id: <20200528162322.7863-2-ktraynor@redhat.com> In-Reply-To: <20200528162322.7863-1-ktraynor@redhat.com> References: <20200528162322.7863-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'examples/eventdev: fix build with gcc 10' has been queued to LTS release 18.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/03/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/5973c23a8e2c8f59127ee8588a3c081cde5c717d Thanks. Kevin. --- >From 5973c23a8e2c8f59127ee8588a3c081cde5c717d Mon Sep 17 00:00:00 2001 From: Timothy Redaelli Date: Wed, 5 Feb 2020 18:05:45 +0100 Subject: [PATCH] examples/eventdev: fix build with gcc 10 [ upstream commit 78de15bb586ac3d8938512db1977d83815c494f8 ] GCC 10 defaults to -fno-common, this means a linker error will now be reported if the same global variable is defined in more than one compilation unit. Fixes: 3d1b33e44ae2 ("examples/eventdev: move common data into pipeline common") Signed-off-by: Timothy Redaelli Acked-by: David Marchand --- examples/eventdev_pipeline/main.c | 2 ++ examples/eventdev_pipeline/pipeline_common.h | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/examples/eventdev_pipeline/main.c b/examples/eventdev_pipeline/main.c index 92e08bc0c8..04b30cf6ea 100644 --- a/examples/eventdev_pipeline/main.c +++ b/examples/eventdev_pipeline/main.c @@ -11,4 +11,6 @@ #include "pipeline_common.h" +struct fastpath_data *fdata; + struct config_data cdata = { .num_packets = (1L << 25), /* do ~32M packets */ diff --git a/examples/eventdev_pipeline/pipeline_common.h b/examples/eventdev_pipeline/pipeline_common.h index a6cc912fbb..016a3f702b 100644 --- a/examples/eventdev_pipeline/pipeline_common.h +++ b/examples/eventdev_pipeline/pipeline_common.h @@ -94,6 +94,6 @@ struct port_link { }; -struct fastpath_data *fdata; -struct config_data cdata; +extern struct fastpath_data *fdata; +extern struct config_data cdata; static __rte_always_inline void -- 2.21.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-28 17:12:59.302660191 +0100 +++ 0002-examples-eventdev-fix-build-with-gcc-10.patch 2020-05-28 17:12:59.025558120 +0100 @@ -1 +1 @@ -From 78de15bb586ac3d8938512db1977d83815c494f8 Mon Sep 17 00:00:00 2001 +From 5973c23a8e2c8f59127ee8588a3c081cde5c717d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 78de15bb586ac3d8938512db1977d83815c494f8 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index d3ff1bbe4f..d0da51b1c9 100644 +index 92e08bc0c8..04b30cf6ea 100644 @@ -32 +33 @@ -index 8e30393d09..c7245f7f0f 100644 +index a6cc912fbb..016a3f702b 100644