From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2EA66A00BE for ; Thu, 28 May 2020 18:24:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C489A1D996; Thu, 28 May 2020 18:24:55 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 85AE91D996 for ; Thu, 28 May 2020 18:24:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590683094; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t0T6Ibp5JMMT62bR0YX5DbEz96obtjtxuZt92jTYs58=; b=Gn13RiWhydAnVcLf5zsp55+yhAcTV87Rf9mwd+JNeTXzcI1d0ZwsQSHBwdVeyP7MwSDgfy m0g0MQmj8VbMTFXo6giv5ujgIIzYeo2lfgpbz2onDmyV/q4/2fw19S//o+/d46YUVzq7Do rH1kQwevUlSbf0m8Nwwzp6M7kc2TdbE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-269-Ig7QeGiYP5KjR5p5rcerww-1; Thu, 28 May 2020 12:24:49 -0400 X-MC-Unique: Ig7QeGiYP5KjR5p5rcerww-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4EBF78005AA; Thu, 28 May 2020 16:24:48 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.235]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1521E60C05; Thu, 28 May 2020 16:24:46 +0000 (UTC) From: Kevin Traynor To: Ruifeng Wang Cc: Gavin Hu , Aaron Conole , Yipeng Wang , dpdk stable Date: Thu, 28 May 2020 17:22:10 +0100 Message-Id: <20200528162322.7863-23-ktraynor@redhat.com> In-Reply-To: <20200528162322.7863-1-ktraynor@redhat.com> References: <20200528162322.7863-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'test: skip some subtests in no-huge mode' has been queued to LTS release 18.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/03/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/17ee228d0a1f677a92b86c39cccf4a19d7e75c21 Thanks. Kevin. --- >From 17ee228d0a1f677a92b86c39cccf4a19d7e75c21 Mon Sep 17 00:00:00 2001 From: Ruifeng Wang Date: Mon, 23 Mar 2020 20:59:23 +0100 Subject: [PATCH] test: skip some subtests in no-huge mode [ upstream commit 27fb5dd2850c60b46660b93c2fe14da6841b142c ] When running with '--no-huge' flag, tests failed with messages as: ACL context creation with invalid NUMA should have failed! fbk hash creation should have failed test_table_pipeline: Check pipeline invalid params failed. These cases test against invalid socket ID as input parameter, and expect error return. But function calls return success because invalid sock ID is overwritten to SOCKET_ID_ANY when in no-huge mode. The tests against invalid socket ID are skipped in no-huge mode. Fixes: 5640171c528a ("malloc: fix external heap allocation in no-huge mode") Signed-off-by: Ruifeng Wang Reviewed-by: Gavin Hu Acked-by: Aaron Conole Acked-by: Yipeng Wang --- test/test/test_acl.c | 20 +++++++++++--------- test/test/test_hash.c | 7 +++++-- test/test/test_table_pipeline.c | 12 +++++++----- 3 files changed, 23 insertions(+), 16 deletions(-) diff --git a/test/test/test_acl.c b/test/test/test_acl.c index b1f75d1bc7..4fedcf446f 100644 --- a/test/test/test_acl.c +++ b/test/test/test_acl.c @@ -1395,14 +1395,16 @@ test_invalid_parameters(void) rte_acl_free(acx); - /* invalid NUMA node */ - memcpy(¶m, &acl_param, sizeof(param)); - param.socket_id = RTE_MAX_NUMA_NODES + 1; + if (rte_eal_has_hugepages()) { + /* invalid NUMA node */ + memcpy(¶m, &acl_param, sizeof(param)); + param.socket_id = RTE_MAX_NUMA_NODES + 1; - acx = rte_acl_create(¶m); - if (acx != NULL) { - printf("Line %i: ACL context creation with invalid NUMA " - "should have failed!\n", __LINE__); - rte_acl_free(acx); - return -1; + acx = rte_acl_create(¶m); + if (acx != NULL) { + printf("Line %i: ACL context creation with invalid " + "NUMA should have failed!\n", __LINE__); + rte_acl_free(acx); + return -1; + } } diff --git a/test/test/test_hash.c b/test/test/test_hash.c index fe607fadf2..ea711b1f10 100644 --- a/test/test/test_hash.c +++ b/test/test/test_hash.c @@ -1047,6 +1047,9 @@ fbk_hash_unit_test(void) RETURN_IF_ERROR_FBK(handle != NULL, "fbk hash creation should have failed"); - handle = rte_fbk_hash_create(&invalid_params_8); - RETURN_IF_ERROR_FBK(handle != NULL, "fbk hash creation should have failed"); + if (rte_eal_has_hugepages()) { + handle = rte_fbk_hash_create(&invalid_params_8); + RETURN_IF_ERROR_FBK(handle != NULL, + "fbk hash creation should have failed"); + } handle = rte_fbk_hash_create(&invalid_params_same_name_1); diff --git a/test/test/test_table_pipeline.c b/test/test/test_table_pipeline.c index 441338ac01..bc412c3081 100644 --- a/test/test/test_table_pipeline.c +++ b/test/test/test_table_pipeline.c @@ -191,9 +191,11 @@ check_pipeline_invalid_params(void) } - p = rte_pipeline_create(&pipeline_params_3); - if (p != NULL) { - RTE_LOG(INFO, PIPELINE, "%s: Configure pipeline with invalid " - "socket\n", __func__); - goto fail; + if (rte_eal_has_hugepages()) { + p = rte_pipeline_create(&pipeline_params_3); + if (p != NULL) { + RTE_LOG(INFO, PIPELINE, "%s: Configure pipeline with " + "invalid socket\n", __func__); + goto fail; + } } -- 2.21.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-28 17:13:00.374401684 +0100 +++ 0023-test-skip-some-subtests-in-no-huge-mode.patch 2020-05-28 17:12:59.084556785 +0100 @@ -1 +1 @@ -From 27fb5dd2850c60b46660b93c2fe14da6841b142c Mon Sep 17 00:00:00 2001 +From 17ee228d0a1f677a92b86c39cccf4a19d7e75c21 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 27fb5dd2850c60b46660b93c2fe14da6841b142c ] + @@ -18 +19,0 @@ -Cc: stable@dpdk.org @@ -25,3 +26,3 @@ - app/test/test_acl.c | 20 +++++++++++--------- - app/test/test_hash.c | 7 +++++-- - app/test/test_table_pipeline.c | 12 +++++++----- + test/test/test_acl.c | 20 +++++++++++--------- + test/test/test_hash.c | 7 +++++-- + test/test/test_table_pipeline.c | 12 +++++++----- @@ -30,5 +31,5 @@ -diff --git a/app/test/test_acl.c b/app/test/test_acl.c -index 501de35da1..316bf4d065 100644 ---- a/app/test/test_acl.c -+++ b/app/test/test_acl.c -@@ -1398,14 +1398,16 @@ test_invalid_parameters(void) +diff --git a/test/test/test_acl.c b/test/test/test_acl.c +index b1f75d1bc7..4fedcf446f 100644 +--- a/test/test/test_acl.c ++++ b/test/test/test_acl.c +@@ -1395,14 +1395,16 @@ test_invalid_parameters(void) @@ -60,5 +61,5 @@ -diff --git a/app/test/test_hash.c b/app/test/test_hash.c -index fbd5725c68..ab978ea689 100644 ---- a/app/test/test_hash.c -+++ b/app/test/test_hash.c -@@ -1137,6 +1137,9 @@ fbk_hash_unit_test(void) +diff --git a/test/test/test_hash.c b/test/test/test_hash.c +index fe607fadf2..ea711b1f10 100644 +--- a/test/test/test_hash.c ++++ b/test/test/test_hash.c +@@ -1047,6 +1047,9 @@ fbk_hash_unit_test(void) @@ -76 +77 @@ -diff --git a/app/test/test_table_pipeline.c b/app/test/test_table_pipeline.c +diff --git a/test/test/test_table_pipeline.c b/test/test/test_table_pipeline.c @@ -78,2 +79,2 @@ ---- a/app/test/test_table_pipeline.c -+++ b/app/test/test_table_pipeline.c +--- a/test/test/test_table_pipeline.c ++++ b/test/test/test_table_pipeline.c