From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D08CA0093 for ; Thu, 28 May 2020 18:25:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AD38D1DC30; Thu, 28 May 2020 18:25:25 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 6109F1DC35 for ; Thu, 28 May 2020 18:25:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590683123; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JB2FRPyI3tvhVx9Nth9+LDNsvoNS2R2+VMDmd5yq4kY=; b=JPJ/bVba2TV8o0I/m7r2G2GoSTz3/oJg26nRKOLHtk+mfqInSgoa9LCgvm0lzO46TZtpi+ cHov1H+AWqVZlKB1sPuLEPMHWR5Rx+b0QR/aAYW2oIrozAiQji4Ay8UVppTj+hCaAIstki LnYtW/rDAve6VFoC9y/ZOKIH5LKoBNo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-382-IF1eFHArPW-nym--YbDFWA-1; Thu, 28 May 2020 12:25:20 -0400 X-MC-Unique: IF1eFHArPW-nym--YbDFWA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3086B107ACF3; Thu, 28 May 2020 16:25:19 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.235]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4BA1160C05; Thu, 28 May 2020 16:25:18 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: Ferruh Yigit , dpdk stable Date: Thu, 28 May 2020 17:22:34 +0100 Message-Id: <20200528162322.7863-47-ktraynor@redhat.com> In-Reply-To: <20200528162322.7863-1-ktraynor@redhat.com> References: <20200528162322.7863-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/virtio: do not use PMD log type' has been queued to LTS release 18.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/03/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/38aef4ba560e3107affaf98a9918e71a142454f4 Thanks. Kevin. --- >From 38aef4ba560e3107affaf98a9918e71a142454f4 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Mon, 30 Mar 2020 21:41:51 -0700 Subject: [PATCH] net/virtio: do not use PMD log type [ upstream commit 88fa5bb6b9807d55a3fbd34e5537fcf1ee7efb80 ] Virtio driver has its own logtype and should not use legacy PMD logtype. Fixes: 32c118fd0059 ("virtio: free mbuf's with threshold") Fixes: e5f456a98d3c ("net/virtio: support in-order Rx and Tx") Fixes: 1c8489da561b ("net/virtio-user: fix multi-process support") Signed-off-by: Stephen Hemminger Reviewed-by: Ferruh Yigit --- drivers/net/virtio/virtio_rxtx.c | 6 +++--- drivers/net/virtio/virtio_user_ethdev.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index db2d1f1c1e..8ce5c33940 100644 --- a/drivers/net/virtio/virtio_rxtx.c +++ b/drivers/net/virtio/virtio_rxtx.c @@ -709,5 +709,5 @@ virtio_dev_tx_queue_setup(struct rte_eth_dev *dev, if (tx_free_thresh >= (vq->vq_nentries - 3)) { - RTE_LOG(ERR, PMD, "tx_free_thresh must be less than the " + PMD_DRV_LOG(ERR, "tx_free_thresh must be less than the " "number of TX entries minus 3 (%u)." " (tx_free_thresh=%u port=%u queue=%u)\n", @@ -752,5 +752,5 @@ virtio_discard_rxbuf(struct virtqueue *vq, struct rte_mbuf *m) if (unlikely(error)) { - RTE_LOG(ERR, PMD, "cannot requeue discarded mbuf"); + PMD_DRV_LOG(ERR, "cannot requeue discarded mbuf"); rte_pktmbuf_free(m); } @@ -764,5 +764,5 @@ virtio_discard_rxbuf_inorder(struct virtqueue *vq, struct rte_mbuf *m) error = virtqueue_enqueue_refill_inorder(vq, &m, 1); if (unlikely(error)) { - RTE_LOG(ERR, PMD, "cannot requeue discarded mbuf"); + PMD_DRV_LOG(ERR, "cannot requeue discarded mbuf"); rte_pktmbuf_free(m); } diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c index 63b647dc52..7a2de2ac1a 100644 --- a/drivers/net/virtio/virtio_user_ethdev.c +++ b/drivers/net/virtio/virtio_user_ethdev.c @@ -472,5 +472,5 @@ virtio_user_pmd_probe(struct rte_vdev_device *dev) eth_dev = rte_eth_dev_attach_secondary(name); if (!eth_dev) { - RTE_LOG(ERR, PMD, "Failed to probe %s\n", name); + PMD_INIT_LOG(ERR, "Failed to probe %s", name); return -1; } -- 2.21.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-28 17:13:01.564718440 +0100 +++ 0047-net-virtio-do-not-use-PMD-log-type.patch 2020-05-28 17:12:59.116556061 +0100 @@ -1 +1 @@ -From 88fa5bb6b9807d55a3fbd34e5537fcf1ee7efb80 Mon Sep 17 00:00:00 2001 +From 38aef4ba560e3107affaf98a9918e71a142454f4 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 88fa5bb6b9807d55a3fbd34e5537fcf1ee7efb80 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index 752faa0f6e..060410577a 100644 +index db2d1f1c1e..8ce5c33940 100644 @@ -25 +26 @@ -@@ -1086,5 +1086,5 @@ virtio_dev_tx_queue_setup(struct rte_eth_dev *dev, +@@ -709,5 +709,5 @@ virtio_dev_tx_queue_setup(struct rte_eth_dev *dev, @@ -32 +33 @@ -@@ -1134,5 +1134,5 @@ virtio_discard_rxbuf(struct virtqueue *vq, struct rte_mbuf *m) +@@ -752,5 +752,5 @@ virtio_discard_rxbuf(struct virtqueue *vq, struct rte_mbuf *m) @@ -39 +40 @@ -@@ -1146,5 +1146,5 @@ virtio_discard_rxbuf_inorder(struct virtqueue *vq, struct rte_mbuf *m) +@@ -764,5 +764,5 @@ virtio_discard_rxbuf_inorder(struct virtqueue *vq, struct rte_mbuf *m) @@ -47 +48 @@ -index e61af40683..5637001dfc 100644 +index 63b647dc52..7a2de2ac1a 100644 @@ -50 +51 @@ -@@ -562,5 +562,5 @@ virtio_user_pmd_probe(struct rte_vdev_device *dev) +@@ -472,5 +472,5 @@ virtio_user_pmd_probe(struct rte_vdev_device *dev)