From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD274A0093 for ; Thu, 28 May 2020 18:25:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C5B891DC37; Thu, 28 May 2020 18:25:37 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 26E4B1DC13 for ; Thu, 28 May 2020 18:25:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590683135; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S/cukCW54Iur43O9gO1w0AZ9+ezmxx0jw5uCvIfamBA=; b=RFsmO8P94EzB1aiLpjeUiKWX/raGk6GFUmSgD/NyKuz1EVa4Lb9dE2PqSAc3BzzVVvqkRZ 7pYBVDwOw6Cga7iuezGWoDBa2amwq2+zTP08aoGuxGzWWwxPyOiMB1WoOgmxH6Lc+3U7Sz SFqFq3BSvMugYWrgeFnwqSvI6stZOgY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-369-gfiEQYPeODCjTLzfLA1gbg-1; Thu, 28 May 2020 12:25:32 -0400 X-MC-Unique: gfiEQYPeODCjTLzfLA1gbg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EDC4318FE860; Thu, 28 May 2020 16:25:31 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.235]) by smtp.corp.redhat.com (Postfix) with ESMTP id 40D0560FC2; Thu, 28 May 2020 16:25:31 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: dpdk stable Date: Thu, 28 May 2020 17:22:45 +0100 Message-Id: <20200528162322.7863-58-ktraynor@redhat.com> In-Reply-To: <20200528162322.7863-1-ktraynor@redhat.com> References: <20200528162322.7863-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/netvsc: remove process event optimization' has been queued to LTS release 18.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/03/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/30779c9fd3d5e7052fd60d5829c052fa1d1b0b40 Thanks. Kevin. --- >From 30779c9fd3d5e7052fd60d5829c052fa1d1b0b40 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Tue, 31 Mar 2020 10:14:01 -0700 Subject: [PATCH] net/netvsc: remove process event optimization [ upstream commit dfd3f0fce8bd64182b984b4a9226f2d23c44b2d5 ] Remove unlocked check for data in receive ring. This check is not safe because of missing barriers etc. Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_rxtx.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c index 06408250a8..1fb8dec9a9 100644 --- a/drivers/net/netvsc/hn_rxtx.c +++ b/drivers/net/netvsc/hn_rxtx.c @@ -954,8 +954,4 @@ uint32_t hn_process_events(struct hn_data *hv, uint16_t queue_id, rxq = queue_id == 0 ? hv->primary : dev->data->rx_queues[queue_id]; - /* If no pending data then nothing to do */ - if (rte_vmbus_chan_rx_empty(rxq->chan)) - return 0; - /* * Since channel is shared between Rx and TX queue need to have a lock -- 2.21.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-28 17:13:02.119726431 +0100 +++ 0058-net-netvsc-remove-process-event-optimization.patch 2020-05-28 17:12:59.133555676 +0100 @@ -1 +1 @@ -From dfd3f0fce8bd64182b984b4a9226f2d23c44b2d5 Mon Sep 17 00:00:00 2001 +From 30779c9fd3d5e7052fd60d5829c052fa1d1b0b40 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit dfd3f0fce8bd64182b984b4a9226f2d23c44b2d5 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ -index 32c03e3da0..e8df846042 100644 +index 06408250a8..1fb8dec9a9 100644 @@ -21 +22 @@ -@@ -970,8 +970,4 @@ uint32_t hn_process_events(struct hn_data *hv, uint16_t queue_id, +@@ -954,8 +954,4 @@ uint32_t hn_process_events(struct hn_data *hv, uint16_t queue_id,