From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE274A0093 for ; Thu, 28 May 2020 18:25:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E60301DC18; Thu, 28 May 2020 18:25:41 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id E233A1DC1A for ; Thu, 28 May 2020 18:25:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590683139; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kHGducVTNnHaHDsTdOR3Q33f6fN2/nBqWZ1MwrIxYBM=; b=XWueCLEc8JHNVjnaC/b35TI1zfpxPRlTqHkb314qd/r7Fib2ABL/4dN8KmzDj6BxGbLFp6 iaYCCLsIIqZXG/EwP1Et3VSRNPmgBpyzdkfV09krGGd+IPrxEy16AtCUvCx1x65l8aqo5i JBXYM7jJzXMqkqziD4Dcfnrv25e6DdM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-351-4F6xVzluO9y9O7fu2QCX1g-1; Thu, 28 May 2020 12:25:34 -0400 X-MC-Unique: 4F6xVzluO9y9O7fu2QCX1g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 05B5B18FE866; Thu, 28 May 2020 16:25:33 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.235]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4C77A60E1C; Thu, 28 May 2020 16:25:32 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: dpdk stable Date: Thu, 28 May 2020 17:22:46 +0100 Message-Id: <20200528162322.7863-59-ktraynor@redhat.com> In-Reply-To: <20200528162322.7863-1-ktraynor@redhat.com> References: <20200528162322.7863-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/netvsc: handle Tx completions based on burst size' has been queued to LTS release 18.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/03/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/cfb7a60c72554d777412a5bf5320848b205f951f Thanks. Kevin. --- >From cfb7a60c72554d777412a5bf5320848b205f951f Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Tue, 31 Mar 2020 10:14:02 -0700 Subject: [PATCH] net/netvsc: handle Tx completions based on burst size [ upstream commit 56edef9906558c69a1440173a5a3aac8f8f8710f ] If tx_free_thresh is quite low, it is possible that we need to cleanup based on burst size. Fixes: fc30efe3a22e ("net/netvsc: change Rx descriptor setup and sizing") Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_rxtx.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c index 1fb8dec9a9..caed452540 100644 --- a/drivers/net/netvsc/hn_rxtx.c +++ b/drivers/net/netvsc/hn_rxtx.c @@ -1360,5 +1360,5 @@ hn_xmit_pkts(void *ptxq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) struct rte_eth_dev *vf_dev; bool need_sig = false; - uint16_t nb_tx; + uint16_t nb_tx, avail; int ret; @@ -1375,5 +1375,6 @@ hn_xmit_pkts(void *ptxq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) } - if (rte_mempool_avail_count(txq->txdesc_pool) <= txq->free_thresh) + avail = rte_mempool_avail_count(txq->txdesc_pool); + if (nb_pkts > avail || avail <= txq->free_thresh) hn_process_events(hv, txq->queue_id, 0); -- 2.21.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-28 17:13:02.168253104 +0100 +++ 0059-net-netvsc-handle-Tx-completions-based-on-burst-size.patch 2020-05-28 17:12:59.135555631 +0100 @@ -1 +1 @@ -From 56edef9906558c69a1440173a5a3aac8f8f8710f Mon Sep 17 00:00:00 2001 +From cfb7a60c72554d777412a5bf5320848b205f951f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 56edef9906558c69a1440173a5a3aac8f8f8710f ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ -index e8df846042..cbdfcc628b 100644 +index 1fb8dec9a9..caed452540 100644 @@ -21 +22 @@ -@@ -1376,5 +1376,5 @@ hn_xmit_pkts(void *ptxq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) +@@ -1360,5 +1360,5 @@ hn_xmit_pkts(void *ptxq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) @@ -28 +29 @@ -@@ -1391,5 +1391,6 @@ hn_xmit_pkts(void *ptxq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) +@@ -1375,5 +1375,6 @@ hn_xmit_pkts(void *ptxq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)