From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42937A0093 for ; Thu, 28 May 2020 18:24:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3C28D1D996; Thu, 28 May 2020 18:24:28 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 478E51D996 for ; Thu, 28 May 2020 18:24:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590683066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xxMrwwXbM0BulN2FQK2BmbHl8iuMiN1mAEpb6cdXFHg=; b=gtfIOvLXh5UVTzlohMRhZhfUnDrAtjtYyTy19GgGF4KxFgX36/mgacpoj3dPxQhyw78Jq7 Tl8Tm/mi0f3KpK1sXhbD1c/AbOgqv6QWpBVj5EOhJNsx3a+orO0ML3Oib4PSzT0g37yBhZ sp+ahppu1aiQPKQTh3U4oe5t0veOsSc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-184-Qg2a73mRNOOETaooUcl8QA-1; Thu, 28 May 2020 12:24:23 -0400 X-MC-Unique: Qg2a73mRNOOETaooUcl8QA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B823F83DE30; Thu, 28 May 2020 16:24:22 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.235]) by smtp.corp.redhat.com (Postfix) with ESMTP id 46DF26111F; Thu, 28 May 2020 16:24:15 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: Andrea Arcangeli , Maxime Coquelin , Aaron Conole , Anatoly Burakov , dpdk stable Date: Thu, 28 May 2020 17:21:53 +0100 Message-Id: <20200528162322.7863-6-ktraynor@redhat.com> In-Reply-To: <20200528162322.7863-1-ktraynor@redhat.com> References: <20200528162322.7863-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'mem: mark pages as not accessed when reserving VA' has been queued to LTS release 18.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/03/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/444b6438813fe82fb850748455b100ad11907bdc Thanks. Kevin. --- >From 444b6438813fe82fb850748455b100ad11907bdc Mon Sep 17 00:00:00 2001 From: David Marchand Date: Mon, 9 Mar 2020 15:54:42 +0100 Subject: [PATCH] mem: mark pages as not accessed when reserving VA [ upstream commit 8a4baf06c17a806696fb10aba36fce7471983028 ] When the memory allocator reserves virtual addresses, it still does not know what they will be used for. Besides, huge areas are reserved for memory hotplug in multiprocess setups. But most of the pages are unused in the whole life of the processes. Change protection mode to PROT_NONE when only reserving VA. The memory allocator already switches to the right mode when making use of it. It also has the nice effect of getting those pages skipped by the kernel when calling mlockall() or when a coredump gets generated. Suggested-by: Andrea Arcangeli Signed-off-by: David Marchand Reviewed-by: Maxime Coquelin Acked-by: Aaron Conole Acked-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_memory.c b/lib/librte_eal/common/eal_common_memory.c index 9a14698aae..030f1b261c 100644 --- a/lib/librte_eal/common/eal_common_memory.c +++ b/lib/librte_eal/common/eal_common_memory.c @@ -113,5 +113,5 @@ eal_get_virtual_area(void *requested_addr, size_t *size, } - mapped_addr = mmap(requested_addr, (size_t)map_sz, PROT_READ, + mapped_addr = mmap(requested_addr, (size_t)map_sz, PROT_NONE, mmap_flags, -1, 0); if (mapped_addr == MAP_FAILED && allow_shrink) -- 2.21.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-28 17:12:59.491937520 +0100 +++ 0006-mem-mark-pages-as-not-accessed-when-reserving-VA.patch 2020-05-28 17:12:59.030558007 +0100 @@ -1 +1 @@ -From 8a4baf06c17a806696fb10aba36fce7471983028 Mon Sep 17 00:00:00 2001 +From 444b6438813fe82fb850748455b100ad11907bdc Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8a4baf06c17a806696fb10aba36fce7471983028 ] + @@ -19,2 +20,0 @@ -Cc: stable@dpdk.org - @@ -31 +31 @@ -index 4a9cc1f19a..cc7d54e0c7 100644 +index 9a14698aae..030f1b261c 100644 @@ -34 +34 @@ -@@ -98,5 +98,5 @@ eal_get_virtual_area(void *requested_addr, size_t *size, +@@ -113,5 +113,5 @@ eal_get_virtual_area(void *requested_addr, size_t *size,